Merge pull request #2436 from a1mery/react-graph-app-secret-expiration-upgrade-to-SPFx-1.14.0

React graph app secret expiration upgrade to sp fx 1.14.0

samples/react-graph-app-secret-expiration/.devcontainer/devcontainer.json

@@ -1,7 +1,7 @@
 // For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer
 {
-	"name": "SPFx 1.12.1",
+	"name": "SPFx 1.14.0",
-	"image": "docker.io/m365pnp/spfx:1.12.1",
+	"image": "docker.io/m365pnp/spfx:1.14.0",
 	// Set *default* container specific settings.json values on container create.
 	"settings": {},
 	// Add the IDs of extensions you want installed when the container is created.

samples/react-graph-app-secret-expiration/.gitignore

@@ -31,3 +31,7 @@ obj
 
 # Styles Generated Code
 *.scss.ts
+# .CER Certificates
+*.cer
+# .PEM Certificates
+*.pem

samples/react-graph-app-secret-expiration/.yo-rc.json

@@ -2,7 +2,7 @@
   "@microsoft/generator-sharepoint": {
     "isCreatingSolution": true,
     "environment": "spo",
-    "version": "1.12.1",
+    "version": "1.14.0",
     "libraryName": "react-graph-app-secret-expiration",
     "libraryId": "b25d85a4-7310-408a-a263-25959b0a5b1b",
     "packageManager": "npm",

samples/react-graph-app-secret-expiration/README.md

@@ -9,11 +9,13 @@ I got the idea from this great article [Use Power Automate to Notify of Upcoming
 
 ## Compatibility
 
-![SPFx 1.12.1](https://img.shields.io/badge/SPFx-1.12.1-green.svg)
+![SPFx 1.14](https://img.shields.io/badge/SPFx-1.14-green.svg)
-![Node.js v12 | v10](https://img.shields.io/badge/Node.js-v12%20%7C%20v10-green.svg) 
+![Node.js v14 | v12](https://img.shields.io/badge/Node.js-v14%20%7C%20v12-green.svg)
-![SharePoint Online](https://img.shields.io/badge/SharePoint-Online-yellow.svg)
+![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
-![Teams N/A: Untested with Microsoft Teams](https://img.shields.io/badge/Teams-N%2FA-lightgrey.svg "Untested with Microsoft Teams") 
+![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower")
-![Workbench Hosted: Does not work with local workbench](https://img.shields.io/badge/Workbench-Hosted-yellow.svg "Does not work with local workbench")
+![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1")
+![Local Workbench Unsupported](https://img.shields.io/badge/Local%20Workbench-Unsupported-red.svg "Local workbench is no longer available as of SPFx 1.13 and above")
+![Hosted Workbench Compatible](https://img.shields.io/badge/Hosted%20Workbench-Compatible-green.svg)
 ![Compatible with Remote Containers](https://img.shields.io/badge/Remote%20Containers-Compatible-green.svg)
 
 
@@ -35,12 +37,13 @@ Version|Date|Comments
 1.0|September 17, 2021|Initial release
 1.1|October 10, 2021|Add pagination
 1.2|November 04, 2021|Add group views
+1.3|March 14, 2022|Upgrade to SPFx v1.14.0
 
 
-## Minimal Path to Awesome
+## Minimal path to awesome
 
-- Clone this repository
+- Clone this repository (or [download this solution as a .ZIP file](https://pnp.github.io/download-partial/?url=https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-graph-app-secret-expiration) then unzip it)
-- Ensure that you are at the solution folder
+- From your command line, change your current directory to the directory containing this sample (`react-graph-app-secret-expiration`, located under `samples`)
 - In the command-line run:
   - `npm install`
   - `gulp bundle`
@@ -62,13 +65,20 @@ This sample illustrates the following concepts:
 
 ## Help
 
-We do not support samples, but we this community is always willing to help, and we want to improve these samples. We use GitHub to track issues, which makes it easy for  community members to volunteer their time and help resolve issues.
+We do not support samples, but this community is always willing to help, and we want to improve these samples. We use GitHub to track issues, which makes it easy for  community members to volunteer their time and help resolve issues.
+
+If you're having issues building the solution, please run [spfx doctor](https://pnp.github.io/cli-microsoft365/cmd/spfx/spfx-doctor/) from within the solution folder to diagnose incompatibility issues with your environment.
+
+You can try looking at [issues related to this sample](https://github.com/pnp/sp-dev-fx-webparts/issues?q=label%3A%22sample%3A%20react-graph-app-secret-expiration%22) to see if anybody else is having the same issues.
+
+You can also try looking at [discussions related to this sample](https://github.com/pnp/sp-dev-fx-webparts/discussions?discussions_q=react-graph-app-secret-expiration) and see what the community is saying.
 
 If you encounter any issues while using this sample, [create a new issue](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected%2Csample%3A%20react-graph-app-secret-expiration&template=bug-report.yml&sample=react-graph-app-secret-expiration&authors=@a1mery&title=react-graph-app-secret-expiration%20-%20).
 
 For questions regarding this sample, [create a new question](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Aquestion%2Csample%3A%20react-graph-app-secret-expiration&template=question.yml&sample=react-graph-app-secret-expiration&authors=@a1mery&title=react-graph-app-secret-expiration%20-%20).
 
-Finally, if you have an idea for improvement, [make a suggestion](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Aenhancement%2Csample%3A%20react-graph-app-secret-expiration&template=question.yml&sample=react-graph-app-secret-expiration&authors=@a1mery&title=react-graph-app-secret-expiration%20-%20).
+Finally, if you have an idea for improvement, [make a suggestion](https://github.com/pnp/sp-dev-fx-webparts/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Aenhancement%2Csample%3A%20react-graph-app-secret-expiration&template=suggestion.yml&sample=react-graph-app-secret-expiration&authors=@a1mery&title=react-graph-app-secret-expiration%20-%20).
+
 
 ## Disclaimer
 

samples/react-graph-app-secret-expiration/assets/sample.json

@@ -9,7 +9,7 @@
             "This sample web part shows the list of your applications registered in Azure AD along with their associated client secret/certificate expiration date."
         ],
         "creationDateTime": "2021-09-17",
-        "updateDateTime": "2021-11-04",
+        "updateDateTime": "2022-03-14",
         "products": [
             "SharePoint",
             "Office"
@@ -21,7 +21,7 @@
             },
             {
                 "key": "SPFX-VERSION",
-                "value": "1.12.1"
+                "value": "1.14.0"
             },
             {
                 "key": "PNPCONTROLS",

samples/react-graph-app-secret-expiration/config/copy-assets.json

@@ -1,4 +0,0 @@
-{
-  "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/copy-assets.schema.json",
-  "deployCdnPath": "./release/assets/"
-}

samples/react-graph-app-secret-expiration/config/package-solution.json

@@ -1,9 +1,28 @@
 {
   "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/package-solution.schema.json",
   "solution": {
+    "metadata": {
+      "shortDescription": {
+        "default": "react-graph-app-secret-expiration description"
+      },
+      "longDescription": {
+        "default": "react-graph-app-secret-expiration description"
+      },
+      "screenshotPaths": [],
+      "videoUrl": "",
+      "categories": []
+    },
+    "features": [
+      {
+        "title": "react-graph-app-secret-expiration Feature",
+        "description": "The feature that activates elements of the react-graph-app-secret-expiration solution.",
+        "id": "ca58f355-9872-4025-8ad5-763ad6076034",
+        "version": "1.3.0.0"
+      }
+    ],
     "name": "react-graph-app-secret-expiration-client-side-solution",
     "id": "b25d85a4-7310-408a-a263-25959b0a5b1b",
-    "version": "1.2.0.0",
+    "version": "1.3.0.0",
     "includeClientSideAssets": true,
     "isDomainIsolated": false,
     "skipFeatureDeployment": true,

samples/react-graph-app-secret-expiration/config/serve.json

@@ -2,9 +2,5 @@
   "$schema": "https://developer.microsoft.com/json-schemas/core-build/serve.schema.json",
   "port": 4321,
   "https": true,
-  "initialPage": "https://localhost:5432/workbench",
+  "initialPage": "https://enter-your-SharePoint-site/_layouts/workbench.aspx"
-  "api": {
-    "port": 5432,
-    "entryPath": "node_modules/@microsoft/sp-webpart-workbench/lib/api/"
-  }
 }

samples/react-graph-app-secret-expiration/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-graph-app-secret-expiration",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "private": true,
   "main": "lib/index.js",
   "scripts": {
@@ -9,29 +9,30 @@
     "test": "gulp test"
   },
   "dependencies": {
-    "@fluentui/react": "^8.34.2",
+    "@fluentui/react": "^8.61.0",
     "@microsoft/rush-stack-compiler-3.8": "^0.4.47",
-    "@microsoft/sp-core-library": "1.12.1",
+    "@microsoft/sp-core-library": "1.14.0",
-    "@microsoft/sp-lodash-subset": "1.12.1",
+    "@microsoft/sp-http": "^1.14.0",
-    "@microsoft/sp-office-ui-fabric-core": "1.12.1",
+    "@microsoft/sp-lodash-subset": "1.14.0",
-    "@microsoft/sp-property-pane": "1.12.1",
+    "@microsoft/sp-office-ui-fabric-core": "1.14.0",
-    "@microsoft/sp-webpart-base": "1.12.1",
+    "@microsoft/sp-property-pane": "1.14.0",
+    "@microsoft/sp-webpart-base": "1.14.0",
     "@pnp/spfx-controls-react": "3.3.0",
     "moment": "^2.29.1",
-    "office-ui-fabric-react": "7.156.0",
+    "office-ui-fabric-react": "7.174.1",
-    "react": "16.9.0",
+    "react": "16.13.1",
-    "react-dom": "16.9.0"
+    "react-dom": "16.13.1"
   },
   "devDependencies": {
-    "@types/react": "16.9.36",
-    "@types/react-dom": "16.9.8",
-    "@microsoft/sp-build-web": "1.12.1",
-    "@microsoft/sp-tslint-rules": "1.12.1",
-    "@microsoft/sp-module-interfaces": "1.12.1",
-    "@microsoft/sp-webpart-workbench": "1.12.1",
     "@microsoft/rush-stack-compiler-3.7": "0.2.3",
-    "gulp": "~4.0.2",
+    "@microsoft/rush-stack-compiler-3.9": "0.4.47",
+    "@microsoft/sp-build-web": "1.14.0",
+    "@microsoft/sp-module-interfaces": "1.14.0",
+    "@microsoft/sp-tslint-rules": "1.14.0",
+    "@types/react": "16.9.51",
+    "@types/react-dom": "16.9.8",
+    "@types/webpack-env": "1.13.1",
     "ajv": "~5.2.2",
-    "@types/webpack-env": "1.13.1"
+    "gulp": "~4.0.2"
   }
 }

samples/react-graph-app-secret-expiration/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "./node_modules/@microsoft/rush-stack-compiler-3.8/includes/tsconfig-web.json",
+  "extends": "./node_modules/@microsoft/rush-stack-compiler-3.9/includes/tsconfig-web.json",
   "compilerOptions": {
     "target": "es5",
     "forceConsistentCasingInFileNames": true,