| 
									
										
										
										
											2016-06-23 09:47:54 -07:00
										 |  |  | /** | 
					
						
							|  |  |  |  * @license | 
					
						
							|  |  |  |  * Copyright Google Inc. All Rights Reserved. | 
					
						
							|  |  |  |  * | 
					
						
							|  |  |  |  * Use of this source code is governed by an MIT-style license that can be | 
					
						
							|  |  |  |  * found in the LICENSE file at https://angular.io/license
 | 
					
						
							|  |  |  |  */ | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-08-17 16:37:31 -07:00
										 |  |  | import {TEST_COMPILER_PROVIDERS} from '@angular/compiler/testing/test_bindings'; | 
					
						
							| 
									
										
										
										
											2016-09-14 15:58:18 -07:00
										 |  |  | import {AfterContentChecked, AfterContentInit, AfterViewChecked, AfterViewInit, ChangeDetectionStrategy, Component, DoCheck, Injectable, NgModule, OnChanges, OnDestroy, OnInit, Pipe, SimpleChanges, ViewEncapsulation} from '@angular/core'; | 
					
						
							| 
									
										
										
										
											2016-06-08 16:38:52 -07:00
										 |  |  | import {LIFECYCLE_HOOKS_VALUES} from '@angular/core/src/metadata/lifecycle_hooks'; | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  | import {TestBed, async, inject} from '@angular/core/testing'; | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-23 09:42:19 -08:00
										 |  |  | import {identifierName} from '../src/compile_metadata'; | 
					
						
							| 
									
										
										
										
											2016-07-30 19:31:25 -07:00
										 |  |  | import {stringify} from '../src/facade/lang'; | 
					
						
							| 
									
										
										
										
											2016-04-28 17:50:03 -07:00
										 |  |  | import {CompileMetadataResolver} from '../src/metadata_resolver'; | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  | import {ResourceLoader} from '../src/resource_loader'; | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  | import {SyntaxError} from '../src/util'; | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  | import {MockResourceLoader} from '../testing/resource_loader_mock'; | 
					
						
							| 
									
										
										
										
											2016-02-18 10:53:21 -08:00
										 |  |  | import {MalformedStylesComponent} from './metadata_resolver_fixture'; | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | export function main() { | 
					
						
							| 
									
										
										
										
											2016-02-18 10:53:21 -08:00
										 |  |  |   describe('CompileMetadataResolver', () => { | 
					
						
							| 
									
										
										
										
											2016-07-28 04:54:49 -07:00
										 |  |  |     beforeEach(() => { TestBed.configureCompiler({providers: TEST_COMPILER_PROVIDERS}); }); | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |     it('should throw on the getDirectiveMetadata/getPipeMetadata methods if the module has not been loaded yet', | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |          @Pipe({name: 'pipe'}) | 
					
						
							|  |  |  |          class SomePipe { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |          expect(() => resolver.getDirectiveMetadata(ComponentWithEverythingInline)) | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |              .toThrowError(SyntaxError, /Illegal state/); | 
					
						
							|  |  |  |          expect(() => resolver.getPipeMetadata(SomePipe)) | 
					
						
							|  |  |  |              .toThrowError(SyntaxError, /Illegal state/); | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should read metadata in sync for components with inline resources', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [ComponentWithEverythingInline]}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, true); | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  |          const meta = resolver.getDirectiveMetadata(ComponentWithEverythingInline); | 
					
						
							|  |  |  |          expect(meta.selector).toEqual('someSelector'); | 
					
						
							|  |  |  |          expect(meta.exportAs).toEqual('someExportAs'); | 
					
						
							|  |  |  |          expect(meta.isComponent).toBe(true); | 
					
						
							|  |  |  |          expect(meta.type.reference).toBe(ComponentWithEverythingInline); | 
					
						
							| 
									
										
										
										
											2016-11-23 09:42:19 -08:00
										 |  |  |          expect(identifierName(meta.type)).toEqual(stringify(ComponentWithEverythingInline)); | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |          expect(meta.type.lifecycleHooks).toEqual(LIFECYCLE_HOOKS_VALUES); | 
					
						
							|  |  |  |          expect(meta.changeDetection).toBe(ChangeDetectionStrategy.Default); | 
					
						
							|  |  |  |          expect(meta.inputs).toEqual({'someProp': 'someProp'}); | 
					
						
							|  |  |  |          expect(meta.outputs).toEqual({'someEvent': 'someEvent'}); | 
					
						
							|  |  |  |          expect(meta.hostListeners).toEqual({'someHostListener': 'someHostListenerExpr'}); | 
					
						
							|  |  |  |          expect(meta.hostProperties).toEqual({'someHostProp': 'someHostPropExpr'}); | 
					
						
							|  |  |  |          expect(meta.hostAttributes).toEqual({'someHostAttr': 'someHostAttrValue'}); | 
					
						
							|  |  |  |          expect(meta.template.encapsulation).toBe(ViewEncapsulation.Emulated); | 
					
						
							|  |  |  |          expect(meta.template.styles).toEqual(['someStyle']); | 
					
						
							|  |  |  |          expect(meta.template.template).toEqual('someTemplate'); | 
					
						
							|  |  |  |          expect(meta.template.interpolation).toEqual(['{{', '}}']); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw when reading metadata for component with external resources when sync=true is passed', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [ComponentWithExternalResources]}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							|  |  |  |                  `Can't compile synchronously as ${stringify(ComponentWithExternalResources)} is still being loaded!`); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should read external metadata when sync=false', | 
					
						
							|  |  |  |        async(inject( | 
					
						
							|  |  |  |            [CompileMetadataResolver, ResourceLoader], | 
					
						
							|  |  |  |            (resolver: CompileMetadataResolver, resourceLoader: MockResourceLoader) => { | 
					
						
							|  |  |  |              @NgModule({declarations: [ComponentWithExternalResources]}) | 
					
						
							|  |  |  |              class SomeModule { | 
					
						
							|  |  |  |              } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |              resourceLoader.when('someTemplateUrl', 'someTemplate'); | 
					
						
							| 
									
										
										
										
											2016-11-29 15:36:33 -08:00
										 |  |  |              resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, false).then(() => { | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                const meta = resolver.getDirectiveMetadata(ComponentWithExternalResources); | 
					
						
							|  |  |  |                expect(meta.selector).toEqual('someSelector'); | 
					
						
							|  |  |  |                expect(meta.template.styleUrls).toEqual(['someStyleUrl']); | 
					
						
							|  |  |  |                expect(meta.template.templateUrl).toEqual('someTemplateUrl'); | 
					
						
							|  |  |  |                expect(meta.template.template).toEqual('someTemplate'); | 
					
						
							|  |  |  |              }); | 
					
						
							|  |  |  |              resourceLoader.flush(); | 
					
						
							|  |  |  |            }))); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-23 09:42:19 -08:00
										 |  |  |     it('should use `./` as base url for templates during runtime compilation if no moduleId is given', | 
					
						
							|  |  |  |        async(inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @Component({selector: 'someComponent', templateUrl: 'someUrl'}) | 
					
						
							|  |  |  |          class ComponentWithoutModuleId { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |          @NgModule({declarations: [ComponentWithoutModuleId]}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 15:36:33 -08:00
										 |  |  |          resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, false).then(() => { | 
					
						
							| 
									
										
										
										
											2016-11-23 09:42:19 -08:00
										 |  |  |            const value: string = | 
					
						
							|  |  |  |                resolver.getDirectiveMetadata(ComponentWithoutModuleId).template.templateUrl; | 
					
						
							|  |  |  |            const expectedEndValue = './someUrl'; | 
					
						
							|  |  |  |            expect(value.endsWith(expectedEndValue)).toBe(true); | 
					
						
							|  |  |  |          }); | 
					
						
							|  |  |  |        }))); | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  |     it('should throw when the moduleId is not a string', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [ComponentWithInvalidModuleId]}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, `moduleId should be a string in "ComponentWithInvalidModuleId". See` + | 
					
						
							|  |  |  |                      ` https://goo.gl/wIDDiL for more information.\n` + | 
					
						
							|  |  |  |                      `If you're using Webpack you should inline the template and the styles, see` + | 
					
						
							|  |  |  |                      ` https://goo.gl/X2J8zc.`); | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw when metadata is incorrectly typed', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [MalformedStylesComponent]}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError(`Expected 'styles' to be an array of strings.`); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw with descriptive error message when provider token can not be resolved', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [MyBrokenComp1]}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, true)) | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |              .toThrowError(SyntaxError, `Can't resolve all parameters for MyBrokenComp1: (?).`); | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |        })); | 
					
						
							|  |  |  |     it('should throw with descriptive error message when a directive is passed to imports', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({imports: [ComponentWithoutModuleId]}) | 
					
						
							|  |  |  |          class ModuleWithImportedComponent { | 
					
						
							|  |  |  |          } | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect( | 
					
						
							|  |  |  |              () => resolver.loadNgModuleDirectiveAndPipeMetadata(ModuleWithImportedComponent, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                  `Unexpected directive 'ComponentWithoutModuleId' imported by the module 'ModuleWithImportedComponent'`); | 
					
						
							| 
									
										
										
										
											2016-10-28 14:08:54 -07:00
										 |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |     it('should throw with descriptive error message when a pipe is passed to imports', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @Pipe({name: 'somePipe'}) | 
					
						
							|  |  |  |          class SomePipe { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  |          @NgModule({imports: [SomePipe]}) | 
					
						
							|  |  |  |          class ModuleWithImportedPipe { | 
					
						
							|  |  |  |          } | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(ModuleWithImportedPipe, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                  `Unexpected pipe 'SomePipe' imported by the module 'ModuleWithImportedPipe'`); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw with descriptive error message when a module is passed to declarations', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  |          @NgModule({declarations: [SomeModule]}) | 
					
						
							|  |  |  |          class ModuleWithDeclaredModule { | 
					
						
							|  |  |  |          } | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(ModuleWithDeclaredModule, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                  `Unexpected module 'SomeModule' declared by the module 'ModuleWithDeclaredModule'`); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw with descriptive error message when null is passed to declarations', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [null]}) | 
					
						
							|  |  |  |          class ModuleWithNullDeclared { | 
					
						
							|  |  |  |          } | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(ModuleWithNullDeclared, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                  `Unexpected value 'null' declared by the module 'ModuleWithNullDeclared'`); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw with descriptive error message when null is passed to imports', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({imports: [null]}) | 
					
						
							|  |  |  |          class ModuleWithNullImported { | 
					
						
							|  |  |  |          } | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(ModuleWithNullImported, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                  `Unexpected value 'null' imported by the module 'ModuleWithNullImported'`); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw with descriptive error message when a param token of a dependency is undefined', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [MyBrokenComp2]}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, true)) | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |              .toThrowError( | 
					
						
							|  |  |  |                  SyntaxError, `Can't resolve all parameters for NonAnnotatedService: (?).`); | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw with descriptive error message when one of providers is not present', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [MyBrokenComp3]}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                  `Invalid providers for "MyBrokenComp3" - only instances of Provider and Type are allowed, got: [SimpleService, ?null?, ...]`); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw with descriptive error message when one of viewProviders is not present', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [MyBrokenComp4]}) | 
					
						
							|  |  |  |          class SomeModule { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                  `Invalid viewProviders for "MyBrokenComp4" - only instances of Provider and Type are allowed, got: [?null?, ...]`); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw with descriptive error message when null or undefined is passed to module bootstrap', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({bootstrap: [null]}) | 
					
						
							|  |  |  |          class ModuleWithNullBootstrap { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  |          @NgModule({bootstrap: [undefined]}) | 
					
						
							|  |  |  |          class ModuleWithUndefinedBootstrap { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(ModuleWithNullBootstrap, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                  `Unexpected value 'null' used in the bootstrap property of module 'ModuleWithNullBootstrap'`); | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect( | 
					
						
							|  |  |  |              () => | 
					
						
							|  |  |  |                  resolver.loadNgModuleDirectiveAndPipeMetadata(ModuleWithUndefinedBootstrap, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError( | 
					
						
							| 
									
										
										
										
											2016-12-15 13:07:12 -08:00
										 |  |  |                  SyntaxError, | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |                  `Unexpected value 'undefined' used in the bootstrap property of module 'ModuleWithUndefinedBootstrap'`); | 
					
						
							|  |  |  |        })); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |     it('should throw an error when the interpolation config has invalid symbols', | 
					
						
							|  |  |  |        inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  |          @NgModule({declarations: [ComponentWithInvalidInterpolation1]}) | 
					
						
							|  |  |  |          class Module1 { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(Module1, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError(`[' ', ' '] contains unusable interpolation symbol.`); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |          @NgModule({declarations: [ComponentWithInvalidInterpolation2]}) | 
					
						
							|  |  |  |          class Module2 { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(Module2, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError(`['{', '}'] contains unusable interpolation symbol.`); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |          @NgModule({declarations: [ComponentWithInvalidInterpolation3]}) | 
					
						
							|  |  |  |          class Module3 { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(Module3, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError(`['<%', '%>'] contains unusable interpolation symbol.`); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |          @NgModule({declarations: [ComponentWithInvalidInterpolation4]}) | 
					
						
							|  |  |  |          class Module4 { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(Module4, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError(`['&#', '}}'] contains unusable interpolation symbol.`); | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |          @NgModule({declarations: [ComponentWithInvalidInterpolation5]}) | 
					
						
							|  |  |  |          class Module5 { | 
					
						
							|  |  |  |          } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 08:08:22 -08:00
										 |  |  |          expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(Module5, true)) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |              .toThrowError(`['{', '}}'] contains unusable interpolation symbol.`); | 
					
						
							|  |  |  |        })); | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  |   }); | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  | 
 | 
					
						
							|  |  |  |   it('should dedupe declarations in NgModule', | 
					
						
							|  |  |  |      inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |        @Component({template: ''}) | 
					
						
							|  |  |  |        class MyComp { | 
					
						
							|  |  |  |        } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  |        @NgModule({declarations: [MyComp, MyComp]}) | 
					
						
							|  |  |  |        class MyModule { | 
					
						
							|  |  |  |        } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-29 15:36:33 -08:00
										 |  |  |        const modMeta = resolver.getNgModuleMetadata(MyModule); | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  |        expect(modMeta.declaredDirectives.length).toBe(1); | 
					
						
							|  |  |  |        expect(modMeta.declaredDirectives[0].reference).toBe(MyComp); | 
					
						
							|  |  |  |      })); | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-12-13 17:35:33 -08:00
										 |  |  | @Component({selector: 'someComponent', template: ''}) | 
					
						
							|  |  |  | class ComponentWithoutModuleId { | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-09-14 16:49:13 -07:00
										 |  |  | @Component({selector: 'someComponent', template: '', moduleId: <any>0}) | 
					
						
							|  |  |  | class ComponentWithInvalidModuleId { | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  | @Component({ | 
					
						
							|  |  |  |   selector: 'someSelector', | 
					
						
							|  |  |  |   templateUrl: 'someTemplateUrl', | 
					
						
							|  |  |  |   styleUrls: ['someStyleUrl'], | 
					
						
							|  |  |  | }) | 
					
						
							|  |  |  | class ComponentWithExternalResources { | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  | @Component({ | 
					
						
							|  |  |  |   selector: 'someSelector', | 
					
						
							| 
									
										
										
										
											2015-09-30 20:59:23 -07:00
										 |  |  |   inputs: ['someProp'], | 
					
						
							|  |  |  |   outputs: ['someEvent'], | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  |   host: { | 
					
						
							|  |  |  |     '[someHostProp]': 'someHostPropExpr', | 
					
						
							|  |  |  |     '(someHostListener)': 'someHostListenerExpr', | 
					
						
							|  |  |  |     'someHostAttr': 'someHostAttrValue' | 
					
						
							|  |  |  |   }, | 
					
						
							| 
									
										
										
										
											2015-09-18 10:33:23 -07:00
										 |  |  |   exportAs: 'someExportAs', | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  |   moduleId: 'someModuleId', | 
					
						
							| 
									
										
										
										
											2016-06-27 20:00:30 -07:00
										 |  |  |   changeDetection: ChangeDetectionStrategy.Default, | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  |   template: 'someTemplate', | 
					
						
							|  |  |  |   encapsulation: ViewEncapsulation.Emulated, | 
					
						
							|  |  |  |   styles: ['someStyle'], | 
					
						
							| 
									
										
										
										
											2016-06-20 09:52:41 -07:00
										 |  |  |   interpolation: ['{{', '}}'] | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  | }) | 
					
						
							| 
									
										
										
										
											2016-11-10 14:07:30 -08:00
										 |  |  | class ComponentWithEverythingInline implements OnChanges, | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  |     OnInit, DoCheck, OnDestroy, AfterContentInit, AfterContentChecked, AfterViewInit, | 
					
						
							|  |  |  |     AfterViewChecked { | 
					
						
							| 
									
										
										
										
											2016-05-09 15:45:04 -07:00
										 |  |  |   ngOnChanges(changes: SimpleChanges): void {} | 
					
						
							| 
									
										
											  
											
												refactor(lifecycle): prefix lifecycle methods with "ng"
BREAKING CHANGE:
Previously, components that would implement lifecycle interfaces would include methods
like "onChanges" or "afterViewInit." Given that components were at risk of using such
names without realizing that Angular would call the methods at different points of
the component lifecycle. This change adds an "ng" prefix to all lifecycle hook methods,
far reducing the risk of an accidental name collision.
To fix, just rename these methods:
 * onInit
 * onDestroy
 * doCheck
 * onChanges
 * afterContentInit
 * afterContentChecked
 * afterViewInit
 * afterViewChecked
 * _Router Hooks_
 * onActivate
 * onReuse
 * onDeactivate
 * canReuse
 * canDeactivate
To:
 * ngOnInit,
 * ngOnDestroy,
 * ngDoCheck,
 * ngOnChanges,
 * ngAfterContentInit,
 * ngAfterContentChecked,
 * ngAfterViewInit,
 * ngAfterViewChecked
 * _Router Hooks_
 * routerOnActivate
 * routerOnReuse
 * routerOnDeactivate
 * routerCanReuse
 * routerCanDeactivate
The names of lifecycle interfaces and enums have not changed, though interfaces
have been updated to reflect the new method names.
Closes #5036
											
										 
											2015-11-16 17:04:36 -08:00
										 |  |  |   ngOnInit(): void {} | 
					
						
							|  |  |  |   ngDoCheck(): void {} | 
					
						
							|  |  |  |   ngOnDestroy(): void {} | 
					
						
							|  |  |  |   ngAfterContentInit(): void {} | 
					
						
							|  |  |  |   ngAfterContentChecked(): void {} | 
					
						
							|  |  |  |   ngAfterViewInit(): void {} | 
					
						
							|  |  |  |   ngAfterViewChecked(): void {} | 
					
						
							| 
									
										
										
										
											2015-09-14 15:59:09 -07:00
										 |  |  | } | 
					
						
							| 
									
										
										
										
											2016-06-10 01:07:06 +02:00
										 |  |  | 
 | 
					
						
							|  |  |  | @Component({selector: 'my-broken-comp', template: ''}) | 
					
						
							|  |  |  | class MyBrokenComp1 { | 
					
						
							|  |  |  |   constructor(public dependency: any) {} | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
										
											2016-06-20 09:52:41 -07:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-06-18 18:42:34 +02:00
										 |  |  | class NonAnnotatedService { | 
					
						
							|  |  |  |   constructor(dep: any) {} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | @Component({selector: 'my-broken-comp', template: '', providers: [NonAnnotatedService]}) | 
					
						
							|  |  |  | class MyBrokenComp2 { | 
					
						
							|  |  |  |   constructor(dependency: NonAnnotatedService) {} | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-06-22 02:27:27 +02:00
										 |  |  | @Injectable() | 
					
						
							|  |  |  | class SimpleService { | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-08-24 01:18:41 +02:00
										 |  |  | @Component({selector: 'my-broken-comp', template: '', providers: [SimpleService, null, [null]]}) | 
					
						
							| 
									
										
										
										
											2016-06-22 02:27:27 +02:00
										 |  |  | class MyBrokenComp3 { | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | @Component({selector: 'my-broken-comp', template: '', viewProviders: [null, SimpleService, [null]]}) | 
					
						
							|  |  |  | class MyBrokenComp4 { | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2016-06-20 09:52:41 -07:00
										 |  |  | @Component({selector: 'someSelector', template: '', interpolation: [' ', ' ']}) | 
					
						
							|  |  |  | class ComponentWithInvalidInterpolation1 { | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | @Component({selector: 'someSelector', template: '', interpolation: ['{', '}']}) | 
					
						
							|  |  |  | class ComponentWithInvalidInterpolation2 { | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | @Component({selector: 'someSelector', template: '', interpolation: ['<%', '%>']}) | 
					
						
							|  |  |  | class ComponentWithInvalidInterpolation3 { | 
					
						
							|  |  |  | } | 
					
						
							| 
									
										
										
										
											2016-06-21 16:55:17 -07:00
										 |  |  | 
 | 
					
						
							|  |  |  | @Component({selector: 'someSelector', template: '', interpolation: ['&#', '}}']}) | 
					
						
							|  |  |  | class ComponentWithInvalidInterpolation4 { | 
					
						
							|  |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							|  |  |  | @Component({selector: 'someSelector', template: '', interpolation: ['{', '}}']}) | 
					
						
							|  |  |  | class ComponentWithInvalidInterpolation5 { | 
					
						
							|  |  |  | } |