2018-08-09 09:23:56 -04:00
|
|
|
|
#!/bin/bash
|
|
|
|
|
|
2018-08-09 08:54:20 -04:00
|
|
|
|
set -e -x
|
2018-08-09 09:23:56 -04:00
|
|
|
|
|
|
|
|
|
PATH=$PATH:$(npm bin)
|
|
|
|
|
|
2018-08-09 10:59:10 -04:00
|
|
|
|
ivy-ngcc --help
|
|
|
|
|
|
|
|
|
|
# node --inspect-brk $(npm bin)/ivy-ngcc -f esm2015
|
2019-04-03 11:37:36 -04:00
|
|
|
|
# Run ngcc and check it logged compilation output as expected
|
|
|
|
|
ivy-ngcc | grep 'Compiling'
|
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
2018-08-09 10:59:10 -04:00
|
|
|
|
|
2018-08-17 17:00:00 -04:00
|
|
|
|
# Did it add the appropriate build markers?
|
2019-03-20 09:47:58 -04:00
|
|
|
|
|
|
|
|
|
# - esm2015
|
2019-03-20 09:47:59 -04:00
|
|
|
|
grep '"__processed_by_ivy_ngcc__":[^}]*"esm2015":"' node_modules/@angular/common/package.json
|
2019-03-20 09:47:58 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
|
2018-10-03 12:00:05 -04:00
|
|
|
|
# - fesm2015
|
2019-03-20 09:47:59 -04:00
|
|
|
|
grep '"__processed_by_ivy_ngcc__":[^}]*"fesm2015":"' node_modules/@angular/common/package.json
|
2018-10-03 12:00:05 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
2019-03-20 09:47:59 -04:00
|
|
|
|
grep '"__processed_by_ivy_ngcc__":[^}]*"es2015":"' node_modules/@angular/common/package.json
|
2019-03-20 09:47:58 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
|
|
|
|
|
# - esm5
|
2019-03-20 09:47:59 -04:00
|
|
|
|
grep '"__processed_by_ivy_ngcc__":[^}]*"esm5":"' node_modules/@angular/common/package.json
|
2019-03-20 09:47:58 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
|
|
|
|
|
# - fesm5
|
2019-03-20 09:47:59 -04:00
|
|
|
|
grep '"__processed_by_ivy_ngcc__":[^}]*"module":"' node_modules/@angular/common/package.json
|
2019-03-20 09:47:58 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
2019-03-20 09:47:59 -04:00
|
|
|
|
grep '"__processed_by_ivy_ngcc__":[^}]*"fesm5":"' node_modules/@angular/common/package.json
|
2018-10-03 12:00:05 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
|
refactor(ivy): obviate the Bazel component of the ivy_switch (#26550)
Originally, the ivy_switch mechanism used Bazel genrules to conditionally
compile one TS file or another depending on whether ngc or ngtsc was the
selected compiler. This was done because we wanted to avoid importing
certain modules (and thus pulling them into the build) if Ivy was on or
off. This mechanism had a major drawback: ivy_switch became a bottleneck
in the import graph, as it both imports from many places in the codebase
and is imported by many modules in the codebase. This frequently resulted
in cyclic imports which caused issues both with TS and Closure compilation.
It turns out ngcc needs both code paths in the bundle to perform the switch
during its operation anyway, so import switching was later abandoned. This
means that there's no real reason why the ivy_switch mechanism needed to
operate at the Bazel level, and for the ivy_switch file to be a bottleneck.
This commit removes the Bazel-level ivy_switch mechanism, and introduces
an additional TypeScript transform in ngtsc (and the pass-through tsc
compiler used for testing JIT) to perform the same operation that ngcc
does, and flip the switch during ngtsc compilation. This allows the
ivy_switch file to be removed, and the individual switches to be located
directly next to their consumers in the codebase, greatly mitigating the
circular import issues and making the mechanism much easier to use.
As part of this commit, the tag for marking switched variables was changed
from __PRE_NGCC__ to __PRE_R3__, since it's no longer just ngcc which
flips these tags. Most variables were renamed from R3_* to SWITCH_* as well,
since they're referenced mostly in render2 code.
Test strategy: existing test coverage is more than sufficient - if this
didn't work correctly it would break the hello world and todo apps.
PR Close #26550
2018-10-17 18:44:44 -04:00
|
|
|
|
# Did it replace the PRE_R3 markers correctly?
|
|
|
|
|
grep "= SWITCH_COMPILE_COMPONENT__POST_R3__" node_modules/@angular/core/fesm2015/core.js
|
2018-10-03 12:00:05 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
refactor(ivy): obviate the Bazel component of the ivy_switch (#26550)
Originally, the ivy_switch mechanism used Bazel genrules to conditionally
compile one TS file or another depending on whether ngc or ngtsc was the
selected compiler. This was done because we wanted to avoid importing
certain modules (and thus pulling them into the build) if Ivy was on or
off. This mechanism had a major drawback: ivy_switch became a bottleneck
in the import graph, as it both imports from many places in the codebase
and is imported by many modules in the codebase. This frequently resulted
in cyclic imports which caused issues both with TS and Closure compilation.
It turns out ngcc needs both code paths in the bundle to perform the switch
during its operation anyway, so import switching was later abandoned. This
means that there's no real reason why the ivy_switch mechanism needed to
operate at the Bazel level, and for the ivy_switch file to be a bottleneck.
This commit removes the Bazel-level ivy_switch mechanism, and introduces
an additional TypeScript transform in ngtsc (and the pass-through tsc
compiler used for testing JIT) to perform the same operation that ngcc
does, and flip the switch during ngtsc compilation. This allows the
ivy_switch file to be removed, and the individual switches to be located
directly next to their consumers in the codebase, greatly mitigating the
circular import issues and making the mechanism much easier to use.
As part of this commit, the tag for marking switched variables was changed
from __PRE_NGCC__ to __PRE_R3__, since it's no longer just ngcc which
flips these tags. Most variables were renamed from R3_* to SWITCH_* as well,
since they're referenced mostly in render2 code.
Test strategy: existing test coverage is more than sufficient - if this
didn't work correctly it would break the hello world and todo apps.
PR Close #26550
2018-10-17 18:44:44 -04:00
|
|
|
|
grep "= SWITCH_COMPILE_COMPONENT__POST_R3__" node_modules/@angular/core/fesm5/core.js
|
2018-10-03 12:00:05 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
|
|
|
|
|
# Did it compile @angular/core/ApplicationModule correctly?
|
2019-04-04 14:41:52 -04:00
|
|
|
|
grep "ApplicationModule.ngModuleDef = ΔdefineNgModule" node_modules/@angular/core/fesm2015/core.js
|
2018-10-03 12:00:05 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
2019-04-04 14:41:52 -04:00
|
|
|
|
grep "ApplicationModule.ngModuleDef = ΔdefineNgModule" node_modules/@angular/core/fesm5/core.js
|
2018-10-03 12:00:05 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
2019-04-04 14:41:52 -04:00
|
|
|
|
grep "ApplicationModule.ngModuleDef = ɵngcc0.ΔdefineNgModule" node_modules/@angular/core/esm2015/src/application_module.js
|
2018-10-03 12:00:05 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
2019-04-04 14:41:52 -04:00
|
|
|
|
grep "ApplicationModule.ngModuleDef = ɵngcc0.ΔdefineNgModule" node_modules/@angular/core/esm5/src/application_module.js
|
2018-10-03 12:00:05 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
|
2018-11-11 18:07:42 -05:00
|
|
|
|
# Did it transform @angular/core typing files correctly?
|
2019-03-06 03:05:06 -05:00
|
|
|
|
grep "import [*] as ɵngcc0 from './src/r3_symbols';" node_modules/@angular/core/core.d.ts
|
2018-11-11 18:07:42 -05:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
2019-04-04 14:41:52 -04:00
|
|
|
|
grep "static ngInjectorDef: ɵngcc0.ΔInjectorDef<ApplicationModule>;" node_modules/@angular/core/core.d.ts
|
2018-11-11 18:07:42 -05:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
|
2019-01-02 17:25:58 -05:00
|
|
|
|
# Did it generate a base factory call for synthesized constructors correctly?
|
2019-04-04 14:41:52 -04:00
|
|
|
|
grep "const ɵMatTable_BaseFactory = ɵngcc0.ΔgetInheritedFactory(MatTable);" node_modules/@angular/material/esm2015/table.js
|
2019-01-02 17:25:58 -05:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
2019-04-04 14:41:52 -04:00
|
|
|
|
grep "const ɵMatTable_BaseFactory = ɵngcc0.ΔgetInheritedFactory(MatTable);" node_modules/@angular/material/esm5/table.es5.js
|
2019-01-02 17:25:58 -05:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
|
2018-10-03 12:00:05 -04:00
|
|
|
|
# Can it be safely run again (as a noop)?
|
2019-04-03 11:37:36 -04:00
|
|
|
|
# And check that it logged skipping compilation as expected
|
|
|
|
|
ivy-ngcc | grep 'Skipping'
|
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
|
|
|
|
|
# Check that running it with logging level error outputs nothing
|
|
|
|
|
ivy-ngcc -l error | grep '.' && exit 1
|
2018-08-09 10:59:10 -04:00
|
|
|
|
|
2019-03-20 09:47:58 -04:00
|
|
|
|
# Does running it with --formats fail?
|
|
|
|
|
ivy-ngcc --formats fesm2015 && exit 1
|
|
|
|
|
|
2018-10-03 12:00:05 -04:00
|
|
|
|
# Now try compiling the app using the ngcc compiled libraries
|
2018-08-09 09:23:56 -04:00
|
|
|
|
ngc -p tsconfig-app.json
|
|
|
|
|
|
2018-10-15 06:02:38 -04:00
|
|
|
|
# Did it compile the main.ts correctly (including the ngIf and MatButton directives)?
|
|
|
|
|
grep "directives: \[.*\.NgIf.*\]" dist/src/main.js
|
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|
|
|
|
|
grep "directives: \[.*\.MatButton.*\]" dist/src/main.js
|
2018-10-03 12:00:05 -04:00
|
|
|
|
if [[ $? != 0 ]]; then exit 1; fi
|