2019-05-31 11:56:07 -04:00
|
|
|
/**
|
|
|
|
|
* @license
|
2020-05-19 15:08:49 -04:00
|
|
|
* Copyright Google LLC All Rights Reserved.
|
2019-05-31 11:56:07 -04:00
|
|
|
*
|
|
|
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
|
|
|
* found in the LICENSE file at https://angular.io/license
|
|
|
|
|
*/
|
|
|
|
|
Zone.__load_patch('socketio', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
|
|
|
|
|
(Zone as any)[Zone.__symbol__('socketio')] = function patchSocketIO(io: any) {
|
|
|
|
|
// patch io.Socket.prototype event listener related method
|
fix(zone.js): should continue to executue listeners when throw error (#41562)
Close #41522
`zone.js` patches event listeners and run all event listeners together, if
one event handler throws error, the listeners afterward may not be invoked.
Reproduction:
```
export class AppComponent implements AfterViewInit {
@ViewChild('btn') btn: ElementRef;
title = 'event-error';
constructor(private ngZone: NgZone) {}
ngAfterViewInit() {
this.ngZone.runOutsideAngular(() => {
this.btn.nativeElement.addEventListener('click', () => {
throw new Error('test1');
});
this.btn.nativeElement.addEventListener('click', () => {
console.log('add eventlistener click');
});
});
}
}
```
Until now no Angular users report this issue becuase in the `ngZone`, all
error will be caught and will not rethrow, so the event listeners afterward
will still continue to execute, but if the event handlers are outside of `ngZone`,
the error will break the execution.
This commit catch all errors, and after all event listeners finished invocation,
rethrow the errors in seperate `microTasks`, the reason I am using `microTask` here
is to handle multiple errors case.
PR Close #41562
2021-04-11 02:19:23 -04:00
|
|
|
api.patchEventTarget(global, api, [io.Socket.prototype], {
|
2019-05-31 11:56:07 -04:00
|
|
|
useG: false,
|
|
|
|
|
chkDup: false,
|
|
|
|
|
rt: true,
|
2020-04-13 19:40:21 -04:00
|
|
|
diff: (task: any, delegate: any) => {
|
|
|
|
|
return task.callback === delegate;
|
|
|
|
|
}
|
2019-05-31 11:56:07 -04:00
|
|
|
});
|
|
|
|
|
// also patch io.Socket.prototype.on/off/removeListener/removeAllListeners
|
|
|
|
|
io.Socket.prototype.on = io.Socket.prototype.addEventListener;
|
|
|
|
|
io.Socket.prototype.off = io.Socket.prototype.removeListener =
|
|
|
|
|
io.Socket.prototype.removeAllListeners = io.Socket.prototype.removeEventListener;
|
|
|
|
|
};
|
|
|
|
|
});
|
