From 01bb3c5820520f3a5c3fca3d0b8716b159bdad0a Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Wed, 6 Feb 2019 10:26:36 +0200 Subject: [PATCH] ci: save the cache in `build-npm-packages` job instead of `test` (#28555) In most cases, it doesn't make a difference, because the cache does already exist and is not saved. In the few cases where the dependencies change (and the cache needs to be updated), it makes more sense to save the cache in the `build-npm-packages` job, because most jobs depend on it and thus will be able to take advantage of the updated cache right away. This seems to be an oversight in b26ac1c22. PR Close #28555 --- .circleci/config.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 1d32b4bccd..4189fde095 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -117,12 +117,6 @@ jobs: - run: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc - run: yarn bazel test //... --build_tag_filters=-ivy-only,local --test_tag_filters=-ivy-only,local - - save_cache: - key: *cache_key - paths: - - "node_modules" - - "~/bazel_repository_cache" - # Temporary job to test what will happen when we flip the Ivy flag to true test_ivy_aot: <<: *job_defaults @@ -355,6 +349,12 @@ jobs: paths: - packages-dist + - save_cache: + key: *cache_key + paths: + - "node_modules" + - "~/bazel_repository_cache" + # Build the ivy npm packages. build-ivy-npm-packages: