iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ivy): prevent templateOverrides from causing infinite loop (#29402) 

Previously, the transitive scope calculation could lead into re-compiling
the same module multiple times. This fix ensures we cannot get into this loop.
It should be fixed more completely (e.g. more cases) once FW-1178 is resolved.

PR Close #29402
This commit is contained in:
Kara Erickson 2019-03-19 13:01:23 -07:00 committed by Matias Niemelä
parent 8714daf276
commit 067657c1e9
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/core/testing/src/r3_test_bed.ts
View File

@ -822,7 +822,8 @@ export class TestBedRender3 implements Injector, TestBed {
// if we have template override via `TestBed.overrideTemplateUsingTestingModule` - // if we have template override via `TestBed.overrideTemplateUsingTestingModule` -
// define Component scope as TestingModule scope, instead of the scope of NgModule // define Component scope as TestingModule scope, instead of the scope of NgModule
// where this Component was declared // where this Component was declared
calcTransitiveScopesFor(this._testModuleType) : // TODO: This is only a partial fix. Should be fixed completely with FW-1178 refactor.
transitiveScopesFor(this._testModuleType) :
transitiveScope; transitiveScope;
patchComponentDefWithScope((cmp as any).ngComponentDef, scope); patchComponentDefWithScope((cmp as any).ngComponentDef, scope);
}); });