diff --git a/.github/angular-robot.yml b/.github/angular-robot.yml index 471cba19d1..d807d258e1 100644 --- a/.github/angular-robot.yml +++ b/.github/angular-robot.yml @@ -62,6 +62,13 @@ merge: # list of checks that will determine if the merge label can be added checks: + + # require that the PR has reviews from all requested reviewers + # + # This enables us to request reviews from both eng and tech writers, or multiple eng folks, and prevents accidental merges. + # Rather than merging PRs with pending reviews, if all PullApprove requirements are satisfied and additional reviews are not needed pending reviewers should be removed via GitHub UI (this also leaves an audit trail behind these decisions). + requireReviews: true, + # whether the PR shouldn't have a conflict with the base branch noConflict: true # list of labels that a PR needs to have, checked with a regexp (e.g. "PR target:" will work for the label "PR target: master")