From 0bc26fc4e8768acd6c19366d928e061c06195620 Mon Sep 17 00:00:00 2001 From: Kara Erickson Date: Tue, 26 Feb 2019 13:50:52 -0800 Subject: [PATCH] ci: remove dev-infra as owner on material-ci folder (#28990) Currently, whenever someone on fw-core approvals list approves a change to the angular_material_blocklist.js file, it is not sufficient because dev-infra is also requested as a mandatory reviewer. This does not make sense because this folder only contains the list of ignored tests and not anything dev-infra related. Previously, we tried to fix this by creating a "Material CI" section underneath the existing "Build & CI" section, so that the "Material CI" rule would override the rule matching the entire "tools" folder. Unfortunately, this did not work. This commit attempts to resolve the problem by explicitly marking all sub-folders in the "tools" folder as owned by dev-infra (leaving out "material-ci"), so "material-ci" is only referenced by the rule assigning fw-core as code owners. PR Close #28990 --- .github/CODEOWNERS | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 1ebe36be54..e2984c874b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -750,14 +750,29 @@ testing/** @angular/fw-test /packages/* @angular/fw-dev-infra /scripts/** @angular/fw-dev-infra /third_party/** @angular/fw-dev-infra -/tools/** @angular/fw-dev-infra +/tools/build/** @angular/fw-dev-infra +/tools/cjs-jasmine/** @angular/fw-dev-infra +/tools/gulp-tasks/** @angular/fw-dev-infra +/tools/ngcontainer/** @angular/fw-dev-infra +/tools/npm/** @angular/fw-dev-infra +/tools/npm_workspace/** @angular/fw-dev-infra +/tools/public_api_guard/** @angular/fw-dev-infra +/tools/rxjs/** @angular/fw-dev-infra +/tools/source-map-test/** @angular/fw-dev-infra +/tools/symbol-extractor/** @angular/fw-dev-infra +/tools/testing/** @angular/fw-dev-infra +/tools/ts-api-guardian/** @angular/fw-dev-infra +/tools/tslint/** @angular/fw-dev-infra +/tools/validate-commit-message/** @angular/fw-dev-infra +/tools/yarn/** @angular/fw-dev-infra +/tools/* *.bzl @angular/fw-dev-infra # ================================================ # Material CI # ================================================ -/tools/material-ci/** @angular/fw-core @angular/fw-dev-infra +/tools/material-ci/** @angular/fw-core @angular/framework-global-approvers # ================================================