From 0c61a35ea3d86d0a0cd7a46e5446f1f7f0956702 Mon Sep 17 00:00:00 2001 From: Ayaz Hafiz Date: Wed, 10 Jul 2019 11:43:14 -0700 Subject: [PATCH] fix(bazel): pass custom bazel compiler host rather than rewriting one (#31496) Switch back to passing a custom bazel host instead of rewriting one that is passed to `compile` now that the Angular indexer is stable. Revert "feat(bazel): allow passing and rewriting an old bazel host" This reverts commit 0a4c1c8f803a65f5c156af90e67f7d7d68ebc7f8. PR Close #31496 --- packages/bazel/src/ngc-wrapped/index.ts | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/bazel/src/ngc-wrapped/index.ts b/packages/bazel/src/ngc-wrapped/index.ts index 2d7bf6ea14..74b2c7b47f 100644 --- a/packages/bazel/src/ngc-wrapped/index.ts +++ b/packages/bazel/src/ngc-wrapped/index.ts @@ -145,7 +145,7 @@ export function relativeToRootDirs(filePath: string, rootDirs: string[]): string } export function compile({allDepsCompiledWithBazel = true, compilerOpts, tsHost, bazelOpts, files, - inputs, expectedOuts, gatherDiagnostics, oldBazelHost}: { + inputs, expectedOuts, gatherDiagnostics, bazelHost}: { allDepsCompiledWithBazel?: boolean, compilerOpts: ng.CompilerOptions, tsHost: ts.CompilerHost, inputs?: {[path: string]: string}, @@ -153,7 +153,7 @@ export function compile({allDepsCompiledWithBazel = true, compilerOpts, tsHost, files: string[], expectedOuts: string[], gatherDiagnostics?: (program: ng.Program) => ng.Diagnostics, - oldBazelHost?: CompilerHost, + bazelHost?: CompilerHost, }): {diagnostics: ng.Diagnostics, program: ng.Program} { let fileLoader: FileLoader; @@ -246,12 +246,9 @@ export function compile({allDepsCompiledWithBazel = true, compilerOpts, tsHost, moduleName, containingFile, compilerOptions, generatedFileModuleResolverHost); } - const bazelHost = new CompilerHost( - files, compilerOpts, bazelOpts, tsHost, fileLoader, generatedFileModuleResolver); - if (oldBazelHost) { - // TODO(ayazhafiz): this kind of patching is hacky. Revisit this after the - // indexer consumer of this code is known to be working. - Object.assign(bazelHost, oldBazelHost); + if (!bazelHost) { + bazelHost = new CompilerHost( + files, compilerOpts, bazelOpts, tsHost, fileLoader, generatedFileModuleResolver); } // Also need to disable decorator downleveling in the BazelHost in Ivy mode.