From 0dcac966b4bb8adae8c6cf9439a79eac3a9c5cdb Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Thu, 9 Feb 2017 09:52:35 -0800 Subject: [PATCH] build: pin versions in integration/*/package.json (#14378) Floating versions can break our CI. This happened with concurrently release last evening. Ideally we should just check in the yarn.lock file but are blocked on https://github.com/yarnpkg/yarn/issues/2256 PR Close #14378 --- integration/hello_world__closure/package.json | 15 +++++++-------- integration/typings_test_ts21/package.json | 7 +++---- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/integration/hello_world__closure/package.json b/integration/hello_world__closure/package.json index 1708c94bfc..6db7b71bde 100644 --- a/integration/hello_world__closure/package.json +++ b/integration/hello_world__closure/package.json @@ -10,20 +10,19 @@ "@angular/platform-browser": "file:../../dist/packages-dist-es2015/platform-browser", "@angular/platform-server": "file:../../dist/packages-dist-es2015/platform-server", "@angular/tsc-wrapped": "file:../../dist/tools/@angular/tsc-wrapped", - "google-closure-compiler": "^20161201.0.0", + "google-closure-compiler": "20161201.0.0", "rxjs": "file:../../node_modules/rxjs", - "source-map-explorer": "^1.3.3", - "typescript": "~2.1", - "zone.js": "^0.7.6" + "typescript": "2.1.6", + "zone.js": "0.7.6" }, "devDependencies": { - "@types/jasmine": "^2.5.41", - "concurrently": "^3.1.0", - "lite-server": "^2.2.2", + "@types/jasmine": "2.5.41", + "concurrently": "3.1.0", + "lite-server": "2.2.2", "protractor": "file:../../node_modules/protractor" }, "scripts": { - "test": "ngc && ./bundle.sh && concurrently \"PATH=$PATH yarn run serve\" \"PATH=$PATH yarn run protractor\" --kill-others --success first", + "test": "ngc && ./bundle.sh && concurrently \"yarn run serve\" \"yarn run protractor\" --kill-others --success first", "serve": "lite-server -c e2e/browser.config.json", "preprotractor": "tsc -p e2e", "protractor": "protractor e2e/protractor.config.js" diff --git a/integration/typings_test_ts21/package.json b/integration/typings_test_ts21/package.json index cc9b76a83b..6ced304afd 100644 --- a/integration/typings_test_ts21/package.json +++ b/integration/typings_test_ts21/package.json @@ -15,11 +15,10 @@ "@angular/router": "file:../../dist/packages-dist/router", "@angular/tsc-wrapped": "file:../../dist/tools/@angular/tsc-wrapped", "@angular/upgrade": "file:../../dist/packages-dist/upgrade", - "@types/jasmine": "^2.5.41", + "@types/jasmine": "2.5.41", "rxjs": "file:../../node_modules/rxjs", - "source-map-explorer": "^1.3.3", - "typescript": "~2.1", - "zone.js": "^0.7.6" + "typescript": "2.1.6", + "zone.js": "0.7.6" }, "scripts": { "test": "tsc"