From 133fe5e5612d5751ac6731aa312ec3c0853e0061 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matias=20Niemel=C3=A4?= Date: Fri, 11 Jan 2019 14:25:22 -0800 Subject: [PATCH] test(ivy): update root causes for animation tests (#28091) PR Close #28091 --- .../animation/animation_integration_spec.ts | 66 +++++++++---------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/packages/core/test/animation/animation_integration_spec.ts b/packages/core/test/animation/animation_integration_spec.ts index e954dbdb70..62ab270af0 100644 --- a/packages/core/test/animation/animation_integration_spec.ts +++ b/packages/core/test/animation/animation_integration_spec.ts @@ -3375,8 +3375,8 @@ const DEFAULT_COMPONENT_ID = '1'; expect(getLog().length).toEqual(1); }); - fixmeIvy('unknown').it( - 'should treat the property as true when the expression is missing', () => { + fixmeIvy('FW-951 - Attribute-only synthetic properties are treated differently in Ivy') + .it('should treat the property as true when the expression is missing', () => { @Component({ selector: 'parent-cmp', animations: [ @@ -3674,19 +3674,19 @@ const DEFAULT_COMPONENT_ID = '1'; expect(() => { TestBed.createComponent(Cmp); }).not.toThrowError(); }); - fixmeIvy('unknown').it( - 'should continue to clean up DOM-related animation artificats even if a compiler-level error is thrown midway', - () => { - @Component({ - selector: 'if-cmp', - animations: [ - trigger( - 'foo', - [ - transition('* => something', []), - ]), - ], - template: ` + fixmeIvy('FW-952 - Error recovery is handled differently in Ivy than VE') + .it('should continue to clean up DOM-related animation artificats even if a compiler-level error is thrown midway', + () => { + @Component({ + selector: 'if-cmp', + animations: [ + trigger( + 'foo', + [ + transition('* => something', []), + ]), + ], + template: ` value = {{ foo[bar] }}
1
@@ -3694,32 +3694,32 @@ const DEFAULT_COMPONENT_ID = '1';
3
`, - }) - class Cmp { - exp: any = false; + }) + class Cmp { + exp: any = false; - @ViewChild('contents') public contents: any; - } + @ViewChild('contents') public contents: any; + } - TestBed.configureTestingModule({declarations: [Cmp]}); + TestBed.configureTestingModule({declarations: [Cmp]}); - const engine = TestBed.get(ɵAnimationEngine); - const fixture = TestBed.createComponent(Cmp); + const engine = TestBed.get(ɵAnimationEngine); + const fixture = TestBed.createComponent(Cmp); - const runCD = () => fixture.detectChanges(); - const cmp = fixture.componentInstance; + const runCD = () => fixture.detectChanges(); + const cmp = fixture.componentInstance; - cmp.exp = true; - expect(runCD).toThrow(); + cmp.exp = true; + expect(runCD).toThrow(); - const contents = cmp.contents.nativeElement; - expect(contents.innerText.replace(/\s+/gm, '')).toEqual('123'); + const contents = cmp.contents.nativeElement; + expect(contents.innerText.replace(/\s+/gm, '')).toEqual('123'); - cmp.exp = false; - expect(runCD).toThrow(); + cmp.exp = false; + expect(runCD).toThrow(); - expect(contents.innerText.trim()).toEqual(''); - }); + expect(contents.innerText.trim()).toEqual(''); + }); describe('errors for not using the animation module', () => { beforeEach(() => {