From 1d4dde2adcf036229cdf7ec1f7a4f2b47dc92d77 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Wed, 27 Feb 2019 19:57:28 +0100 Subject: [PATCH] ci(docs-infra): disable failing ivy jit systemjs examples (#28984) As a side effect of 09b34bae8655d4251516655c317b150c46cd3653, we fixed that the docs systemjs examples currently do not run with Ivy in JIT mode. This now uncovered new failures with the JIT resource loading. e.g. ``` zone.js:665 Unhandled Promise rejection: Component 'PhoneListComponent' is not resolved: - templateUrl: ./phone-list.template.html Did you run and wait for 'resolveComponentResources()'? ; Zone: ; Task: Promise.then ; Value: Error: Component 'PhoneListComponent' is not resolved: - templateUrl: ./phone-list.template.html Did you run and wait for 'resolveComponentResources()'? at Function.get (directive.ts:54) at getComponentDef (definition.ts:648) at verifyDeclarationsHaveDefinitions (module.ts:185) at Array.forEach () at verifySemanticsOfNgModuleDef (module.ts:159) at Function.get (module.ts:132) at getInjectorDef (defs.ts:181) at R3Injector.processInjectorType (r3_injector.ts:230) at eval (r3_injector.ts:114) at eval (r3_injector.ts:451) Error: Component 'PhoneListComponent' is not resolved: ``` We temporarily disable these two failing SystemJS examples by adding them to the `fixmeIvyExamples` list. PR Close #28984 --- aio/tools/examples/run-example-e2e.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/aio/tools/examples/run-example-e2e.js b/aio/tools/examples/run-example-e2e.js index 27bba29d50..9245168b2f 100644 --- a/aio/tools/examples/run-example-e2e.js +++ b/aio/tools/examples/run-example-e2e.js @@ -22,7 +22,11 @@ const IGNORED_EXAMPLES = [ const fixmeIvyExamples = [ // fixmeIvy('unknown') app fails at runtime due to missing external service (goog is undefined) - 'i18n' + 'i18n', + // fixmeIvy('unknown') JIT app fails with external resources not loaded. + 'upgrade-phonecat-2-hybrid', + // fixmeIvy('unknown') JIT app fails with external resources not loaded. + 'upgrade-phonecat-3-final', ]; if (argv.ivy) {