Revert "build: derive ts_library dep from jasmine_node_test boostrap label if it ends in _es5 (#34589)" (#34730)

This reverts commit 79a0d007b4e892dd988a8ef697e6d3436ea8391c.

PR Close #34730

packages/animations/browser/test/BUILD.bazel

@@ -19,6 +19,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/animations/test/BUILD.bazel

@@ -16,6 +16,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/bazel/src/schematics/BUILD.bazel

@@ -17,5 +17,6 @@ jasmine_node_test(
         "//packages/bazel/src/schematics/ng-add:test",
         "//packages/bazel/src/schematics/ng-new:test",
         "//packages/bazel/src/schematics/utility:test",
+        "//tools/testing:node",
     ],
 )

packages/benchpress/test/BUILD.bazel

@@ -20,6 +20,7 @@ jasmine_node_test(
         ":test_lib",
         "//packages/benchpress",
         "//packages/core/testing",
+        "//tools/testing:node",
         "@npm//protractor",
     ],
 )

packages/common/http/test/BUILD.bazel

@@ -22,6 +22,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/common/http/testing/test/BUILD.bazel

@@ -20,6 +20,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/common/test/BUILD.bazel

@@ -27,6 +27,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/common/upgrade/test/BUILD.bazel

@@ -19,5 +19,6 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )

packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel

@@ -27,5 +27,6 @@ jasmine_node_test(
         "//packages/platform-server",
         "//packages/platform-server/testing",
         "//packages/private/testing",
+        "//tools/testing:node",
     ],
 )

packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel

@@ -28,5 +28,6 @@ jasmine_node_test(
     ],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )

packages/compiler-cli/test/BUILD.bazel

@@ -53,6 +53,7 @@ jasmine_node_test(
         ":extract_i18n_lib",
         "//packages/common:npm_package",
         "//packages/core",
+        "//tools/testing:node",
         "@npm//minimist",
     ],
 )
@@ -90,6 +91,7 @@ jasmine_node_test(
     deps = [
         ":ngc_lib",
         "//packages/core",
+        "//tools/testing:node",
         "@npm//minimist",
         "@npm//rxjs",
         "@npm//tsickle",
@@ -121,6 +123,7 @@ jasmine_node_test(
     deps = [
         ":perform_watch_lib",
         "//packages/core",
+        "//tools/testing:node",
     ],
 )
 
@@ -147,5 +150,6 @@ jasmine_node_test(
     deps = [
         ":perform_compile_lib",
         "//packages/core",
+        "//tools/testing:node",
     ],
 )

packages/compiler-cli/test/diagnostics/BUILD.bazel

@@ -28,6 +28,7 @@ jasmine_node_test(
     deps = [
         ":check_types_lib",
         "//packages/core",
+        "//tools/testing:node",
     ],
 )
 
@@ -47,5 +48,6 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":typescript_version_lib",
+        "//tools/testing:node",
     ],
 )

packages/compiler-cli/test/metadata/BUILD.bazel

@@ -22,5 +22,6 @@ jasmine_node_test(
     deps = [
         ":test_lib",
         "//packages/core",
+        "//tools/testing:node",
     ],
 )

packages/compiler-cli/test/transformers/BUILD.bazel

@@ -33,6 +33,7 @@ jasmine_node_test(
     deps = [
         ":test_lib",
         "//packages/core",
+        "//tools/testing:node",
         "@npm//source-map",
     ],
 )

packages/compiler/test/BUILD.bazel

@@ -83,6 +83,7 @@ jasmine_node_test(
     deps = [
         ":test_lib",
         ":test_node_only_lib",
+        "//tools/testing:node",
         "@npm//base64-js",
         "@npm//source-map",
     ],

packages/compiler/test/css_parser/BUILD.bazel

@@ -19,6 +19,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":css_parser_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/compiler/test/expression_parser/BUILD.bazel

@@ -18,6 +18,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":expression_parser_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/compiler/test/ml_parser/BUILD.bazel

@@ -16,6 +16,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":ml_parser_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/compiler/test/render3/BUILD.bazel

@@ -21,5 +21,6 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )

packages/compiler/test/selector/BUILD.bazel

@@ -20,6 +20,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":selector_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/core/test/BUILD.bazel

@@ -67,6 +67,7 @@ jasmine_node_test(
         "//packages/platform-server",
         "//packages/platform-server/testing",
         "//packages/zone.js/lib:zone_d_ts",
+        "//tools/testing:node",
         "@npm//base64-js",
         "@npm//source-map",
     ],

packages/core/test/acceptance/BUILD.bazel

@@ -41,6 +41,7 @@ jasmine_node_test(
     deps = [
         ":acceptance_lib",
         "//packages/zone.js/lib:zone_d_ts",
+        "//tools/testing:node",
         "@npm//base64-js",
         "@npm//source-map",
     ],

packages/core/test/render3/BUILD.bazel

@@ -63,6 +63,7 @@ jasmine_node_test(
     name = "render3",
     bootstrap = [":domino_es5"],
     deps = [
+        ":domino",
         ":render3_node_lib",
         "//packages/zone.js/lib",
     ],

packages/core/test/render3/ivy/BUILD.bazel

@@ -22,6 +22,7 @@ jasmine_node_test(
     ],
     deps = [
         ":ivy_lib",
+        "//packages/core/test/render3:domino",
         "//packages/zone.js/lib",
     ],
 )

packages/core/test/strict_types/BUILD.bazel

@@ -27,5 +27,6 @@ jasmine_node_test(
     name = "strict_types",
     deps = [
         ":strict_types_lib",
+        "//tools/testing:node",
     ],
 )

packages/core/test/view/BUILD.bazel

@@ -41,6 +41,7 @@ jasmine_node_test(
     deps = [
         ":view_lib",
         ":view_node_only_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/examples/core/BUILD.bazel

@@ -81,5 +81,6 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":core_tests_lib",
+        "//tools/testing:node",
     ],
 )

packages/examples/core/testing/ts/BUILD.bazel

@@ -18,5 +18,6 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":fake_async_lib",
+        "//tools/testing:node",
     ],
 )

packages/forms/test/BUILD.bazel

@@ -23,6 +23,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/http/test/BUILD.bazel

@@ -23,6 +23,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/localize/schematics/ng-add/BUILD.bazel

@@ -46,5 +46,6 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )

packages/platform-browser-dynamic/test/BUILD.bazel

@@ -21,6 +21,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/platform-browser/animations/test/BUILD.bazel

@@ -27,6 +27,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/platform-browser/test/BUILD.bazel

@@ -32,6 +32,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/platform-server/test/BUILD.bazel

@@ -27,5 +27,6 @@ jasmine_node_test(
     ],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )

packages/platform-webworker/test/BUILD.bazel

@@ -24,6 +24,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/router/test/BUILD.bazel

@@ -26,6 +26,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/router/test/aot_ngsummary_test/BUILD.bazel

@@ -30,5 +30,6 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":aot_test_lib",
+        "//tools/testing:node",
     ],
 )

packages/service-worker/config/test/BUILD.bazel

@@ -19,5 +19,6 @@ jasmine_node_test(
         ":test_lib",
         "//packages/service-worker/config",
         "//packages/service-worker/config/testing",
+        "//tools/testing:node",
     ],
 )

packages/service-worker/test/BUILD.bazel

@@ -21,6 +21,7 @@ jasmine_node_test(
     bootstrap = ["//tools/testing:node_es5"],
     deps = [
         ":test_lib",
+        "//tools/testing:node",
     ],
 )
 

packages/zone.js/test/BUILD.bazel

@@ -206,11 +206,17 @@ jasmine_node_test(
 jasmine_node_test(
     name = "test_node_error_disable_policy",
     bootstrap = [":node_error_disable_policy_entry_point_es5"],
+    deps = [
+        ":node_error_disable_policy_entry_point",
+    ],
 )
 
 jasmine_node_test(
     name = "test_node_error_lazy_policy",
     bootstrap = [":node_error_lazy_policy_entry_point_es5"],
+    deps = [
+        ":node_error_lazy_policy_entry_point",
+    ],
 )
 
 ts_library(

tools/defaults.bzl

@@ -281,11 +281,6 @@ def jasmine_node_test(bootstrap = [], **kwargs):
     for label in bootstrap:
         deps += [label]
         templated_args += ["--node_options=--require=$(rlocation $(location %s))" % label]
-        if label.endswith("_es5"):
-            # If this label is a filegroup derived from a ts_library then automtically
-            # add the ts_library target (which is the label sans `_es5`) to deps so we pull
-            # in all of its transitive deps
-            deps += [label[:-4]]
 
     _jasmine_node_test(
         deps = deps,