fix(compiler): don't overwrite missingTranslation's value in JIT (#19952)

This commit is contained in:
Olivier Combe 2017-11-03 19:08:39 +01:00 committed by Victor Berchet
parent f1da1419fa
commit 26f82995f6
2 changed files with 22 additions and 2 deletions

View File

@ -25,7 +25,8 @@ export class CompilerConfig {
constructor( constructor(
{defaultEncapsulation = ViewEncapsulation.Emulated, useJit = true, jitDevMode = false, {defaultEncapsulation = ViewEncapsulation.Emulated, useJit = true, jitDevMode = false,
missingTranslation, enableLegacyTemplate, preserveWhitespaces, strictInjectionParameters}: { missingTranslation = null, enableLegacyTemplate, preserveWhitespaces,
strictInjectionParameters}: {
defaultEncapsulation?: ViewEncapsulation, defaultEncapsulation?: ViewEncapsulation,
useJit?: boolean, useJit?: boolean,
jitDevMode?: boolean, jitDevMode?: boolean,
@ -37,7 +38,7 @@ export class CompilerConfig {
this.defaultEncapsulation = defaultEncapsulation; this.defaultEncapsulation = defaultEncapsulation;
this.useJit = !!useJit; this.useJit = !!useJit;
this.jitDevMode = !!jitDevMode; this.jitDevMode = !!jitDevMode;
this.missingTranslation = missingTranslation || null; this.missingTranslation = missingTranslation;
this.enableLegacyTemplate = enableLegacyTemplate === true; this.enableLegacyTemplate = enableLegacyTemplate === true;
this.preserveWhitespaces = preserveWhitespacesDefault(noUndefined(preserveWhitespaces)); this.preserveWhitespaces = preserveWhitespacesDefault(noUndefined(preserveWhitespaces));
this.strictInjectionParameters = strictInjectionParameters === true; this.strictInjectionParameters = strictInjectionParameters === true;

View File

@ -0,0 +1,19 @@
/**
* @license
* Copyright Google Inc. All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import {MissingTranslationStrategy} from '@angular/core';
import {CompilerConfig} from '../src/config';
export function main() {
describe('compiler config', () => {
it('should set missing translation strategy', () => {
const config = new CompilerConfig({missingTranslation: MissingTranslationStrategy.Error});
expect(config.missingTranslation).toEqual(MissingTranslationStrategy.Error);
});
});
}