iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(docs-infra): fix external link icons positioning (#41794) 

While trying to fix the appearance of `<code>` elements inside of
anchors with external URLs in #41694, the positioning of external link
icons was broken for anchors that would span multiple lines (see #41774
for details).

This commit fixes the positioning of external link icons, while still
preserving the correct appearance of `<code>` elements inside anchors
with external URLs.

NOTE:
Different types of links with external URLs can be seen in the following
docs sections:
- http://localhost:4200/docs#assumptions
- http://localhost:4200/guide/http#security-xsrf-protection
- http://localhost:4200/guide/workspace-config#generation-schematics

Fixes #41774

PR Close #41794
This commit is contained in:
George Kalpakas 2021-04-24 12:04:37 +03:00 committed by Jessica Janiuk
parent 01e546f116
commit 27ad7624d0
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
aio/src/styles/0-base/_typography.scss
View File

@ -210,6 +210,7 @@ code {
> a { > a {
&[href^="http:"], &[href^="http:"],
&[href^="https:"] { &[href^="https:"] {
display: inline-flex;
padding-right: calc(1em + 0.25rem); padding-right: calc(1em + 0.25rem);
position: relative; position: relative;

16
aio/src/styles/2-modules/_code.scss
View File

@ -169,11 +169,17 @@ aio-code {
} }
} }
:not(h1):not(h2):not(h3):not(h4):not(h5):not(h6):not(pre) > code { :not(h1):not(h2):not(h3):not(h4):not(h5):not(h6):not(pre) {
background-color: rgba($lightgray, 0.5); > code {
border-radius: 4px; background-color: rgba($lightgray, 0.5);
color: $deepgray; border-radius: 4px;
padding: 4px; color: $deepgray;
padding: 0 4px;
}
&:not(a) > code {
padding: 4px;
}
} }
.page-guide-cheatsheet & { .page-guide-cheatsheet & {