iSharkFly-Docs/angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(about): dialog should not show twitter if empty

Browse Source 
* The bio directive accidentally shows the Twitter link in the dialog, even if it's undefined.

* Fix deprecation warning of Angular Material, where `md-dialog-actions` should be used instead of the class.
This commit is contained in:
Paul Gschwendtner 2016-09-17 15:52:26 +02:00 committed by Naomi Black
parent 0b95826e79
commit 28d742ffce
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
public/about/index.jade
View File

@ -22,7 +22,7 @@
for person, name in bios for person, name in bios
if person.type == type if person.type == type
.c3 .c3
md-card(biocard class="bio-card" website="#{person.website}" twitter="#{person.twitter}" pic="#{person.picture}" bio="#{person.bio}" name="#{person.name}") md-card(biocard class="bio-card" website=person.website twitter=person.twitter pic=person.picture bio=person.bio name=person.name)
header header
image(src="#{person.picture}" alt="#person.name") image(src="#{person.picture}" alt="#person.name")

4
public/resources/js/directives/bio.js
View File

@ -33,11 +33,11 @@ angularIO.directive('biocard', function($rootScope, $timeout, $mdDialog) {
' </div>' + ' </div>' +
' <p class="text-body">{{bio}}</p>' + ' <p class="text-body">{{bio}}</p>' +
' </md-content>' + ' </md-content>' +
' <div class="md-actions">' + ' <md-dialog-actions>' +
' <md-button ng-click="closeDialog()">' + ' <md-button ng-click="closeDialog()">' +
' Close Bio' + ' Close Bio' +
' </md-button>' + ' </md-button>' +
' </div>' + ' </md-dialog-actions>' +
'</md-dialog>' '</md-dialog>'
}); });
}); });