From 2a45b932e2453d315bee417c63c0792981d0ba57 Mon Sep 17 00:00:00 2001 From: Misko Hevery Date: Tue, 28 Jul 2020 11:54:11 -0700 Subject: [PATCH] build: fix broken build (#38274) ``` export const __core_private_testing_placeholder__ = ''; ``` This API should be removed. But doing so seems to break `google3` and so it requires a bit of investigation. A work around is to mark it as `@codeGenApi` for now and investigate later. PR Close #38274 --- goldens/public-api/core/testing/testing.d.ts | 3 +++ packages/core/testing/src/before_each.ts | 11 +++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/goldens/public-api/core/testing/testing.d.ts b/goldens/public-api/core/testing/testing.d.ts index 634bcffbc9..b2ef64a7d7 100644 --- a/goldens/public-api/core/testing/testing.d.ts +++ b/goldens/public-api/core/testing/testing.d.ts @@ -1,3 +1,6 @@ +/** @codeGenApi */ +export declare const __core_private_testing_placeholder__ = ""; + export declare function async(fn: Function): (done: any) => any; export declare class ComponentFixture { diff --git a/packages/core/testing/src/before_each.ts b/packages/core/testing/src/before_each.ts index f438935169..fe9427c87f 100644 --- a/packages/core/testing/src/before_each.ts +++ b/packages/core/testing/src/before_each.ts @@ -27,6 +27,13 @@ if (_global.beforeEach) { }); } -// TODO(juliemr): remove this, only used because we need to export something to have compilation -// work. +/** + * This API should be removed. But doing so seems to break `google3` and so it requires a bit of + * investigation. + * + * A work around is to mark it as `@codeGenApi` for now and investigate later. + * + * @codeGenApi + */ +// TODO(iminar): Remove this code in a safe way. export const __core_private_testing_placeholder__ = '';