From 2a634648c27159f11f8b15bce2e6a52413e61d2b Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Wed, 20 May 2020 14:53:13 +0100 Subject: [PATCH] ci: testing folders in compiler-cli should not require `fw-testing`approval (#37220) The `fw-testing` PullApprove group is really designed to capture the top level public testing API groups in packages like `common` and `router`. The compiler-cli also has some folders that contain the path segment `testing` but these should not require `fw-testing` PullApprove approval. This commit excludes the whole of `compiler-cli` package from the `fw-testing` group. PR Close #37220 --- .pullapprove.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 90d72b65fe..b889e340d4 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -569,7 +569,7 @@ groups: - *can-be-global-approved - *can-be-global-docs-approved - > - contains_any_globs(files, [ + contains_any_globs(files.exclude('packages/compiler-cli/**'), [ '**/testing/**', 'aio/content/guide/testing.md', 'aio/content/examples/testing/**',