From 2ba799ddc796d56cbf58a3a926d595d45ba1144c Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Sat, 13 Apr 2019 14:01:03 +0200 Subject: [PATCH] fix(bazel): do not typecheck core schematic files (#29876) Currently for Angular Bazel projects, NGC needs to be run in the "postinstall" NPM script in order to generate required summary files. We need to update the postinstall `tsconfig` to not check/re-build the `@angular/core` schematic code which has transitive dependencies which are only available inside of a CLI project. As this is not guaranteed to be the case with Angular Bazel projects, we need to make sure that we don't check/re-build these files. PR Close #29876 --- integration/bazel/angular-metadata.tsconfig.json | 1 + .../ng-add/files/angular-metadata.tsconfig.json.template | 1 + 2 files changed, 2 insertions(+) diff --git a/integration/bazel/angular-metadata.tsconfig.json b/integration/bazel/angular-metadata.tsconfig.json index b056626de0..cb78c7133f 100644 --- a/integration/bazel/angular-metadata.tsconfig.json +++ b/integration/bazel/angular-metadata.tsconfig.json @@ -20,6 +20,7 @@ ], "exclude": [ "node_modules/@angular/bazel/**", + "node_modules/@angular/core/schematics/**", "node_modules/@angular/compiler-cli/**", "node_modules/@angular/**/testing/**", "node_modules/@angular/router/upgrade*" diff --git a/packages/bazel/src/schematics/ng-add/files/angular-metadata.tsconfig.json.template b/packages/bazel/src/schematics/ng-add/files/angular-metadata.tsconfig.json.template index 37e78208d5..9861531242 100644 --- a/packages/bazel/src/schematics/ng-add/files/angular-metadata.tsconfig.json.template +++ b/packages/bazel/src/schematics/ng-add/files/angular-metadata.tsconfig.json.template @@ -17,6 +17,7 @@ ], "exclude": [ "node_modules/@angular/bazel/**", + "node_modules/@angular/core/schematics/**", "node_modules/@angular/compiler-cli/**", "node_modules/@angular/**/testing/**", "node_modules/@angular/router/upgrade*"