test(core): fix schematics calls to run synchronously (#34364)

Previously the calls to run the schematics were not being properly
or consistently awaited in the tests. While this currently does not
affect the tests' performance, this fix corrects the syntax and
adds stability for future changes.

PR Close #34364

packages/core/schematics/test/dynamic_queries_migration_spec.ts

@@ -160,6 +160,6 @@ describe('dynamic queries migration', () => {
   }
 
   function runMigration() {
-    runner.runSchematicAsync('migration-v9-dynamic-queries', {}, tree).toPromise();
+    return runner.runSchematicAsync('migration-v9-dynamic-queries', {}, tree).toPromise();
   }
 });

packages/core/schematics/test/missing_injectable_migration_spec.ts

@@ -63,8 +63,8 @@ describe('Missing injectable migration', () => {
     host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents));
   }
 
-  async function runMigration() {
-    await runner.runSchematicAsync('migration-v9-missing-injectable', {}, tree).toPromise();
+  function runMigration() {
+    return runner.runSchematicAsync('migration-v9-missing-injectable', {}, tree).toPromise();
   }
 
   describe('NgModule', () => createTests('NgModule', 'providers'));

packages/core/schematics/test/module_with_providers_migration_spec.ts

@@ -230,6 +230,6 @@ describe('ModuleWithProviders migration', () => {
   }
 
   function runMigration() {
-    runner.runSchematicAsync('migration-v9-module-with-providers', {}, tree).toPromise();
+    return runner.runSchematicAsync('migration-v9-module-with-providers', {}, tree).toPromise();
   }
 });

packages/core/schematics/test/move_document_migration_spec.ts

@@ -165,6 +165,6 @@ describe('move-document migration', () => {
   }
 
   function runMigration() {
-    runner.runSchematicAsync('migration-v8-move-document', {}, tree).toPromise();
+    return runner.runSchematicAsync('migration-v8-move-document', {}, tree).toPromise();
   }
 });

packages/core/schematics/test/static_queries_migration_template_spec.ts

@@ -100,8 +100,8 @@ describe('static-queries migration with template strategy', () => {
     host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents));
   }
 
-  async function runMigration() {
-    await runner.runSchematicAsync('migration-v8-static-queries', {}, tree).toPromise();
+  function runMigration() {
+    return runner.runSchematicAsync('migration-v8-static-queries', {}, tree).toPromise();
   }
 
   describe('ViewChild', () => {

packages/core/schematics/test/static_queries_migration_usage_spec.ts

@@ -172,8 +172,8 @@ describe('static-queries migration with usage strategy', () => {
     host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents));
   }
 
-  async function runMigration() {
-    await runner.runSchematicAsync('migration-v8-static-queries', {}, tree).toPromise();
+  function runMigration() {
+    return runner.runSchematicAsync('migration-v8-static-queries', {}, tree).toPromise();
   }
 
   function createQueryTests(queryType: 'ViewChild' | 'ContentChild') {

packages/core/schematics/test/undecorated_classes_with_di_migration_spec.ts

@@ -68,13 +68,12 @@ describe('Undecorated classes with DI migration', () => {
     host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents));
   }
 
-  async function runMigration() {
+  function runMigration() {
     return runner.runSchematicAsync('migration-v9-undecorated-classes-with-di', {}, tree)
         .toPromise();
   }
 
-  function
-  writeFakeAngular() {
+  function writeFakeAngular() {
     writeFile('/node_modules/@angular/core/index.d.ts', `
       export declare class PipeTransform {}
       export declare class NgZone {}

packages/core/schematics/utils/typescript/compiler_host.ts

@@ -22,7 +22,7 @@ export function createMigrationCompilerHost(
     const treeRelativePath = relative(basePath, fileName);
     const fakeOutput = fakeRead ? fakeRead(treeRelativePath) : null;
     const buffer = fakeOutput === null ? tree.read(treeRelativePath) : fakeOutput;
-    // Strip BOM as otherwise TSC methods (Ex: getWidth) will return an offset which
+    // Strip BOM as otherwise TSC methods (Ex: getWidth) will return an offset,
     // which breaks the CLI UpdateRecorder.
     // See: https://github.com/angular/angular/pull/30719
     return buffer ? buffer.toString().replace(/^\uFEFF/, '') : undefined;