From 35acd44a0788dfb773d443ce37ab9d4b7dd36811 Mon Sep 17 00:00:00 2001 From: Alex Rickabaugh Date: Tue, 25 Jun 2019 13:11:51 -0700 Subject: [PATCH] Revert "build(bazel): add build --incompatible_list_based_execution_strategy_selection=false flag (#31019)" (#31267) This reverts commit ab2733761270886327382c8434eadc195950ecc7. Reason: this causes failures in g3 with i18n extraction. See #31267. PR Close #31267 --- .bazelrc | 26 +++----------------------- integration/bazel/.bazelrc | 9 --------- 2 files changed, 3 insertions(+), 32 deletions(-) diff --git a/.bazelrc b/.bazelrc index d7e732067b..3fb4982f94 100644 --- a/.bazelrc +++ b/.bazelrc @@ -152,30 +152,10 @@ build:remote --bes_results_url="https://source.cloud.google.com/results/invocati # This allows us to avoid installing a second copy of node_modules common --experimental_allow_incremental_repository_updates -# This option is changed to true in Bazel 0.27 and exposes a possible -# regression in Bazel 0.27.0. -# Error observed is in npm_package target `//packages/common/locales:package`: -# ``` -# ERROR: /home/circleci/ng/packages/common/locales/BUILD.bazel:13:1: Assembling -# npm package packages/common/locales/package failed: No usable spawn strategy found -# for spawn with mnemonic SkylarkAction. Your --spawn_strategyor --strategy flags -# are probably too strict. Visit https://github.com/bazelbuild/bazel/issues/7480 for -# migration advises -# ``` -# Suspect is https://github.com/bazelbuild/rules_nodejs/blob/master/internal/npm_package/npm_package.bzl#L75-L82: -# ``` -# execution_requirements = { -# # Never schedule this action remotely because it's not computationally expensive. -# # It just copies files into a directory; it's not worth copying inputs and outputs to a remote worker. -# # Also don't run it in a sandbox, because it resolves an absolute path to the bazel-out directory -# # allowing the .pack and .publish runnables to work with no symlink_prefix -# # See https://github.com/bazelbuild/rules_nodejs/issues/187 -# "local": "1", -# }, -# ``` +# This option is changed to true in Bazel 0.27 but exposes a known worker mode bug: +# https://github.com/bazelbuild/rules_typescript/issues/449 +# While we are fixing that issue, we need to keep this breaking change disabled build --incompatible_list_based_execution_strategy_selection=false -test --incompatible_list_based_execution_strategy_selection=false -run --incompatible_list_based_execution_strategy_selection=false #################################################### # User bazel configuration diff --git a/integration/bazel/.bazelrc b/integration/bazel/.bazelrc index efb76512d7..1e2c660e9c 100644 --- a/integration/bazel/.bazelrc +++ b/integration/bazel/.bazelrc @@ -20,12 +20,3 @@ build --symlink_prefix=/ # Turn on managed directories feature in Bazel # This allows us to avoid installing a second copy of node_modules common --experimental_allow_incremental_repository_updates - -# This option is changed to true in Bazel 0.27 and exposes a possible -# regression in Bazel 0.27.0. -# See root /.bazelrc for more info. integration/bazel uses -# ng_package which depends on npm_package so this flag needs to be set -# her as well. -build --incompatible_list_based_execution_strategy_selection=false -test --incompatible_list_based_execution_strategy_selection=false -run --incompatible_list_based_execution_strategy_selection=false