fix(compiler): ignore calls to unresolved symbols in metadata

This only shows up in the language service. Calls to symbols
that are not resolve resulted in null instead of being resolved
causing the language service to see exceptions when the null
was not expected such as in the animations array.

Fixes #15969
This commit is contained in:
Chuck Jazdzewski 2017-04-14 09:02:32 -07:00 committed by Tobias Bosch
parent 90814e4449
commit 38a7e0d1c7
3 changed files with 28 additions and 1 deletions

View File

@ -584,7 +584,7 @@ export class StaticReflector implements ɵReflectorReader {
return simplifyCall(staticSymbol, targetFunction, argExpressions); return simplifyCall(staticSymbol, targetFunction, argExpressions);
} }
} }
break; return IGNORE;
case 'error': case 'error':
let message = produceErrorMessage(expression); let message = produceErrorMessage(expression);
if (expression['line']) { if (expression['line']) {

View File

@ -546,6 +546,30 @@ describe('StaticReflector', () => {
expect(annotation.providers).toEqual([1, 2, 3, 4, 5, 6, 7]); expect(annotation.providers).toEqual([1, 2, 3, 4, 5, 6, 7]);
}); });
it('should ignore unresolved calls', () => {
const data = Object.create(DEFAULT_TEST_DATA);
const file = '/tmp/src/invalid-component.ts';
data[file] = `
import {Component} from '@angular/core';
import {unknown} from 'unresolved';
@Component({
selector: 'tmp',
template: () => {},
providers: [triggers()]
})
export class BadComponent {
}
`;
init(data, [], () => {}, {verboseInvalidExpression: true});
const badComponent = reflector.getStaticSymbol(file, 'BadComponent');
const annotations = reflector.annotations(badComponent);
const annotation = annotations[0];
expect(annotation.providers).toEqual([]);
});
describe('inheritance', () => { describe('inheritance', () => {
class ClassDecorator { class ClassDecorator {
constructor(public value: any) {} constructor(public value: any) {}

View File

@ -436,6 +436,9 @@ export class MockStaticSymbolResolverHost implements StaticSymbolResolverHost {
} }
return baseName + '.d.ts'; return baseName + '.d.ts';
} }
if (modulePath == 'unresolved') {
return undefined;
}
return '/tmp/' + modulePath + '.d.ts'; return '/tmp/' + modulePath + '.d.ts';
} }