From 38dfbc775f164c001258c1c8d52db7f411c5bde1 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Mon, 22 Jun 2020 19:16:33 +0300 Subject: [PATCH] ci(docs-infra): disable flaky tests (#37673) I could not figure out the root cause of the flakes, so disabling the flaky tests for now. See https://github.com/angular/angular/pull/37637#issuecomment-647608149 for more info. Fixes #37629 PR Close #37673 --- .../app/layout/doc-viewer/doc-viewer.component.spec.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/aio/src/app/layout/doc-viewer/doc-viewer.component.spec.ts b/aio/src/app/layout/doc-viewer/doc-viewer.component.spec.ts index 6aabeb6629..c626ca1130 100644 --- a/aio/src/app/layout/doc-viewer/doc-viewer.component.spec.ts +++ b/aio/src/app/layout/doc-viewer/doc-viewer.component.spec.ts @@ -401,7 +401,10 @@ describe('DocViewerComponent', () => { expect(loadElementsSpy.calls.argsFor(1)).toEqual([docViewer.nextViewContainer]); }); - it('should unsubscribe from the previous "embed" observable when unsubscribed from', () => { + // This test sometimes incorrectly fails on CI. + // Reported in https://github.com/angular/angular/issues/37629. + // Investigated in https://github.com/angular/angular/pull/37637. + xit('should unsubscribe from the previous "embed" observable when unsubscribed from', () => { const obs = new ObservableWithSubscriptionSpies(); loadElementsSpy.and.returnValue(obs); @@ -436,7 +439,10 @@ describe('DocViewerComponent', () => { expect(swapViewsSpy).toHaveBeenCalledWith(addTitleAndTocSpy); }); - it('should unsubscribe from the previous "swap" observable when unsubscribed from', () => { + // This test sometimes incorrectly fails on CI. + // Reported in https://github.com/angular/angular/issues/37629. + // Investigated in https://github.com/angular/angular/pull/37637. + xit('should unsubscribe from the previous "swap" observable when unsubscribed from', () => { const obs = new ObservableWithSubscriptionSpies(); swapViewsSpy.and.returnValue(obs);