From 404ec48051793231fd7cc2533be27e4e491202cb Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Sun, 18 Apr 2021 19:15:35 +0300 Subject: [PATCH] fix(docs-infra): fix code inside anchor elements with external URLs (#41694) Previously, due to the `inline-flex` display style of anchor elements with external URLs, `` elements nested inside such anchor elements would cause extra spacing between lines. An occurrence of this can be seen in the [Angular workspace configuration][1] guide. This commit fixes the problem by removing the `inline-flex` display style (allowing anchor elements to fall back to the default `inline` style). For reference, the `inline-flex` style was introduced in commit 7944ee2c30c1f09219e152a4a1b2c5e51dd2c9c4 in order to avoid underlining link icons. This style seems to no longer be necessary (either it was never necessary or the underlying browser bug that made it necessary was fixed). Before: ![code links before][2] After: ![code links after][3] [1]: https://next.angular.io/guide/workspace-config#generation-schematics [2]: https://user-images.githubusercontent.com/8604205/115149753-34589780-a06e-11eb-8d4e-825b5e94282d.png [3]: https://user-images.githubusercontent.com/8604205/115149755-3589c480-a06e-11eb-9b15-825d75c74878.png PR Close #41694 --- aio/src/styles/0-base/_typography.scss | 1 - aio/src/styles/2-modules/_presskit.scss | 1 - 2 files changed, 2 deletions(-) diff --git a/aio/src/styles/0-base/_typography.scss b/aio/src/styles/0-base/_typography.scss index e0d83a57a3..8a2751fff1 100755 --- a/aio/src/styles/0-base/_typography.scss +++ b/aio/src/styles/0-base/_typography.scss @@ -210,7 +210,6 @@ code { > a { &[href^="http:"], &[href^="https:"] { - display: inline-flex; padding-right: calc(1em + 0.25rem); position: relative; diff --git a/aio/src/styles/2-modules/_presskit.scss b/aio/src/styles/2-modules/_presskit.scss index 2ac62639ab..37774aea6e 100644 --- a/aio/src/styles/2-modules/_presskit.scss +++ b/aio/src/styles/2-modules/_presskit.scss @@ -50,7 +50,6 @@ padding: 0; a { - display: inline-flex; padding-right: 3rem; position: relative;