test(ivy): fix or disable failing ivy tests (#26735)

These tests were previously not running on CI so they have always been broken,
or got broken just recently :-(.

test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags

PR Close #26735
This commit is contained in:
Igor Minar 2018-10-25 20:47:28 -07:00 committed by Matias Niemelä
parent 30f319a11f
commit 40bbfbf961
21 changed files with 905 additions and 49 deletions

View File

@ -19,6 +19,7 @@ ng_module(
"//packages:types",
"//packages/common",
"//packages/core",
"@ngdeps//reflect-metadata",
],
)

View File

@ -17,6 +17,7 @@ ng_module(
"//packages:types",
"//packages/common",
"//packages/core",
"@ngdeps//reflect-metadata",
],
)
@ -61,7 +62,6 @@ protractor_web_test(
"//modules/benchmarks/src/tree:perf_lib",
"@ngdeps//node-uuid",
"@ngdeps//protractor",
"@ngdeps//reflect-metadata",
"@ngdeps//yargs",
],
)

View File

@ -15,5 +15,6 @@ ts_library(
"//packages:types",
"//packages/core",
"@ngdeps//@types/node",
"@ngdeps//reflect-metadata",
],
)

View File

@ -2,6 +2,7 @@ load("//packages/bazel:index.bzl", "ng_module")
ng_module(
name = "test_module",
testonly = True,
srcs = glob(["*.ts"]),
compiler = "//packages/bazel/src/ngc-wrapped",
entry_point = "index.ts",
@ -9,6 +10,10 @@ ng_module(
module_name = "some_npm_module",
ng_xi18n = "//packages/bazel/src/ngc-wrapped:xi18n",
node_modules = "@ngdeps//typescript:typescript__typings",
tags = [
"fixme-ivy-aot",
"no-ivy-jit",
],
deps = [
"//packages/core",
"@ngdeps//@types",
@ -19,6 +24,7 @@ load(":extract_flat_module_index.bzl", "extract_flat_module_index")
extract_flat_module_index(
name = "flat_module_index",
testonly = True,
deps = [":test_module"],
)

View File

@ -7,7 +7,10 @@ load("//tools/http-server:http_server.bzl", "http_server")
ng_module(
name = "animation_world",
srcs = ["index.ts"],
tags = ["ivy-only"],
tags = [
"ivy-only",
"no-ivy-jit",
],
type_check = False, # see #26462
deps = [
"//packages/common",
@ -25,7 +28,10 @@ ng_rollup_bundle(
# has an "external" directory for external dependencies.
# This should probably start with "angular/" and let the rule deal with it.
entry_point = "packages/core/test/bundling/animation_world/index.js",
tags = ["ivy-only"],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
":animation_world",
"//packages/core",
@ -39,6 +45,7 @@ js_expected_symbol_test(
tags = [
"ivy-aot",
"ivy-only",
"no-ivy-jit",
],
)
@ -51,4 +58,8 @@ http_server(
":bundle.min.js",
":bundle.min_debug.js",
],
tags = [
"ivy-only",
"no-ivy-jit",
],
)

View File

@ -7,7 +7,10 @@ load("//tools/http-server:http_server.bzl", "http_server")
ng_module(
name = "hello_world",
srcs = ["index.ts"],
tags = ["ivy-only"],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
"//packages/core",
],
@ -22,7 +25,10 @@ ng_rollup_bundle(
# has an "external" directory for external dependencies.
# This should probably start with "angular/" and let the rule deal with it.
entry_point = "packages/core/test/bundling/hello_world/index.js",
tags = ["ivy-only"],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
":hello_world",
"//packages/core",
@ -33,6 +39,10 @@ ts_library(
name = "test_lib",
testonly = True,
srcs = glob(["*_spec.ts"]),
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
"//packages:types",
"//packages/core/testing",
@ -50,6 +60,7 @@ jasmine_node_test(
],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [":test_lib"],
)
@ -61,6 +72,7 @@ js_expected_symbol_test(
tags = [
"ivy-aot",
"ivy-only",
"no-ivy-jit",
],
)
@ -71,4 +83,8 @@ http_server(
":bundle.min.js",
":bundle.min_debug.js",
],
tags = [
"ivy-only",
"no-ivy-jit",
],
)

View File

@ -6,6 +6,7 @@ load("//tools/http-server:http_server.bzl", "http_server")
ivy_ng_module(
name = "hello_world_i18n",
srcs = ["index.ts"],
tags = ["ivy-only"],
deps = [
"//packages/core",
],
@ -20,6 +21,7 @@ ng_rollup_bundle(
# has an "external" directory for external dependencies.
# This should probably start with "angular/" and let the rule deal with it.
entry_point = "packages/core/test/bundling/hello_world_i18n/index.js",
tags = ["ivy-only"],
deps = [
":hello_world_i18n",
"//packages/core",
@ -33,4 +35,5 @@ http_server(
":bundle.min.js",
":bundle.min_debug.js",
],
tags = ["ivy-only"],
)

View File

@ -7,6 +7,10 @@ load("//tools/http-server:http_server.bzl", "http_server")
ng_module(
name = "hello_world",
srcs = ["index.ts"],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
"//packages/core",
"//packages/platform-browser-dynamic",
@ -22,6 +26,10 @@ ng_rollup_bundle(
# has an "external" directory for external dependencies.
# This should probably start with "angular/" and let the rule deal with it.
entry_point = "packages/core/test/bundling/hello_world_r2/index.js",
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
":hello_world",
"//packages/core",
@ -33,6 +41,10 @@ ts_library(
name = "test_lib",
testonly = True,
srcs = glob(["*_spec.ts"]),
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
"//packages:types",
"//packages/core/testing",
@ -48,6 +60,10 @@ jasmine_node_test(
":bundle.min.js.br",
":bundle.min_debug.js",
],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [":test_lib"],
)
@ -55,6 +71,10 @@ js_expected_symbol_test(
name = "symbol_test",
src = ":bundle.min_debug.js",
golden = ":bundle.golden_symbols.json",
tags = [
"ivy-only",
"no-ivy-jit",
],
)
http_server(
@ -64,4 +84,8 @@ http_server(
":bundle.min.js",
":bundle.min_debug.js",
],
tags = [
"ivy-only",
"no-ivy-jit",
],
)

View File

@ -9,6 +9,10 @@ ts_library(
"index.ts",
"usage.ts",
],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
"//packages/core",
],
@ -23,6 +27,10 @@ ng_rollup_bundle(
# has an "external" directory for external dependencies.
# This should probably start with "angular/" and let the rule deal with it.
entry_point = "packages/core/test/bundling/injection/index.js",
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
":injection",
"//packages/core",
@ -33,6 +41,10 @@ ts_library(
name = "test_lib",
testonly = True,
srcs = glob(["*_spec.ts"]),
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
":injection",
"//packages:types",
@ -43,6 +55,10 @@ ts_library(
jasmine_node_test(
name = "test",
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [":test_lib"],
)
@ -50,4 +66,8 @@ js_expected_symbol_test(
name = "symbol_test",
src = ":bundle.min_debug.js",
golden = ":bundle.golden_symbols.json",
tags = [
"ivy-only",
"no-ivy-jit",
],
)

View File

@ -8,7 +8,10 @@ load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
ng_module(
name = "todo",
srcs = ["index.ts"],
tags = ["ivy-only"],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
"//packages/common",
"//packages/core",
@ -25,13 +28,15 @@ ng_rollup_bundle(
# has an "external" directory for external dependencies.
# This should probably start with "angular/" and let the rule deal with it.
entry_point = "packages/core/test/bundling/todo/index.js",
tags = ["ivy-only"],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
":todo",
"//packages/common",
"//packages/core",
"//packages/core/test/bundling/util:reflect_metadata",
"@ngdeps//reflect-metadata",
],
)
@ -39,6 +44,10 @@ ts_library(
name = "test_lib",
testonly = True,
srcs = glob(["*_spec.ts"]),
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
"//packages:types",
"//packages/core",
@ -57,6 +66,7 @@ jasmine_node_test(
],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [":test_lib"],
)
@ -68,6 +78,7 @@ js_expected_symbol_test(
tags = [
"ivy-aot",
"ivy-only",
"no-ivy-jit",
],
)
@ -80,6 +91,10 @@ genrule(
"tslib.js",
],
cmd = "cp $< $@",
tags = [
"ivy-only",
"no-ivy-jit",
],
)
ts_devserver(
@ -92,6 +107,10 @@ ts_devserver(
"todo.css",
"base.css",
],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [":todo"],
)
@ -104,4 +123,8 @@ http_server(
":bundle.min.js.br",
":bundle.min_debug.js",
],
tags = [
"ivy-only",
"no-ivy-jit",
],
)

View File

@ -8,7 +8,10 @@ load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
ng_module(
name = "todo",
srcs = ["index.ts"],
tags = ["ivy-only"],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
"//packages/common",
"//packages/core",
@ -27,7 +30,10 @@ ng_rollup_bundle(
# has an "external" directory for external dependencies.
# This should probably start with "angular/" and let the rule deal with it.
entry_point = "packages/core/test/bundling/todo_r2/index.js",
tags = ["ivy-only"],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
":todo",
"//packages/common",
@ -35,7 +41,6 @@ ng_rollup_bundle(
"//packages/core/test/bundling/util:reflect_metadata",
"//packages/platform-browser",
"//packages/platform-browser-dynamic",
"@ngdeps//reflect-metadata",
],
)
@ -43,6 +48,10 @@ ts_library(
name = "test_lib",
testonly = True,
srcs = glob(["*_spec.ts"]),
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [
"//packages:types",
"//packages/core",
@ -63,6 +72,7 @@ jasmine_node_test(
],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [":test_lib"],
)
@ -74,6 +84,7 @@ js_expected_symbol_test(
tags = [
"ivy-aot",
"ivy-only",
"no-ivy-jit",
],
)
@ -86,6 +97,10 @@ genrule(
"tslib.js",
],
cmd = "cp $< $@",
tags = [
"ivy-only",
"no-ivy-jit",
],
)
ts_devserver(
@ -98,6 +113,10 @@ ts_devserver(
"todo.css",
"base.css",
],
tags = [
"ivy-only",
"no-ivy-jit",
],
deps = [":todo"],
)
@ -110,4 +129,8 @@ http_server(
":bundle.min.js.br",
":bundle.min_debug.js",
],
tags = [
"ivy-only",
"no-ivy-jit",
],
)

View File

@ -12,6 +12,7 @@ ts_library(
":metadata_switch",
],
module_name = "@angular/core/test/bundling/util/src/reflect_metadata",
deps = ["@ngdeps//reflect-metadata"],
)
# See packages/core/BUILD.bazel.

View File

@ -18,7 +18,7 @@ jasmine_node_test(
"angular/packages/core/test/render3/load_domino",
],
tags = [
"ivy-jit",
"ivy-only",
],
deps = [
":ivy_lib",

View File

@ -25,7 +25,6 @@ npm_package(
name = "npm_package",
srcs = ["package.json"],
tags = [
"ivy-jit",
"release-with-framework",
],
deps = [

View File

@ -28,7 +28,6 @@ ng_package(
],
entry_point = "packages/platform-browser-dynamic/index.js",
tags = [
"ivy-jit",
"release-with-framework",
],
deps = [

View File

@ -35,7 +35,6 @@ ng_package(
],
entry_point = "packages/platform-server/index.js",
tags = [
"ivy-jit",
"release-with-framework",
],
deps = [

View File

@ -25,7 +25,6 @@ ng_package(
srcs = ["package.json"],
entry_point = "packages/platform-webworker-dynamic/index.js",
tags = [
"ivy-jit",
"release-with-framework",
],
deps = [":platform-webworker-dynamic"],

View File

@ -49,7 +49,6 @@ ng_package(
],
entry_point = "packages/service-worker/index.js",
tags = [
"ivy-jit",
"release-with-framework",
],
deps = [

View File

@ -210,6 +210,7 @@ def ng_rollup_bundle(deps = [], **kwargs):
"""Default values for ng_rollup_bundle"""
deps = deps + [
"@ngdeps//tslib",
"@ngdeps//reflect-metadata",
]
_ng_rollup_bundle(
deps = deps,

View File

@ -18,6 +18,11 @@ load("//tools/ts-api-guardian:index.bzl", "ts_api_guardian_test")
bundle[0],
bundle[1],
),
# https://github.com/angular/angular/pull/26602 might be enough to fix the fixme-ivy-jit and fixme-ivy-aot issues
tags = [
"fixme-ivy-aot",
"fixme-ivy-jit",
],
) for bundle in [b[:-len(".d.ts")].split("/", 1) for b in glob(
["**/*.d.ts"],
# The API surface of the compiler is currently unstable - all of the important APIs are exposed