From 4c45aa39e466b37b3d9aea7989aad0a5ed87cc06 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Wed, 19 Jun 2019 19:05:54 +0300 Subject: [PATCH] ci: re-enable payload size tracking (#31138) Payload size tracking was temporarily disabled in #31057, due to `CIRCLE_COMPARE_URL` stopping being available. It turned out this was related to turning on the new [Pipelines][1] feature, which was required for testing Windows on CircleCI. Since then, we have turned `Pipelines` off and got `CIRCLE_COMPARE_URL` back (e.g. see [build 362971][2]). According to CircleCI, failing to populate `CIRCLE_COMPARE_URL` with `Pipelines` on is a bug and they are working on fixing it. [1]: https://circleci.com/docs/2.0/build-processing/ [2]: https://circleci.com/gh/angular/angular/362971 Fixes #31121 PR Close #31138 --- scripts/ci/payload-size.sh | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/scripts/ci/payload-size.sh b/scripts/ci/payload-size.sh index b73711d87f..e29f49b737 100644 --- a/scripts/ci/payload-size.sh +++ b/scripts/ci/payload-size.sh @@ -136,17 +136,15 @@ trackPayloadSize() { # Save the file sizes to be retrieved from `payload-size.js`. echo "$(payloadToJson)" > /tmp/current.log - # TODO: Temporarily disabled until we get back `CIRCLE_COMPARE_URL` or another way to get the - # commit range. Re-enable once the issue is resolved. # If this is a non-PR build, upload the data to firebase. - # if [[ "$CI_PULL_REQUEST" == "false" ]]; then - # if [[ $trackChangeType = true ]]; then - # addChangeType $CI_COMMIT_RANGE - # fi - # addTimestamp - # addMessage $CI_COMMIT_RANGE - # uploadData $name - # fi + if [[ "$CI_PULL_REQUEST" == "false" ]]; then + if [[ $trackChangeType = true ]]; then + addChangeType $CI_COMMIT_RANGE + fi + addTimestamp + addMessage $CI_COMMIT_RANGE + uploadData $name + fi # Check the file sizes against the specified limits. if [[ $checkSize = true ]]; then