From 572b54967c969c88c61970650fb857afc1d74f8a Mon Sep 17 00:00:00 2001 From: crisbeto Date: Sun, 28 Apr 2019 23:04:09 +0200 Subject: [PATCH] fix: disable injectable-pipe migration (#30180) Disables the injectable pipe migration until we can decide whether this is the right solution for Ivy. Rolling it out properly will involve a more detailed plan and more changes like updating the styleguide, scaffolding schematics etc. Context for the new `test-migrations.json`: since we use the `migrations.json` both for the real migrations and for tests, it doesn't allow us to disable a schematic, but continue running its tests. This change adds the test-specific file so that we can continue running the `injectable-pipe` tests, even though the schematic itself is disabled. PR Close #30180 --- packages/core/schematics/BUILD.bazel | 1 + packages/core/schematics/migrations.json | 5 - packages/core/schematics/test-migrations.json | 20 ++ packages/core/schematics/test/BUILD.bazel | 2 +- .../test/injectable_pipe_migration_spec.ts | 4 +- .../test/move_document_migration_spec.ts | 4 +- .../static_queries_migration_template_spec.ts | 78 ++--- .../static_queries_migration_usage_spec.ts | 312 +++++++++--------- .../template_var_assignment_migration_spec.ts | 28 +- 9 files changed, 234 insertions(+), 220 deletions(-) create mode 100644 packages/core/schematics/test-migrations.json diff --git a/packages/core/schematics/BUILD.bazel b/packages/core/schematics/BUILD.bazel index 29546e0172..f83cb584a8 100644 --- a/packages/core/schematics/BUILD.bazel +++ b/packages/core/schematics/BUILD.bazel @@ -3,6 +3,7 @@ load("//tools:defaults.bzl", "npm_package") exports_files([ "tsconfig.json", "migrations.json", + "test-migrations.json", ]) npm_package( diff --git a/packages/core/schematics/migrations.json b/packages/core/schematics/migrations.json index 1de62f6a11..6fb3a71b9d 100644 --- a/packages/core/schematics/migrations.json +++ b/packages/core/schematics/migrations.json @@ -14,11 +14,6 @@ "version": "8-beta", "description": "Warns developers if values are assigned to template variables", "factory": "./migrations/template-var-assignment/index" - }, - "migration-v8-injectable-pipe": { - "version": "8-beta", - "description": "Migrates all Pipe classes so that they have an Injectable annotation", - "factory": "./migrations/injectable-pipe/index" } } } diff --git a/packages/core/schematics/test-migrations.json b/packages/core/schematics/test-migrations.json new file mode 100644 index 0000000000..c057a763a4 --- /dev/null +++ b/packages/core/schematics/test-migrations.json @@ -0,0 +1,20 @@ +{ + "schematics": { + "migration-move-document": { + "description": "Migrates DOCUMENT Injection token from platform-browser imports to common import", + "factory": "./migrations/move-document/index" + }, + "migration-static-queries": { + "description": "Migrates ViewChild and ContentChild to explicit query timing", + "factory": "./migrations/static-queries/index" + }, + "migration-template-local-variables": { + "description": "Warns developers if values are assigned to template variables", + "factory": "./migrations/template-var-assignment/index" + }, + "migration-injectable-pipe": { + "description": "Migrates all Pipe classes so that they have an Injectable annotation", + "factory": "./migrations/injectable-pipe/index" + } + } +} diff --git a/packages/core/schematics/test/BUILD.bazel b/packages/core/schematics/test/BUILD.bazel index 8be7f4ebc6..cdb4814bc6 100644 --- a/packages/core/schematics/test/BUILD.bazel +++ b/packages/core/schematics/test/BUILD.bazel @@ -5,7 +5,7 @@ ts_library( testonly = True, srcs = glob(["**/*.ts"]), data = [ - "//packages/core/schematics:migrations.json", + "//packages/core/schematics:test-migrations.json", ], deps = [ "//packages/core/schematics/migrations/injectable-pipe", diff --git a/packages/core/schematics/test/injectable_pipe_migration_spec.ts b/packages/core/schematics/test/injectable_pipe_migration_spec.ts index d70b9f5278..ba73bf49b9 100644 --- a/packages/core/schematics/test/injectable_pipe_migration_spec.ts +++ b/packages/core/schematics/test/injectable_pipe_migration_spec.ts @@ -20,7 +20,7 @@ describe('injectable pipe migration', () => { let previousWorkingDir: string; beforeEach(() => { - runner = new SchematicTestRunner('test', require.resolve('../migrations.json')); + runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json')); host = new TempScopedNodeJsSyncHost(); tree = new UnitTestTree(new HostTree(host)); @@ -123,5 +123,5 @@ describe('injectable pipe migration', () => { host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents)); } - function runMigration() { runner.runSchematic('migration-v8-injectable-pipe', {}, tree); } + function runMigration() { runner.runSchematic('migration-injectable-pipe', {}, tree); } }); diff --git a/packages/core/schematics/test/move_document_migration_spec.ts b/packages/core/schematics/test/move_document_migration_spec.ts index 85f55411ac..2cd3df8ec3 100644 --- a/packages/core/schematics/test/move_document_migration_spec.ts +++ b/packages/core/schematics/test/move_document_migration_spec.ts @@ -20,7 +20,7 @@ describe('move-document migration', () => { let previousWorkingDir: string; beforeEach(() => { - runner = new SchematicTestRunner('test', require.resolve('../migrations.json')); + runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json')); host = new TempScopedNodeJsSyncHost(); tree = new UnitTestTree(new HostTree(host)); @@ -151,5 +151,5 @@ describe('move-document migration', () => { host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents)); } - function runMigration() { runner.runSchematic('migration-v8-move-document', {}, tree); } + function runMigration() { runner.runSchematic('migration-move-document', {}, tree); } }); diff --git a/packages/core/schematics/test/static_queries_migration_template_spec.ts b/packages/core/schematics/test/static_queries_migration_template_spec.ts index 9aab9a5978..5e8ef131f3 100644 --- a/packages/core/schematics/test/static_queries_migration_template_spec.ts +++ b/packages/core/schematics/test/static_queries_migration_template_spec.ts @@ -21,7 +21,7 @@ describe('static-queries migration with template strategy', () => { let warnOutput: string[]; beforeEach(() => { - runner = new SchematicTestRunner('test', require.resolve('../migrations.json')); + runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json')); host = new TempScopedNodeJsSyncHost(); tree = new UnitTestTree(new HostTree(host)); @@ -97,7 +97,7 @@ describe('static-queries migration with template strategy', () => { } async function runMigration() { - await runner.runSchematicAsync('migration-v8-static-queries', {}, tree).toPromise(); + await runner.runSchematicAsync('migration-static-queries', {}, tree).toPromise(); } describe('ViewChild', () => { @@ -105,7 +105,7 @@ describe('static-queries migration with template strategy', () => { it('should detect queries selecting elements through template reference', async() => { writeFile('/index.ts', ` import {Component, NgModule, ViewChild} from '@angular/core'; - + @Component({template: \` @@ -118,7 +118,7 @@ describe('static-queries migration with template strategy', () => { private @ViewChild('myButton') query: any; private @ViewChild('myStaticButton') query2: any; } - + @NgModule({declarations: [MyComp]}) export class MyModule {} `); @@ -134,7 +134,7 @@ describe('static-queries migration with template strategy', () => { it('should detect queries selecting ng-template as static', async() => { writeFile('/index.ts', ` import {Component, NgModule, ViewChild} from '@angular/core'; - + @Component({template: \` My template @@ -143,7 +143,7 @@ describe('static-queries migration with template strategy', () => { export class MyComp { private @ViewChild('myTmpl') query: any; } - + @NgModule({declarations: [MyComp]}) export class MyModule {} `); @@ -157,7 +157,7 @@ describe('static-queries migration with template strategy', () => { it('should detect queries selecting component view providers through string token', async() => { writeFile('/index.ts', ` import {Component, Directive, NgModule, ViewChild} from '@angular/core'; - + @Directive({ selector: '[myDirective]', providers: [ @@ -165,7 +165,7 @@ describe('static-queries migration with template strategy', () => { ] }) export class MyDirective {} - + @Directive({ selector: '[myDirective2]', providers: [ @@ -173,13 +173,13 @@ describe('static-queries migration with template strategy', () => { ] }) export class MyDirective2 {} - + @Component({templateUrl: './my-tmpl.html'}) export class MyComp { private @ViewChild('my-token') query: any; private @ViewChild('my-token-2') query2: any; } - + @NgModule({declarations: [MyComp, MyDirective, MyDirective2]}) export class MyModule {} `); @@ -202,28 +202,28 @@ describe('static-queries migration with template strategy', () => { it('should detect queries selecting component view providers using class token', async() => { writeFile('/index.ts', ` import {Component, Directive, NgModule, ViewChild} from '@angular/core'; - + export class MyService {} export class MyService2 {} - + @Directive({ selector: '[myDirective]', providers: [MyService] }) export class MyDirective {} - + @Directive({ selector: '[myDirective2]', providers: [MyService2] }) export class MyDirective2 {} - + @Component({templateUrl: './my-tmpl.html'}) export class MyComp { private @ViewChild(MyService) query: any; private @ViewChild(MyService2) query2: any; } - + @NgModule({declarations: [MyComp, MyDirective, MyDirective2]}) export class MyModule {} `); @@ -247,7 +247,7 @@ describe('static-queries migration with template strategy', () => { writeFile('/index.ts', ` import {Component, NgModule, ViewChild} from '@angular/core'; import {HomeComponent, HomeComponent2} from './home-comp'; - + @Component({ template: \` @@ -260,20 +260,20 @@ describe('static-queries migration with template strategy', () => { private @ViewChild(HomeComponent) query: any; private @ViewChild(HomeComponent2) query2: any; } - + @NgModule({declarations: [MyComp, HomeComponent, HomeComponent2]}) export class MyModule {} `); writeFile(`/home-comp.ts`, ` import {Component} from '@angular/core'; - + @Component({ selector: 'home-comp', template: 'Home' }) export class HomeComponent {} - + @Component({ selector: 'home-comp2', template: 'Home 2' @@ -294,12 +294,12 @@ describe('static-queries migration with template strategy', () => { writeFile('/index.ts', ` import {Component, NgModule, ViewChild} from '@angular/core'; import {MyLibComponent} from 'my-lib'; - + @Component({templateUrl: './my-tmpl.html'}) export class MyComp { private @ViewChild(MyLibComponent) query: any; } - + @NgModule({declarations: [MyComp, MyLibComponent]}) export class MyModule {} `); @@ -319,12 +319,12 @@ describe('static-queries migration with template strategy', () => { writeFile('/index.ts', ` import {Component, NgModule, ViewChild} from '@angular/core'; import {MyLibComponent} from 'my-lib'; - + @Component({templateUrl: './my-tmpl.html'}) export class MyComp { private @ViewChild(MyLibComponent) query: any; } - + @NgModule({declarations: [MyComp, MyLibComponent]}) export class MyModule {} `); @@ -345,16 +345,16 @@ describe('static-queries migration with template strategy', () => { it('should detect queries within structural directive', async() => { writeFile('/index.ts', ` import {Component, Directive, NgModule, ViewChild} from '@angular/core'; - + @Directive({selector: '[ngIf]'}) export class FakeNgIf {} - + @Component({templateUrl: 'my-tmpl.html'}) export class MyComp { private @ViewChild('myRef') query: any; private @ViewChild('myRef2') query2: any; } - + @NgModule({declarations: [MyComp, FakeNgIf]}) export class MyModule {} `); @@ -375,14 +375,14 @@ describe('static-queries migration with template strategy', () => { it('should detect inherited queries', async() => { writeFile('/index.ts', ` import {Component, NgModule, ViewChild} from '@angular/core'; - + export class BaseClass { @ViewChild('myRef') query: any; } - + @Component({templateUrl: 'my-tmpl.html'}) export class MyComp extends BaseClass {} - + @NgModule({declarations: [MyComp]}) export class MyModule {} `); @@ -400,7 +400,7 @@ describe('static-queries migration with template strategy', () => { it('should add a todo if a query is not declared in any component', async() => { writeFile('/index.ts', ` import {Component, NgModule, ViewChild, SomeToken} from '@angular/core'; - + export class NotAComponent { @ViewChild('myRef', {read: SomeToken}) query: any; } @@ -420,17 +420,17 @@ describe('static-queries migration with template strategy', () => { it('should add a todo if a query is used multiple times with different timing', async() => { writeFile('/index.ts', ` import {Component, NgModule, ViewChild} from '@angular/core'; - + export class BaseClass { @ViewChild('myRef') query: any; } - + @Component({template: '

'}) export class FirstComp extends BaseClass {} - + @Component({template: ''}) export class SecondComp extends BaseClass {} - + @NgModule({declarations: [FirstComp, SecondComp]}) export class MyModule {} `); @@ -448,12 +448,12 @@ describe('static-queries migration with template strategy', () => { it('should gracefully exit migration if queries could not be analyzed', async() => { writeFile('/index.ts', ` import {Component, ViewChild} from '@angular/core'; - + @Component({template: '

'}) export class MyComp { @ViewChild('myRef') query: any; } - + // **NOTE**: Analysis will fail as there is no "NgModule" that declares the component. `); @@ -533,7 +533,7 @@ describe('static-queries migration with template strategy', () => { writeFile('/src/test.ts', ` import {ViewChild} from '@angular/core'; import {AppComponent} from './app.component'; - + @Component({template: 'Test'}) class MyTestComponent { @ViewChild('test') query: any; @@ -542,7 +542,7 @@ describe('static-queries migration with template strategy', () => { writeFile('/src/app.component.ts', ` import {Component, ViewChild} from '@angular/core'; - + @Component({template: ''}) export class AppComponent { @ViewChild('test') query: any; @@ -552,7 +552,7 @@ describe('static-queries migration with template strategy', () => { writeFile('/src/app.module.ts', ` import {NgModule} from '@angular/core'; import {AppComponent} from './app.component'; - + @NgModule({declarations: [AppComponent]}) export class MyModule {} `); diff --git a/packages/core/schematics/test/static_queries_migration_usage_spec.ts b/packages/core/schematics/test/static_queries_migration_usage_spec.ts index f0ece7e9da..afa3f2f801 100644 --- a/packages/core/schematics/test/static_queries_migration_usage_spec.ts +++ b/packages/core/schematics/test/static_queries_migration_usage_spec.ts @@ -26,7 +26,7 @@ describe('static-queries migration with usage strategy', () => { afterAll(() => process.env['NG_STATIC_QUERY_USAGE_STRATEGY'] = ''); beforeEach(() => { - runner = new SchematicTestRunner('test', require.resolve('../migrations.json')); + runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json')); host = new TempScopedNodeJsSyncHost(); tree = new UnitTestTree(new HostTree(host)); @@ -58,11 +58,11 @@ describe('static-queries migration with usage strategy', () => { it('should mark view queries used in "ngAfterContentInit" as static', async() => { writeFile('/index.ts', ` import {Component, ViewChild} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @ViewChild('test') query: any; - + ngAfterContentInit() { this.query.classList.add('test'); } @@ -78,11 +78,11 @@ describe('static-queries migration with usage strategy', () => { it('should mark view queries used in "ngAfterContentChecked" as static', async() => { writeFile('/index.ts', ` import {Component, ViewChild} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @ViewChild('test') query: any; - + ngAfterContentChecked() { this.query.classList.add('test'); } @@ -102,11 +102,11 @@ describe('static-queries migration with usage strategy', () => { it('should not mark content queries used in "ngAfterContentInit" as static', async() => { writeFile('/index.ts', ` import {Component, ContentChild} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @ContentChild('test') query: any; - + ngAfterContentInit() { this.query.classList.add('test'); } @@ -122,11 +122,11 @@ describe('static-queries migration with usage strategy', () => { it('should not mark content queries used in "ngAfterContentChecked" as static', async() => { writeFile('/index.ts', ` import {Component, ContentChild} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @ContentChild('test') query: any; - + ngAfterContentChecked() { this.query.classList.add('test'); } @@ -145,19 +145,19 @@ describe('static-queries migration with usage strategy', () => { } async function runMigration() { - await runner.runSchematicAsync('migration-v8-static-queries', {}, tree).toPromise(); + await runner.runSchematicAsync('migration-static-queries', {}, tree).toPromise(); } function createQueryTests(queryType: 'ViewChild' | 'ContentChild') { it('should mark queries as dynamic', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') unused: any; @${queryType}('dynamic') dynamic: any; - + onClick() { this.dynamicQuery.classList.add('test'); } @@ -175,13 +175,13 @@ describe('static-queries migration with usage strategy', () => { it('should mark queries used in "ngOnChanges" as static', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + ngOnChanges() { - this.query.classList.add('test'); + this.query.classList.add('test'); } } `); @@ -195,13 +195,13 @@ describe('static-queries migration with usage strategy', () => { it('should mark queries used in "ngOnInit" as static', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + ngOnInit() { - this.query.classList.add('test'); + this.query.classList.add('test'); } } `); @@ -215,13 +215,13 @@ describe('static-queries migration with usage strategy', () => { it('should mark queries used in "ngDoCheck" as static', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + ngDoCheck() { - this.query.classList.add('test'); + this.query.classList.add('test'); } } `); @@ -235,11 +235,11 @@ describe('static-queries migration with usage strategy', () => { it('should keep existing query options when updating timing', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test', { /* test */ read: null }) query: any; - + ngOnInit() { this.query.classList.add('test'); } @@ -255,7 +255,7 @@ describe('static-queries migration with usage strategy', () => { it('should not overwrite existing explicit query timing', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test', {static: /* untouched */ someVal}) query: any; @@ -271,26 +271,26 @@ describe('static-queries migration with usage strategy', () => { it('should detect queries used in deep method chain', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { // We intentionally add this comma for the second parameter in order // to ensure that the migration does not incorrectly create an invalid // decorator call with three parameters. e.g. "ViewQuery('test', {...}, )" @${queryType}('test', ) query: any; - + ngOnInit() { this.a(); } - + a() { this.b(); } - + b() { this.c(); } - + c() { console.log(this.query); } @@ -306,16 +306,16 @@ describe('static-queries migration with usage strategy', () => { it('should properly exit if recursive function is analyzed', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + ngOnInit() { this.recursive(); } - - recursive() { + + recursive() { this.recursive(); } } @@ -330,27 +330,27 @@ describe('static-queries migration with usage strategy', () => { it('should detect queries used in newly instantiated classes', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; @${queryType}('test') query2: any; - + ngOnInit() { new A(this); - + new class Inline { constructor(private ctx: MyComp) { this.a(); } - + a() { this.ctx.query2.useStatically(); } }(this); } } - + export class A { constructor(ctx: MyComp) { ctx.query.test(); @@ -369,16 +369,16 @@ describe('static-queries migration with usage strategy', () => { it('should detect queries used in parenthesized new expressions', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + ngOnInit() { new ((A))(this); } } - + export class A { constructor(ctx: MyComp) { ctx.query.test(); @@ -395,11 +395,11 @@ describe('static-queries migration with usage strategy', () => { it('should detect queries in lifecycle hook with string literal name', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + 'ngOnInit'() { this.query.test(); } @@ -415,19 +415,19 @@ describe('static-queries migration with usage strategy', () => { it('should detect static queries within nested inheritance', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; } - + export class A extends MyComp {} export class B extends A { - + ngOnInit() { this.query.testFn(); } - + } `); @@ -440,11 +440,11 @@ describe('static-queries migration with usage strategy', () => { it('should detect static queries used within input setters', async() => { writeFile('/index.ts', ` import {Component, Input, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + @Input() get myVal() { return null; } set myVal(newVal: any) { @@ -462,14 +462,14 @@ describe('static-queries migration with usage strategy', () => { it('should detect inputs defined in metadata', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({ template: '', inputs: ["myVal"], }) export class MyComp { @${queryType}('test') query: any; - + // We don't use the input decorator here as we want to verify // that it properly detects the input through the component metadata. get myVal() { return null; } @@ -488,14 +488,14 @@ describe('static-queries migration with usage strategy', () => { it('should detect aliased inputs declared in metadata', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({ template: '', inputs: ['prop: publicName'], }) export class MyComp { @${queryType}('test') query: any; - + set prop(val: any) { this.query.test(); } @@ -511,11 +511,11 @@ describe('static-queries migration with usage strategy', () => { it('should not mark query as static if query is used in non-input setter', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + set myProperty(val: any) { this.query.test(); } @@ -531,13 +531,13 @@ describe('static-queries migration with usage strategy', () => { it('should detect input decorator on setter', async() => { writeFile('/index.ts', ` import {Input, Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + get myProperty() { return null; } - + // Usually the decorator is set on the get accessor, but it's also possible // to declare the input on the setter. This ensures that it is handled properly. @Input() @@ -556,7 +556,7 @@ describe('static-queries migration with usage strategy', () => { it('should detect setter inputs in derived classes', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({ template: '', inputs: ['childSetter'], @@ -564,7 +564,7 @@ describe('static-queries migration with usage strategy', () => { export class MyComp { protected @${queryType}('test') query: any; } - + export class B extends MyComp { set childSetter(newVal: any) { this.query.test(); @@ -581,7 +581,7 @@ describe('static-queries migration with usage strategy', () => { it('should properly detect static query in external derived class', async() => { writeFile('/src/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; @@ -590,7 +590,7 @@ describe('static-queries migration with usage strategy', () => { writeFile('/src/external.ts', ` import {MyComp} from './index'; - + export class ExternalComp extends MyComp { ngOnInit() { this.query.test(); @@ -614,30 +614,30 @@ describe('static-queries migration with usage strategy', () => { it('should not mark queries used in promises as static', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; private @${queryType}('test') query2: any; - + ngOnInit() { const a = Promise.resolve(); - + Promise.resolve().then(() => { this.query.doSomething(); }); - + Promise.reject().catch(() => { this.query.doSomething(); }); - + a.then(() => {}).then(() => { this.query.doSomething(); }); - + Promise.resolve().then(this.createPromiseCb()); } - + createPromiseCb() { this.query2.doSomething(); return () => { /* empty callback */} @@ -656,19 +656,19 @@ describe('static-queries migration with usage strategy', () => { it('should handle function callbacks which statically access queries', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - - ngOnInit() { + + ngOnInit() { this.callSync(() => this.query.doSomething()); } - + callSync(cb: Function) { this.callSync2(cb); } - + callSync2(cb: Function) { cb(); } @@ -686,12 +686,12 @@ describe('static-queries migration with usage strategy', () => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; import {External} from './external'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - - ngOnInit() { + + ngOnInit() { new External(() => this.query.doSomething()); } } @@ -700,7 +700,7 @@ describe('static-queries migration with usage strategy', () => { writeFile('/external.ts', ` export class External { constructor(cb: () => void) { - // Add extra parentheses to ensure that expression is unwrapped. + // Add extra parentheses to ensure that expression is unwrapped. ((cb))(); } } @@ -715,21 +715,21 @@ describe('static-queries migration with usage strategy', () => { it('should handle nested functions with arguments from parent closure', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - - ngOnInit() { + + ngOnInit() { this.callSync(() => this.query.doSomething()); } - + callSync(cb: Function) { function callSyncNested() { // The "cb" identifier comes from the "callSync" function. cb(); } - + callSyncNested(); } } @@ -744,22 +744,22 @@ describe('static-queries migration with usage strategy', () => { it('should not mark queries used in setTimeout as static', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; private @${queryType}('test') query2: any; private @${queryType}('test') query3: any; - + ngOnInit() { setTimeout(function() { this.query.doSomething(); }); - + setTimeout(createCallback(this)); } } - + function createCallback(instance: MyComp) { instance.query2.doSomething(); return () => instance.query3.doSomething(); @@ -779,13 +779,13 @@ describe('static-queries migration with usage strategy', () => { it('should not mark queries used in "addEventListener" as static', async() => { writeFile('/index.ts', ` import {Component, ElementRef, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - + constructor(private elementRef: ElementRef) {} - + ngOnInit() { this.elementRef.addEventListener(() => { this.query.classList.add('test'); @@ -803,13 +803,13 @@ describe('static-queries migration with usage strategy', () => { it('should not mark queries used in "requestAnimationFrame" as static', async() => { writeFile('/index.ts', ` import {Component, ElementRef, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - + constructor(private elementRef: ElementRef) {} - + ngOnInit() { requestAnimationFrame(() => { this.query.classList.add('test'); @@ -827,17 +827,17 @@ describe('static-queries migration with usage strategy', () => { it('should mark queries used in immediately-invoked function expression as static', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; private @${queryType}('test') query2: any; - + ngOnInit() { (() => { this.query.usedStatically(); })(); - + (function(ctx) { ctx.query2.useStatically(); })(this); @@ -857,11 +857,11 @@ describe('static-queries migration with usage strategy', () => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; import {externalFn} from './external'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - + ngOnInit() { externalFn(this); } @@ -870,7 +870,7 @@ describe('static-queries migration with usage strategy', () => { writeFile('/external.ts', ` import {MyComp} from './index'; - + export function externalFn(ctx: MyComp) { ctx.query.usedStatically(); } @@ -885,15 +885,15 @@ describe('static-queries migration with usage strategy', () => { it('should detect static queries used through getter property access', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - + get myProp() { return this.query.myValue; } - + ngOnInit() { this.myProp.test(); } @@ -910,17 +910,17 @@ describe('static-queries migration with usage strategy', () => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; import {External} from './external'; - + @Component({template: ''}) export class MyComp { @${queryType}('test') query: any; - + private external = new External(this); - + get myProp() { return this.query.myValue; } - + ngOnInit() { console.log(this.external.query); } @@ -929,10 +929,10 @@ describe('static-queries migration with usage strategy', () => { writeFile('/external.ts', ` import {MyComp} from './index'; - + export class External { constructor(private comp: MyComp) {} - + set query() { /** noop */ } get query() { return this.comp.query; } } @@ -947,16 +947,16 @@ describe('static-queries migration with usage strategy', () => { it('should not mark queries as static if a value is assigned to accessor property', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - + set myProp(value: any) { /* noop */} get myProp() { return this.query.myValue; } - + ngOnInit() { this.myProp = true; } @@ -972,16 +972,16 @@ describe('static-queries migration with usage strategy', () => { it('should mark queries as static if non-input setter uses query', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - + get myProp() { return null; } set myProp(value: any) { this.query.doSomething(); } - + ngOnInit() { this.myProp = 'newValue'; } @@ -997,17 +997,17 @@ describe('static-queries migration with usage strategy', () => { it('should check setter and getter when using compound assignment', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; private @${queryType}('test') query2: any; - + get myProp() { return this.query2 } set myProp(value: any) { this.query.doSomething(); } - + ngOnInit() { this.myProp *= 5; } @@ -1025,14 +1025,14 @@ describe('static-queries migration with usage strategy', () => { it('should check getters when using comparison operator in binary expression', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; - + get myProp() { return this.query } set myProp(value: any) { /* noop */ } - + ngOnInit() { if (this.myProp === 3) { // noop @@ -1050,29 +1050,29 @@ describe('static-queries migration with usage strategy', () => { it('should check derived abstract class methods', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + export abstract class RootBaseClass { abstract getQuery(): any; - + ngOnInit() { this.getQuery().doSomething(); } } - + export abstract class BaseClass extends RootBaseClass { abstract getQuery2(): any; - + getQuery() { this.getQuery2(); } } - + @Component({template: ''}) export class Subclass extends BaseClass { @${queryType}('test') query: any; - + getQuery2(): any { - return this.query; + return this.query; } } `); @@ -1086,25 +1086,25 @@ describe('static-queries migration with usage strategy', () => { it('should detect queries accessed through deep abstract class method', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + export abstract class RootBaseClass { abstract getQuery(): any; - + ngOnInit() { this.getQuery().doSomething(); } } - + export abstract class BaseClass extends RootBaseClass { /* additional layer of indirection */ } - + @Component({template: ''}) export class Subclass extends BaseClass { @${queryType}('test') query: any; - + getQuery(): any { - return this.query; + return this.query; } } `); @@ -1118,19 +1118,19 @@ describe('static-queries migration with usage strategy', () => { it('should detect queries accessed through abstract property getter', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + export abstract class BaseClass { abstract myQuery: any; - + ngOnInit() { this.myQuery.doSomething(); } } - + @Component({template: ''}) export class Subclass extends BaseClass { @${queryType}('test') query: any; - + get myQuery() { return this.query; } } `); @@ -1144,19 +1144,19 @@ describe('static-queries migration with usage strategy', () => { it('should detect queries accessed through abstract property setter', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + export abstract class BaseClass { abstract myQuery: any; - + ngOnInit() { this.myQuery = "trigger"; } } - + @Component({template: ''}) export class Subclass extends BaseClass { @${queryType}('test') query: any; - + set myQuery(val: any) { this.query.doSomething() } get myQuery() { /* noop */ } } @@ -1171,27 +1171,27 @@ describe('static-queries migration with usage strategy', () => { it('should detect query usage in abstract class methods accessing inherited query', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + export abstract class RootBaseClass { abstract getQuery(): any; - + ngOnInit() { this.getQuery().doSomething(); } } - + export abstract class BaseClass extends RootBaseClass { @${queryType}('test') query: any; abstract getQuery2(): any; - + getQuery() { this.getQuery2(); } } - + @Component({template: ''}) export class Subclass extends BaseClass { - + getQuery2(): any { return this.query; } @@ -1207,7 +1207,7 @@ describe('static-queries migration with usage strategy', () => { it('should detect query usage within component template', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({templateUrl: 'my-template.html'}) export class MyComponent { @${queryType}('test') query: any; @@ -1228,7 +1228,7 @@ describe('static-queries migration with usage strategy', () => { it('should detect query usage with nested property read within component template', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({templateUrl: 'my-template.html'}) export class MyComponent { @${queryType}('test') query: any; @@ -1250,7 +1250,7 @@ describe('static-queries migration with usage strategy', () => { async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({templateUrl: 'my-template.html'}) export class MyComponent { @${queryType}('test') query: any; @@ -1274,7 +1274,7 @@ describe('static-queries migration with usage strategy', () => { async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({templateUrl: 'my-template.html'}) export class MyComponent { myObject: {someProp: any}; @@ -1299,7 +1299,7 @@ describe('static-queries migration with usage strategy', () => { it('should ignore queries accessed within element', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({templateUrl: 'my-template.html'}) export class MyComponent { @${queryType}('test') query: any; @@ -1308,7 +1308,7 @@ describe('static-queries migration with usage strategy', () => { writeFile(`/my-template.html`, ` - + @@ -1323,11 +1323,11 @@ describe('static-queries migration with usage strategy', () => { it('should detect inherited queries used in templates', async() => { writeFile('/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + export class ParentClass { @${queryType}('test') query: any; } - + @Component({templateUrl: 'my-template.html'}) export class MyComponent extends ParentClass {} `); @@ -1346,7 +1346,7 @@ describe('static-queries migration with usage strategy', () => { it('should properly handle multiple tsconfig files', async() => { writeFile('/src/index.ts', ` import {Component, ${queryType}} from '@angular/core'; - + @Component({template: ''}) export class MyComp { private @${queryType}('test') query: any; diff --git a/packages/core/schematics/test/template_var_assignment_migration_spec.ts b/packages/core/schematics/test/template_var_assignment_migration_spec.ts index 4c4d210192..5797cfdaaf 100644 --- a/packages/core/schematics/test/template_var_assignment_migration_spec.ts +++ b/packages/core/schematics/test/template_var_assignment_migration_spec.ts @@ -21,7 +21,7 @@ describe('template variable assignment migration', () => { let warnOutput: string[]; beforeEach(() => { - runner = new SchematicTestRunner('test', require.resolve('../migrations.json')); + runner = new SchematicTestRunner('test', require.resolve('../test-migrations.json')); host = new TempScopedNodeJsSyncHost(); tree = new UnitTestTree(new HostTree(host)); @@ -58,14 +58,12 @@ describe('template variable assignment migration', () => { host.sync.write(normalize(filePath), virtualFs.stringToFileBuffer(contents)); } - function runMigration() { - runner.runSchematic('migration-v8-template-local-variables', {}, tree); - } + function runMigration() { runner.runSchematic('migration-template-local-variables', {}, tree); } it('should warn for two-way data binding variable assignment', () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ template: '', }) @@ -81,7 +79,7 @@ describe('template variable assignment migration', () => { it('should warn for two-way data binding assigning to "as" variable', () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ templateUrl: './tmpl.html', }) @@ -103,7 +101,7 @@ describe('template variable assignment migration', () => { it('should warn for bound event assignments to "as" variable', () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ templateUrl: './sub_dir/tmpl.html', }) @@ -127,7 +125,7 @@ describe('template variable assignment migration', () => { it('should warn for bound event assignments to template "let" variables', () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ templateUrl: './sub_dir/tmpl.html', }) @@ -151,7 +149,7 @@ describe('template variable assignment migration', () => { it('should not warn for bound event assignments to component property', () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ templateUrl: './sub_dir/tmpl.html', }) @@ -168,7 +166,7 @@ describe('template variable assignment migration', () => { it('should not warn for bound event assignments to template variable object property', () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ templateUrl: './sub_dir/tmpl.html', }) @@ -188,7 +186,7 @@ describe('template variable assignment migration', () => { () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ templateUrl: './sub_dir/tmpl.html', }) @@ -213,7 +211,7 @@ describe('template variable assignment migration', () => { it('should not warn for property writes with template variable name but different scope', () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ templateUrl: './sub_dir/tmpl.html', }) @@ -236,7 +234,7 @@ describe('template variable assignment migration', () => { it('should not throw an error if a detected template fails parsing', () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ templateUrl: './sub_dir/tmpl.html', }) @@ -253,12 +251,12 @@ describe('template variable assignment migration', () => { it('should be able to report multiple templates within the same source file', () => { writeFile('/index.ts', ` import {Component} from '@angular/core'; - + @Component({ template: '', }) export class MyComp {} - + @Component({ template: '', })