iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: Do not generate *.umd.min.js for language service (#31917) 

`language-service.umd.min.js` takes a long time to build (because of
running terser), but it is not used at all.
See https://unpkg.com/browse/@angular/language-service@8.1.3/package.json
where 'main' points to the unminified bundle.

PR Close #31917
This commit is contained in:
Keen Yee Liau 2019-07-30 14:32:16 -07:00 committed by Andrew Kushnir
parent 8e7a0d4ff9
commit 584b42343f
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/language-service/bundles/rollup.bzl
View File

@ -14,7 +14,7 @@ load(
"ROLLUP_ATTRS", "ROLLUP_ATTRS",
"ROLLUP_DEPS_ASPECTS", "ROLLUP_DEPS_ASPECTS",
"run_rollup", "run_rollup",
"run_terser", # "run_terser",
"write_rollup_config", "write_rollup_config",
) )
load("//packages/bazel/src:esm5.bzl", "esm5_outputs_aspect", "esm5_root_dir", "flatten_esm5") load("//packages/bazel/src:esm5.bzl", "esm5_outputs_aspect", "esm5_root_dir", "flatten_esm5")
@ -25,7 +25,8 @@ load("//packages/bazel/src:esm5.bzl", "esm5_outputs_aspect", "esm5_root_dir", "f
# have the path hardcoded in them. # have the path hardcoded in them.
_ROLLUP_OUTPUTS = { _ROLLUP_OUTPUTS = {
"build_umd": "%{name}.umd.js", "build_umd": "%{name}.umd.js",
"build_umd_min": "%{name}.umd.min.js", # min bundle is not used at the moment. Disable to speed up build
# "build_umd_min": "%{name}.umd.min.js",
} }
DEPS_ASPECTS = [esm5_outputs_aspect] DEPS_ASPECTS = [esm5_outputs_aspect]
@ -41,8 +42,15 @@ def _ls_rollup_bundle(ctx):
output_format = "amd", output_format = "amd",
) )
run_rollup(ctx, esm5_sources, rollup_config, ctx.outputs.build_umd) run_rollup(ctx, esm5_sources, rollup_config, ctx.outputs.build_umd)
source_map = run_terser(ctx, ctx.outputs.build_umd, ctx.outputs.build_umd_min)
return DefaultInfo(files = depset([ctx.outputs.build_umd, ctx.outputs.build_umd_min, source_map])) # source_map = run_terser(ctx, ctx.outputs.build_umd, ctx.outputs.build_umd_min)
return DefaultInfo(
files = depset([
ctx.outputs.build_umd,
# ctx.outputs.build_umd_min,
# source_map,
]),
)
ls_rollup_bundle = rule( ls_rollup_bundle = rule(
implementation = _ls_rollup_bundle, implementation = _ls_rollup_bundle,