fix(toh-5): Fixed issues in tutorial flow

The HeroDetailComponent should be in the module declarations from the beginning.
InMemoryWebApiModule.forRoot(InMemoryDataService) and correct text
This commit is contained in:
Brandon Roberts 2016-08-17 20:28:22 -05:00 committed by Ward Bell
parent a35fcb4dfd
commit 5c5c9ca16c
7 changed files with 53 additions and 59 deletions

View File

@ -35,7 +35,7 @@
"@angular/router": "3.0.0-rc.1", "@angular/router": "3.0.0-rc.1",
"@angular/router-deprecated": "2.0.0-rc.2", "@angular/router-deprecated": "2.0.0-rc.2",
"@angular/upgrade": "2.0.0-rc.5", "@angular/upgrade": "2.0.0-rc.5",
"angular2-in-memory-web-api": "0.0.15", "angular2-in-memory-web-api": "0.0.17",
"bootstrap": "^3.3.6", "bootstrap": "^3.3.6",
"core-js": "^2.4.0", "core-js": "^2.4.0",
"reflect-metadata": "^0.1.3", "reflect-metadata": "^0.1.3",

View File

@ -3,11 +3,10 @@ import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser'; import { BrowserModule } from '@angular/platform-browser';
import { FormsModule } from '@angular/forms'; import { FormsModule } from '@angular/forms';
import { AppComponent } from './app.component'; import { AppComponent } from './app.component';
import { HeroDetailComponent } from './hero-detail.component';
import { HeroesComponent } from './heroes.component'; import { HeroesComponent } from './heroes.component';
import { HeroService } from './hero.service';
import { HeroService } from './hero.service';
@NgModule({ @NgModule({
imports: [ imports: [
@ -16,6 +15,7 @@ import { HeroService } from './hero.service';
], ],
declarations: [ declarations: [
AppComponent, AppComponent,
HeroDetailComponent,
HeroesComponent HeroesComponent
], ],
providers: [ providers: [

View File

@ -4,16 +4,13 @@ import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser'; import { BrowserModule } from '@angular/platform-browser';
import { FormsModule } from '@angular/forms'; import { FormsModule } from '@angular/forms';
import { AppComponent } from './app.component'; import { AppComponent } from './app.component';
// #docregion routing
import { routing } from './app.routing';
// #enddocregion routing
import { HeroesComponent } from './heroes.component';
import { DashboardComponent } from './dashboard.component'; import { DashboardComponent } from './dashboard.component';
import { HeroDetailComponent } from './hero-detail.component'; import { HeroDetailComponent } from './hero-detail.component';
import { HeroesComponent } from './heroes.component';
import { HeroService } from './hero.service'; import { HeroService } from './hero.service';
// #docregion routing
import { routing } from './app.routing';
// #docregion routing // #docregion routing
@NgModule({ @NgModule({
@ -26,11 +23,9 @@ import { HeroService } from './hero.service';
// #docregion dashboard, hero-detail // #docregion dashboard, hero-detail
declarations: [ declarations: [
AppComponent, AppComponent,
HeroesComponent,
DashboardComponent, DashboardComponent,
// #enddocregion dashboard HeroDetailComponent,
HeroDetailComponent HeroesComponent
// #docregion dashboard
], ],
// #enddocregion dashboard, hero-detail // #enddocregion dashboard, hero-detail
providers: [ providers: [

View File

@ -1,55 +1,51 @@
// #docplaster // #docplaster
// #docregion , v1, v2 // #docregion , v1, v2
import { NgModule } from '@angular/core'; import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser'; import { BrowserModule } from '@angular/platform-browser';
import { FormsModule } from '@angular/forms'; import { FormsModule } from '@angular/forms';
import { HttpModule } from '@angular/http'; import { HttpModule } from '@angular/http';
// #enddocregion v1 // #enddocregion v1
// Imports for loading & configuring the in-memory web api // Imports for loading & configuring the in-memory web api
import { XHRBackend } from '@angular/http'; import { InMemoryWebApiModule } from 'angular2-in-memory-web-api';
import { InMemoryDataService } from './in-memory-data.service';
import { InMemoryBackendService, SEED_DATA } from 'angular2-in-memory-web-api';
import { InMemoryDataService } from './in-memory-data.service';
// #docregion v1 // #docregion v1
import { AppComponent } from './app.component'; import { AppComponent } from './app.component';
import { routing } from './app.routing';
import { HeroesComponent } from './heroes.component';
import { DashboardComponent } from './dashboard.component'; import { DashboardComponent } from './dashboard.component';
import { HeroesComponent } from './heroes.component';
import { HeroDetailComponent } from './hero-detail.component'; import { HeroDetailComponent } from './hero-detail.component';
import { HeroService } from './hero.service'; import { HeroService } from './hero.service';
// #enddocregion v1, v2 // #enddocregion v1, v2
// #docregion search
import { HeroSearchComponent } from './hero-search.component'; import { HeroSearchComponent } from './hero-search.component';
// #docregion v1, v2 // #docregion v1, v2
import { routing } from './app.routing';
// #enddocregion search
@NgModule({ @NgModule({
imports: [ imports: [
BrowserModule, BrowserModule,
FormsModule, FormsModule,
routing, HttpModule,
HttpModule // #enddocregion v1
// #docregion in-mem-web-api
InMemoryWebApiModule.forRoot(InMemoryDataService),
// #enddocregion in-mem-web-api
// #docregion v1
routing
], ],
// #docregion search // #docregion search
declarations: [ declarations: [
AppComponent, AppComponent,
HeroesComponent,
DashboardComponent, DashboardComponent,
HeroDetailComponent, HeroDetailComponent,
// #enddocregion v1, v2 HeroesComponent,
// #enddocregion v1, v2
HeroSearchComponent HeroSearchComponent
// #docregion v1, v2 // #docregion v1, v2
], ],
// #enddocregion search // #enddocregion search
providers: [ providers: [
HeroService, HeroService,
// #enddocregion v1
{ provide: XHRBackend, useClass: InMemoryBackendService }, // in-mem server
{ provide: SEED_DATA, useClass: InMemoryDataService } // in-mem server data
// #docregion v1
], ],
bootstrap: [ AppComponent ] bootstrap: [ AppComponent ]
}) })

View File

@ -1,5 +1,6 @@
// #docregion , init // #docregion , init
export class InMemoryDataService { import { InMemoryDbService } from 'angular2-in-memory-web-api';
export class InMemoryDataService implements InMemoryDbService {
createDb() { createDb() {
let heroes = [ let heroes = [
{id: 11, name: 'Mr. Nice'}, {id: 11, name: 'Mr. Nice'},

View File

@ -479,15 +479,10 @@ code-example(format='').
The colon (:) in the path indicates that `:id` is a placeholder to be filled with a specific hero `id` The colon (:) in the path indicates that `:id` is a placeholder to be filled with a specific hero `id`
when navigating to the `HeroDetailComponent`. when navigating to the `HeroDetailComponent`.
.l-sub-section +ifDocsFor('dart')
:marked .l-sub-section
Remember to import the hero detail component before creating this route. :marked
Remember to import the hero detail component before creating this route.
+ifDocsFor('ts|js')
:marked
Add the `HeroDetailComponent` to our root NgModule's `declarations`.
+makeExcerpt('app/app.module.ts', 'hero-detail')
:marked :marked
We're finished with the application routes. We're finished with the application routes.

View File

@ -59,7 +59,7 @@ block http-providers
So we register them in the `imports` array of `app.module.ts` where we So we register them in the `imports` array of `app.module.ts` where we
bootstrap the application and its root `AppComponent`. bootstrap the application and its root `AppComponent`.
+makeExcerpt('app/app.module.ts (v1)') +makeExample('app/app.module.ts', 'v1','app/app.module.ts (v1)')
:marked :marked
Notice that we supply `!{_HttpModule}` as part of the *imports* !{_array} in root NgModule `AppModule`. Notice that we supply `!{_HttpModule}` as part of the *imports* !{_array} in root NgModule `AppModule`.
@ -88,10 +88,16 @@ block http-providers
block backend block backend
:marked :marked
We're replacing the default `XHRBackend`, the service that talks to the remote server, We're importing the `InMemoryWebApiModule` and adding it to the module `imports`.
with the in-memory web API service after priming it as follows: The `InMemoryWebApiModule` replaces the default `Http` client backend —
the supporting service that talks to the remote server —
with an _in-memory web API alternative service_.
+makeExcerpt(_appModuleTsVsMainTs, 'in-mem-web-api', '')
:marked
The `forRoot` configuration method takes an `InMemoryDataService` class
that will prime the in-memory database as follows:
+makeExample('app/in-memory-data.service.ts', 'init') +makeExample('app/in-memory-data.service.ts', 'init')(format='.')
p This file replaces the #[code #[+adjExPath('mock-heroes.ts')]] which is now safe to delete. p This file replaces the #[code #[+adjExPath('mock-heroes.ts')]] which is now safe to delete.
@ -500,24 +506,25 @@ block observable-transformers
We take a different approach in this example. We take a different approach in this example.
We combine all of the RxJS `Observable` extensions that _our entire app_ requires into a single RxJS imports file. We combine all of the RxJS `Observable` extensions that _our entire app_ requires into a single RxJS imports file.
+makeExample('app/rxjs-extensions.ts') +makeExample('app/rxjs-extensions.ts')(format='.')
:marked :marked
We load them all at once by importing `rxjs-extensions` in `AppComponent`. We load them all at once by importing `rxjs-extensions` in `AppComponent`.
+makeExcerpt('app/app.component.ts', 'rxjs-extensions') +makeExcerpt('app/app.component.ts', 'rxjs-extensions')(format='.')
:marked :marked
### Add the search component to the dashboard ### Add the search component to the dashboard
We add the hero search HTML element to the bottom of the `DashboardComponent` template. We add the hero search HTML element to the bottom of the `DashboardComponent` template.
+makeExample('app/dashboard.component.html') +makeExample('app/dashboard.component.html')(format='.')
- var _declarations = _docsFor == 'dart' ? 'directives' : 'declarations' - var _declarations = _docsFor == 'dart' ? 'directives' : 'declarations'
- var declFile = _docsFor == 'dart' ? 'app/dashboard.component.ts' : 'app/app.module.ts' - var declFile = _docsFor == 'dart' ? 'app/dashboard.component.ts' : 'app/app.module.ts'
:marked :marked
And finally, we import the `HeroSearchComponent` and add it to the `!{_declarations}` !{_array}: And finally, we import the `HeroSearchComponent` from `'./hero-search.component.ts'`
and add it to the `!{_declarations}` !{_array}:
+makeExcerpt(declFile, 'search') +makeExcerpt(declFile, 'search')