From 60a8888b4fbcfb6cd4ee036d7c97481e19abf8be Mon Sep 17 00:00:00 2001
From: Filipe Silva <filipematossilva@gmail.com>
Date: Thu, 2 May 2019 09:34:01 +0100
Subject: [PATCH] fix(compiler-cli): log ngcc skipping messages as debug
 instead of info (#30232)

Related to https://github.com/angular/angular-cli/issues/14194, https://github.com/angular/angular-cli/pull/14320

PR Close #30232
---
 integration/ngcc/test.sh                                 | 2 +-
 packages/compiler-cli/ngcc/src/main.ts                   | 6 +++---
 packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts | 8 ++++----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/integration/ngcc/test.sh b/integration/ngcc/test.sh
index 9cfbc7c4d7..5374cc70fe 100755
--- a/integration/ngcc/test.sh
+++ b/integration/ngcc/test.sh
@@ -63,7 +63,7 @@ if [[ $? != 0 ]]; then exit 1; fi
 
 # Can it be safely run again (as a noop)?
 # And check that it logged skipping compilation as expected
-ivy-ngcc | grep 'Skipping'
+ivy-ngcc -l debug | grep 'Skipping'
 if [[ $? != 0 ]]; then exit 1; fi
 
 # Check that running it with logging level error outputs nothing
diff --git a/packages/compiler-cli/ngcc/src/main.ts b/packages/compiler-cli/ngcc/src/main.ts
index 0fc5f7b96d..9da09766e6 100644
--- a/packages/compiler-cli/ngcc/src/main.ts
+++ b/packages/compiler-cli/ngcc/src/main.ts
@@ -91,7 +91,7 @@ export function mainNgcc(
   if (absoluteTargetEntryPointPath &&
       hasProcessedTargetEntryPoint(
           fs, absoluteTargetEntryPointPath, propertiesToConsider, compileAllFormats)) {
-    logger.info('The target entry-point has already been processed');
+    logger.debug('The target entry-point has already been processed');
     return;
   }
 
@@ -124,7 +124,7 @@ export function mainNgcc(
 
       if (hasBeenProcessed(entryPointPackageJson, property)) {
         compiledFormats.add(formatPath);
-        logger.info(`Skipping ${entryPoint.name} : ${property} (already compiled).`);
+        logger.debug(`Skipping ${entryPoint.name} : ${property} (already compiled).`);
         continue;
       }
 
@@ -147,7 +147,7 @@ export function mainNgcc(
               `Skipping ${entryPoint.name} : ${format} (no valid entry point file for this format).`);
         }
       } else if (!compileAllFormats) {
-        logger.info(`Skipping ${entryPoint.name} : ${property} (already compiled).`);
+        logger.debug(`Skipping ${entryPoint.name} : ${property} (already compiled).`);
       }
 
       // Either this format was just compiled or its underlying format was compiled because of a
diff --git a/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts b/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts
index b6a54aaa2c..f8c9023005 100644
--- a/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts
+++ b/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts
@@ -86,7 +86,7 @@ describe('ngcc main()', () => {
           basePath: '/node_modules',
           targetEntryPointPath: '@angular/common/http/testing', logger,
         });
-        expect(logger.logs.info).toContain(['The target entry-point has already been processed']);
+        expect(logger.logs.debug).toContain(['The target entry-point has already been processed']);
       });
 
       it('should process the target if any `propertyToConsider` is not marked as processed', () => {
@@ -97,7 +97,7 @@ describe('ngcc main()', () => {
           targetEntryPointPath: '@angular/common/http/testing',
           propertiesToConsider: ['fesm2015', 'esm5', 'esm2015'], logger,
         });
-        expect(logger.logs.info).not.toContain([
+        expect(logger.logs.debug).not.toContain([
           'The target entry-point has already been processed'
         ]);
       });
@@ -115,7 +115,7 @@ describe('ngcc main()', () => {
              compileAllFormats: false, logger,
            });
 
-           expect(logger.logs.info).not.toContain([
+           expect(logger.logs.debug).not.toContain([
              'The target entry-point has already been processed'
            ]);
          });
@@ -132,7 +132,7 @@ describe('ngcc main()', () => {
              compileAllFormats: false, logger,
            });
 
-           expect(logger.logs.info).toContain([
+           expect(logger.logs.debug).toContain([
              'The target entry-point has already been processed'
            ]);
          });