From 64ae6d206ef76f578e3136d94519ad8e190344e8 Mon Sep 17 00:00:00 2001 From: Olivier Combe Date: Wed, 31 Jan 2018 12:12:33 +0100 Subject: [PATCH] test(common): disable deprecated date pipe tests on chrome mobile (#21933) Closes #21907 PR Close #21933 --- packages/common/test/pipes/date_pipe_spec.ts | 2 +- .../common/test/pipes/deprecated/date_pipe_spec.ts | 11 +++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/common/test/pipes/date_pipe_spec.ts b/packages/common/test/pipes/date_pipe_spec.ts index 0be627a03a..5103b4549a 100644 --- a/packages/common/test/pipes/date_pipe_spec.ts +++ b/packages/common/test/pipes/date_pipe_spec.ts @@ -19,7 +19,7 @@ import localeAr from '@angular/common/locales/ar'; { let date: Date; - xdescribe('DatePipe', () => { + describe('DatePipe', () => { const isoStringWithoutTime = '2015-01-01'; let pipe: DatePipe; diff --git a/packages/common/test/pipes/deprecated/date_pipe_spec.ts b/packages/common/test/pipes/deprecated/date_pipe_spec.ts index 21d934adbb..4d5ea658b7 100644 --- a/packages/common/test/pipes/deprecated/date_pipe_spec.ts +++ b/packages/common/test/pipes/deprecated/date_pipe_spec.ts @@ -12,14 +12,19 @@ import {JitReflector} from '@angular/platform-browser-dynamic/src/compiler_refle import {browserDetection} from '@angular/platform-browser/testing/src/browser_util'; { - xdescribe('DeprecatedDatePipe', () => { + describe('DeprecatedDatePipe', () => { let date: Date; const isoStringWithoutTime = '2015-01-01'; let pipe: DeprecatedDatePipe; // Check the transformation of a date into a pattern function expectDateFormatAs(date: Date | string, pattern: any, output: string): void { - expect(pipe.transform(date, pattern)).toEqual(output); + // disabled on chrome mobile because of the following bug affecting the intl API + // https://bugs.chromium.org/p/chromium/issues/detail?id=796583 + // the android 7 emulator of saucelabs uses chrome mobile 63 + if (!browserDetection.isAndroid && !browserDetection.isWebkit) { + expect(pipe.transform(date, pattern)).toEqual(output); + } } // TODO: reactivate the disabled expectations once emulators are fixed in SauceLabs @@ -160,7 +165,6 @@ import {browserDetection} from '@angular/platform-browser/testing/src/browser_ut Object.keys(dateFixtures).forEach((pattern: string) => { expectDateFormatAs(date, pattern, dateFixtures[pattern]); }); - }); it('should format with pattern aliases', () => { @@ -192,7 +196,6 @@ import {browserDetection} from '@angular/platform-browser/testing/src/browser_ut Object.keys(dateFixtures).forEach((pattern: string) => { expectDateFormatAs(date, pattern, dateFixtures[pattern]); }); - }); it('should format invalid in IE ISO date',