iSharkFly-Docs/angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): improve error message for undefined providers (#13546)

Browse Source 
Closes #10835
This commit is contained in:
Dzmitry Shylovich 2016-12-28 04:05:14 +03:00 committed by Hans
parent 2c0c86e3ce
commit 6b02b80a03
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
modules/@angular/compiler/src/metadata_resolver.ts
View File

@ -862,11 +862,14 @@ export class CompileMetadataResolver {
} else { } else {
provider = resolveForwardRef(provider); provider = resolveForwardRef(provider);
let providerMeta: cpl.ProviderMeta; let providerMeta: cpl.ProviderMeta;
if (provider && typeof provider == 'object' && provider.hasOwnProperty('provide')) { if (provider && typeof provider === 'object' && provider.hasOwnProperty('provide')) {
this._validateProvider(provider); this._validateProvider(provider);
providerMeta = new cpl.ProviderMeta(provider.provide, provider); providerMeta = new cpl.ProviderMeta(provider.provide, provider);
} else if (isValidType(provider)) { } else if (isValidType(provider)) {
providerMeta = new cpl.ProviderMeta(provider, {useClass: provider}); providerMeta = new cpl.ProviderMeta(provider, {useClass: provider});
} else if (provider === void 0) {
this._reportError(new SyntaxError(
`Encountered undefined provider! Usually this means you have a circular dependencies (might be caused by using 'barrel' index.ts files.`));
} else { } else {
const providersInfo = const providersInfo =
(<string[]>providers.reduce( (<string[]>providers.reduce(

10
modules/@angular/compiler/test/metadata_resolver_spec.ts
View File

@ -233,6 +233,16 @@ export function main() {
SyntaxError, /Invalid provider for SimpleService. useClass cannot be undefined./); SyntaxError, /Invalid provider for SimpleService. useClass cannot be undefined./);
})); }));
it('should throw with descriptive error message when provider is undefined',
inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => {
@NgModule({providers: [undefined]})
class SomeModule {
}
expect(() => resolver.loadNgModuleDirectiveAndPipeMetadata(SomeModule, true))
.toThrowError(SyntaxError, /Encountered undefined provider!/);
}));
it('should throw with descriptive error message when one of providers is not present', it('should throw with descriptive error message when one of providers is not present',
inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => { inject([CompileMetadataResolver], (resolver: CompileMetadataResolver) => {
@NgModule({declarations: [MyBrokenComp3]}) @NgModule({declarations: [MyBrokenComp3]})