From 6d23d000571bba1d154d1065985358637ea4fe05 Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Thu, 12 Feb 2015 11:54:22 +0100 Subject: [PATCH] refactor(ViewPort): @Template -> @Viewport, ViewPort -> ViewContainer fixes #595 --- modules/angular2/core.js | 2 +- modules/angular2/docs/core/02_directives.md | 32 ++--- ..._directive.md => 06_viewport_directive.md} | 0 modules/angular2/docs/core/10_view.md | 85 ++++++++---- .../src/core/annotations/annotations.js | 2 +- .../src/core/compiler/element_binder.js | 7 +- .../src/core/compiler/element_injector.js | 14 +- .../core/compiler/pipeline/compile_element.js | 16 +-- .../compiler/pipeline/directive_parser.js | 9 +- .../pipeline/element_binder_builder.js | 4 +- .../pipeline/element_binding_marker.js | 4 +- .../proto_element_injector_builder.js | 6 +- .../shadow_dom_emulation/light_dom.js | 16 +-- modules/angular2/src/core/compiler/view.js | 47 +++---- .../{viewport.js => view_container.js} | 8 +- modules/angular2/src/directives/foreach.js | 30 ++--- modules/angular2/src/directives/if.js | 16 +-- modules/angular2/src/directives/switch.js | 110 ++++++++-------- .../core/compiler/element_injector_spec.js | 10 +- .../test/core/compiler/integration_spec.js | 16 +-- .../pipeline/directive_parser_spec.js | 34 +++-- .../pipeline/element_binder_builder_spec.js | 20 ++- .../pipeline/element_binding_marker_spec.js | 8 +- .../proto_element_injector_builder_spec.js | 8 +- .../compiler/shadow_dom/light_dom_spec.js | 26 ++-- .../shadow_dom_emulation_integration_spec.js | 44 +++---- ...iewport_spec.js => view_container_spec.js} | 122 +++++++++--------- .../angular2/test/core/compiler/view_spec.js | 44 +++---- .../angular2/test/directives/foreach_spec.js | 4 +- .../src/naive_infinite_scroll/app.js | 2 +- .../src/naive_infinite_scroll/cells.js | 2 +- .../src/naive_infinite_scroll/index.js | 10 +- .../src/naive_infinite_scroll/scroll_area.js | 2 +- .../src/naive_infinite_scroll/scroll_item.js | 2 +- modules/benchmarks/src/tree/tree_benchmark.js | 18 +-- .../examples/src/hello_world/index_common.js | 4 +- 36 files changed, 408 insertions(+), 376 deletions(-) rename modules/angular2/docs/core/{06_instantiator_directive.md => 06_viewport_directive.md} (100%) rename modules/angular2/src/core/compiler/{viewport.js => view_container.js} (94%) rename modules/angular2/test/core/compiler/{viewport_spec.js => view_container_spec.js} (63%) diff --git a/modules/angular2/core.js b/modules/angular2/core.js index f761b87ea1..e1fa618601 100644 --- a/modules/angular2/core.js +++ b/modules/angular2/core.js @@ -8,7 +8,7 @@ export * from './src/core/compiler/compiler'; export * from './src/core/compiler/template_loader'; export * from './src/core/compiler/view'; -export * from './src/core/compiler/viewport'; +export * from './src/core/compiler/view_container'; export * from './src/core/compiler/binding_propagation_config'; export * from './src/core/dom/element'; diff --git a/modules/angular2/docs/core/02_directives.md b/modules/angular2/docs/core/02_directives.md index 730f0b368d..c95f0b33fc 100644 --- a/modules/angular2/docs/core/02_directives.md +++ b/modules/angular2/docs/core/02_directives.md @@ -10,7 +10,7 @@ There are three different kinds of directives (described in mored detailed in la 1. *Decorators*: can be placed on any DOM element and can be combined with other directives. 2. *Components*: Components have encapsulated view and can configure injectors. -3. *Instantiator*: Is responsible for adding or removing child views in parent view. (i.e. foreach, if) +3. *Viewport*: Is responsible for adding or removing child views in parent view. (i.e. foreach, if) @@ -164,43 +164,43 @@ Example of usage: -## Instantiator +## Viewport -Instantiator is a directive which can controll instantiation of child views which are then inserted into the DOM. (Examples are `if` and `foreach`.) +Viewport is a directive which can controll instantiation of child views which are then inserted into the DOM. (Examples are `if` and `foreach`.) -* Instantiators can only be placed on `