iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs: update merge label meaning (#28574) 

PR Close #28574
This commit is contained in:
Alex Eagle 2019-02-06 11:21:16 -08:00 committed by Miško Hevery
parent ceada7785e
commit 6e4ef91ceb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/TRIAGE_AND_LABELS.md
View File

@ -126,7 +126,7 @@ Every triaged PR must have a `pr_action` label assigned to it:
* `PR action: review` - work is complete and comment is needed from the reviewers.
* `PR action: cleanup` - more work is needed from the author.
* `PR action: discuss` - discussion is needed, to be led by the author.
* `PR action: merge` - the PR is ready to be merged by the caretaker.
* `PR action: merge` - the PR author is ready for the changes to be merged by the caretaker.
In addition, PRs can have the following states:
@ -178,4 +178,4 @@ This label can be added to let the caretaker know that the PR needs special atte
There should always be a comment added to the PR to explain why the caretaker's assistance is needed.
The comment should be formatted like this: `merge-assistance: <explain what kind of assistance you need, and if not obvious why>`
For example, the PR owner might not be a Googler and needs help to run g3sync; or one of the checks is failing due to external causes and the PR should still be merged.
For example, the PR owner might not be a Googler and needs help to run g3sync; or one of the checks is failing due to external causes and the PR should still be merged.