iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: avoid postinstall error when building material-unit-tests job (#32889) 

The components repository updated to rules_nodejs#0.38.0 before Angular Bazel did.
To do this, the `@angular/bazel` v0.38.0 compatibility changes were patched on postinstall.

This now conflicts because we install a `@angular/bazel` version in the `material-unit-tests` job
that already includes these compatibility changes. This would result in the patch being a noop
for which the `patch` command throws an error.

We can remove this once components can install a released version of `@angular/bazel` that is
compatible with `rules_nodejs#0.38.0`.

PR Close #32889
This commit is contained in:
Paul Gschwendtner 2019-10-03 12:37:41 +02:00 committed by Alex Rickabaugh
parent 3830f6fc14
commit 78ada980a6
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/ci/run_angular_material_unit_tests.sh
View File

@ -14,6 +14,14 @@ angular_dir=$(pwd)
sed -i'.bak' "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" ${MATERIAL_REPO_TMP_DIR}/tools/defaults.bzl sed -i'.bak' "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" ${MATERIAL_REPO_TMP_DIR}/tools/defaults.bzl
sed -i'.bak' "s/\(\"ivyTemplateTypeCheck\": \)False/\1True/g" dist/packages-dist-ivy-aot/bazel/src/ng_module.bzl sed -i'.bak' "s/\(\"ivyTemplateTypeCheck\": \)False/\1True/g" dist/packages-dist-ivy-aot/bazel/src/ng_module.bzl
# The components repository updated to rules_nodejs#0.38.0 before Angular Bazel did. To do this,
# the `@angular/bazel` v0.38.0 compatibility changes were patched on postinstall. This now
# conflicts because we install a `@angular/bazel` version that already includes these compatibility
# changes. This would result in the patch being a noop for which the `patch` command throws.
# To work around this temporarily, we just ensure that the patch does not run on postinstall.
# TODO: remove this once Angular components no longer needs the postinstall patch.
sed -i -r "s/shelljs.cat.+angular_bazel_0\.38\.0\.patch.+;//g" ${MATERIAL_REPO_TMP_DIR}/tools/bazel/postinstall-patches.js
# Switch into Material directory. # Switch into Material directory.
cd ${MATERIAL_REPO_TMP_DIR} cd ${MATERIAL_REPO_TMP_DIR}