iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(core): use more narrow `QueryList` import to avoid circular deps issue (#36286) 

Prior to this commit, the `packages/core/src/render3/interfaces/query.ts` file used to import `QueryList` using `../../linker`, which contains a lot of re-exports and as a result, this one import caused a lot of circular deps cycles reported by the tool that checks such deps. In other places in the code the `QueryList` is imported using more narrow import (`linker/query_list`), so this commit uses the same pattern. This change allowed to reduce the number of known cycles from 343 to 207, the golden file was updated accordingly.

PR Close #36286
This commit is contained in:
Andrew Kushnir 2020-03-27 17:39:14 -07:00 committed by Alex Rickabaugh
parent 5b6ced5599
commit 80c68583d1
2 changed files with 693 additions and 4338 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5029
goldens/packages-circular-deps.json
View File

File diff suppressed because it is too large Load Diff

2
packages/core/src/render3/interfaces/query.ts
View File

@ -7,7 +7,7 @@
*/
import {Type} from '../../interface/type';
import {QueryList} from '../../linker';
import {QueryList} from '../../linker/query_list';
import {TNode} from './node';
import {TView} from './view';