From 8793d1a0462b03eee6141ac6e780912fbe52a6c7 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Mon, 21 Jun 2021 09:02:20 -0700 Subject: [PATCH] ci: update pullapprove config (#42613) Update the fallback group in pullapprove to define a reviewer for the group, in preparation for the upcoming change to how pullapprove billing works. The new billing will work on a seats based approach rather than flat usage. PR Close #42613 --- .pullapprove.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.pullapprove.yml b/.pullapprove.yml index 41de32cd10..190ac38f6e 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -1336,3 +1336,17 @@ groups: # ensure that no explicit global approval has been provided. - *can-be-global-approved - *can-be-global-docs-approved + # PullApprove uses a combination of users defined in the pullapprove configuration and the + # number of users who have performed reviews on Github in the recent past if the configuration + # does not specify it. Because, as an open source project, anyone on Github can perform a + # review we need to ensure that all groups, including the fallback group, have at least one user + # or group defined as reviewers. + reviewers: + users: + - josephperrott + reviews: + request: 0 + required: 1 + # Reviewed-for is required on fallback as it should not ever actually be reviewed, requiring + # Reviewed-for helps insure an accidental approval doesn't occur on the fallback group. + reviewed_for: required