From 88c30e231a33a058691a53f3d627b1c7df975269 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Tue, 27 Nov 2018 12:47:38 -0800 Subject: [PATCH] test(ivy): add/remove fixmes in packages/bazel/test/ngc-wrapped (#27302) PR Close #27302 --- packages/bazel/test/ngc-wrapped/BUILD.bazel | 2 +- packages/bazel/test/ngc-wrapped/empty/BUILD.bazel | 2 +- packages/bazel/test/ngc-wrapped/index_test.ts | 6 +++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/bazel/test/ngc-wrapped/BUILD.bazel b/packages/bazel/test/ngc-wrapped/BUILD.bazel index b8c60fbc92..aaa5aa9cd8 100644 --- a/packages/bazel/test/ngc-wrapped/BUILD.bazel +++ b/packages/bazel/test/ngc-wrapped/BUILD.bazel @@ -31,7 +31,7 @@ jasmine_node_test( ":angular_core", "//packages/bazel/test/ngc-wrapped/empty:empty_tsconfig.json", "//packages/bazel/test/ngc-wrapped/empty:tsconfig.json", + "//packages/private/testing", "@build_bazel_rules_typescript//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto", ], - tags = ["fixme-ivy-aot"], ) diff --git a/packages/bazel/test/ngc-wrapped/empty/BUILD.bazel b/packages/bazel/test/ngc-wrapped/empty/BUILD.bazel index 1e8fe10176..7fe7d72d97 100644 --- a/packages/bazel/test/ngc-wrapped/empty/BUILD.bazel +++ b/packages/bazel/test/ngc-wrapped/empty/BUILD.bazel @@ -5,7 +5,7 @@ package(default_visibility = ["//packages/bazel/test:__subpackages__"]) ng_module( name = "empty", srcs = ["empty.ts"], - tags = ["fixme-ivy-aot"], + tags = ["fixme-ivy-aot"], # FW-741: ngtsc breaks tsc module resolution tsconfig = ":tsconfig.json", deps = [ "//packages/core", diff --git a/packages/bazel/test/ngc-wrapped/index_test.ts b/packages/bazel/test/ngc-wrapped/index_test.ts index 49a85d99a6..3c12370add 100644 --- a/packages/bazel/test/ngc-wrapped/index_test.ts +++ b/packages/bazel/test/ngc-wrapped/index_test.ts @@ -6,6 +6,7 @@ * found in the LICENSE file at https://angular.io/license */ +import {fixmeIvy} from '@angular/private/testing'; import * as fs from 'fs'; import * as path from 'path'; @@ -13,7 +14,10 @@ import {setup} from './test_support'; describe('ngc_wrapped', () => { - it('should work', () => { + // fixmeIvy placeholder to prevent jasmine from erroring out because there are no specs + it('should be removed once the fixmeIvy below is resolved', () => {}); + + fixmeIvy('FW-741: ngtsc breaks tsc module resolution') && it('should work', () => { const {read, write, runOneBuild, writeConfig, shouldExist, basePath} = setup(); write('some_project/index.ts', `