From 89b5b973684c2efb155a44b4807865e0a209db6c Mon Sep 17 00:00:00 2001 From: Keen Yee Liau Date: Mon, 2 Mar 2020 20:21:40 -0800 Subject: [PATCH] build: avoid running duplicate tests in language service (#35816) The test libs should only be included in one jasmine_node_test otherwise `bazel build //packages/language-service/...` would end up running `feature_test` and `infra_test` twice. PR Close #35816 --- packages/language-service/test/BUILD.bazel | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/packages/language-service/test/BUILD.bazel b/packages/language-service/test/BUILD.bazel index 13d4174edf..c033a20067 100644 --- a/packages/language-service/test/BUILD.bazel +++ b/packages/language-service/test/BUILD.bazel @@ -62,7 +62,7 @@ ts_library( ) jasmine_node_test( - name = "features_test", + name = "test", data = [ "//packages/common:npm_package", "//packages/core:npm_package", @@ -93,23 +93,6 @@ jasmine_node_test( ], ) -jasmine_node_test( - name = "test", - data = [ - "//packages/common:npm_package", - "//packages/core:npm_package", - "//packages/forms:npm_package", - ], - tags = [ - # the language service is not yet compatible with Ivy - "no-ivy-aot", - ], - deps = [ - ":features_test_lib", - ":infra_test_lib", - ], -) - ts_library( name = "diagnostics_lib", testonly = True,