From 8a05199fb9be5ef91ec8094a3c6abc0a65eb6bcd Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Tue, 25 Dec 2018 12:43:37 -0800 Subject: [PATCH] test: remove bower and polymer benchmarks (#27931) the polymer benchmarks are super old and not relevant any more and these benchmarks were the only reason why we needed bower at all so long, bower. thanks for all the fish. PR Close #27931 --- .bowerrc | 3 -- bower.json | 6 --- build.sh | 1 - docs/DEVELOPER.md | 1 - modules/benchmarks/e2e_test/tree_data.ts | 12 ------ .../src/tree/polymer/binary_tree.html | 22 ----------- .../benchmarks/src/tree/polymer/index.html | 34 ----------------- modules/benchmarks/src/tree/polymer/index.ts | 29 --------------- .../e2e_test/polymer_tree_perf.ts | 37 ------------------- modules/benchmarks_external/src/index.html | 3 -- package.json | 1 - scripts/ci/install.sh | 5 --- yarn.lock | 5 --- 13 files changed, 159 deletions(-) delete mode 100644 .bowerrc delete mode 100644 bower.json delete mode 100644 modules/benchmarks/src/tree/polymer/binary_tree.html delete mode 100644 modules/benchmarks/src/tree/polymer/index.html delete mode 100644 modules/benchmarks/src/tree/polymer/index.ts delete mode 100644 modules/benchmarks_external/e2e_test/polymer_tree_perf.ts diff --git a/.bowerrc b/.bowerrc deleted file mode 100644 index 9b2abeb660..0000000000 --- a/.bowerrc +++ /dev/null @@ -1,3 +0,0 @@ -{ - "directory" : "bower_components" -} diff --git a/bower.json b/bower.json deleted file mode 100644 index 007371a434..0000000000 --- a/bower.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "name": "angular", - "dependencies": { - "polymer": "Polymer/polymer#^1.6.0" - } -} diff --git a/build.sh b/build.sh index 722b1fc2ea..f77f1a4f31 100755 --- a/build.sh +++ b/build.sh @@ -407,7 +407,6 @@ if [[ ${BUILD_ALL} == true && ${TYPECHECK_ALL} == true ]]; then ln -s ../../../../node_modules/reflect-metadata/Reflect.js . ln -s ../../../../node_modules/rxjs . ln -s ../../../../node_modules/angular/angular.js . - ln -s ../../../../bower_components/polymer . ln -s ../../../../node_modules/incremental-dom/dist/incremental-dom-cjs.js ) travisFoldEnd "copy e2e files" diff --git a/docs/DEVELOPER.md b/docs/DEVELOPER.md index fb596c47a9..4ff45de528 100644 --- a/docs/DEVELOPER.md +++ b/docs/DEVELOPER.md @@ -185,7 +185,6 @@ and create it if it doesn't exist. "files.exclude": { "bazel-out": true, ".idea": true, - ".bowerrc": true, ".circleci": true, ".github": true, "dist/**": true, diff --git a/modules/benchmarks/e2e_test/tree_data.ts b/modules/benchmarks/e2e_test/tree_data.ts index d33c597f54..708c3b8437 100644 --- a/modules/benchmarks/e2e_test/tree_data.ts +++ b/modules/benchmarks/e2e_test/tree_data.ts @@ -73,18 +73,6 @@ export const Benchmarks: Benchmark[] = [ buttons: CreateDestroyButtons, ignoreBrowserSynchronization: true, }, - { - id: `deepTree.polymer`, - url: 'all/benchmarks/src/tree/polymer/index.html', - buttons: CreateDestroyButtons, - ignoreBrowserSynchronization: true, - }, - { - id: `deepTree.polymer_leaves`, - url: 'all/benchmarks/src/tree/polymer_leaves/index.html', - buttons: CreateDestroyButtons, - ignoreBrowserSynchronization: true, - }, { id: `deepTree.ng1`, url: 'all/benchmarks/src/tree/ng1/index.html', diff --git a/modules/benchmarks/src/tree/polymer/binary_tree.html b/modules/benchmarks/src/tree/polymer/binary_tree.html deleted file mode 100644 index ebab874dfa..0000000000 --- a/modules/benchmarks/src/tree/polymer/binary_tree.html +++ /dev/null @@ -1,22 +0,0 @@ - - - - - diff --git a/modules/benchmarks/src/tree/polymer/index.html b/modules/benchmarks/src/tree/polymer/index.html deleted file mode 100644 index ce2c79c35f..0000000000 --- a/modules/benchmarks/src/tree/polymer/index.html +++ /dev/null @@ -1,34 +0,0 @@ - - - - - - - - - -

Params

-
- Depth: - -
- -
- -

Polymer Tree Benchmark

-

- - - - -

- -
- -
- - - - - - \ No newline at end of file diff --git a/modules/benchmarks/src/tree/polymer/index.ts b/modules/benchmarks/src/tree/polymer/index.ts deleted file mode 100644 index 5f1ee89984..0000000000 --- a/modules/benchmarks/src/tree/polymer/index.ts +++ /dev/null @@ -1,29 +0,0 @@ -/** - * @license - * Copyright Google Inc. All Rights Reserved. - * - * Use of this source code is governed by an MIT-style license that can be - * found in the LICENSE file at https://angular.io/license - */ - -import {bindAction, profile} from '../../util'; -import {buildTree, emptyTree} from '../util'; - -declare var Polymer: any; - -export function main() { - const rootEl: any = document.querySelector('binary-tree'); - rootEl.data = emptyTree; - - function destroyDom() { rootEl.data = emptyTree; } - - function createDom() { rootEl.data = buildTree(); } - - function noop() {} - - bindAction('#destroyDom', destroyDom); - bindAction('#createDom', createDom); - - bindAction('#updateDomProfile', profile(createDom, noop, 'update')); - bindAction('#createDomProfile', profile(createDom, destroyDom, 'create')); -} diff --git a/modules/benchmarks_external/e2e_test/polymer_tree_perf.ts b/modules/benchmarks_external/e2e_test/polymer_tree_perf.ts deleted file mode 100644 index 731abd8c4a..0000000000 --- a/modules/benchmarks_external/e2e_test/polymer_tree_perf.ts +++ /dev/null @@ -1,37 +0,0 @@ -/** - * @license - * Copyright Google Inc. All Rights Reserved. - * - * Use of this source code is governed by an MIT-style license that can be - * found in the LICENSE file at https://angular.io/license - */ - -import {runClickBenchmark, verifyNoBrowserErrors} from '@angular/testing/src/perf_util'; - -describe('polymer tree benchmark', function() { - - const URL = 'benchmarks_external/src/tree/polymer/index.html'; - - afterEach(verifyNoBrowserErrors); - - it('should log the stats (create)', function(done) { - runClickBenchmark({ - url: URL, - buttons: ['#destroyDom', '#createDom'], - id: 'polymer.tree.create', - params: [{name: 'depth', value: 9, scale: 'log2'}], - waitForAngular2: false - }).then(done, done.fail); - }); - - it('should log the stats (update)', function(done) { - runClickBenchmark({ - url: URL, - buttons: ['#createDom'], - id: 'polymer.tree.update', - params: [{name: 'depth', value: 9, scale: 'log2'}], - waitForAngular2: false - }).then(done, done.fail); - }); - -}); diff --git a/modules/benchmarks_external/src/index.html b/modules/benchmarks_external/src/index.html index d9c74f9c2e..7a9640adcc 100644 --- a/modules/benchmarks_external/src/index.html +++ b/modules/benchmarks_external/src/index.html @@ -11,9 +11,6 @@
  • Static tree benchmark
    • -
  • - Polymer Tree benchmark -
  • React Tree benchmark
    • diff --git a/package.json b/package.json index afe8815ab0..8f3a230876 100644 --- a/package.json +++ b/package.json @@ -96,7 +96,6 @@ "@types/jasminewd2": "^2.0.4", "@types/minimist": "^1.2.0", "@types/systemjs": "0.19.32", - "bower": "1.8.2", "browserstacktunnel-wrapper": "2.0.1", "clang-format": "1.0.41", "cldr": "4.10.0", diff --git a/scripts/ci/install.sh b/scripts/ci/install.sh index ce5b9171b6..5703cb177b 100755 --- a/scripts/ci/install.sh +++ b/scripts/ci/install.sh @@ -41,11 +41,6 @@ travisFoldStart "yarn-install" travisFoldEnd "yarn-install" -# Install bower packages -travisFoldStart "bower-install" - $(npm bin)/bower install -travisFoldEnd "bower-install" - # Install Chromium if [[ ${TRAVIS} && diff --git a/yarn.lock b/yarn.lock index ec5e09d818..94093515b5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1065,11 +1065,6 @@ boom@5.x.x: dependencies: hoek "4.x.x" -bower@1.8.2: - version "1.8.2" - resolved "https://registry.yarnpkg.com/bower/-/bower-1.8.2.tgz#adf53529c8d4af02ef24fb8d5341c1419d33e2f7" - integrity sha1-rfU1KcjUrwLvJPuNU0HBQZ0z4vc= - brace-expansion@^1.0.0, brace-expansion@^1.1.7: version "1.1.11" resolved "https://registry.yarnpkg.com/brace-expansion/-/brace-expansion-1.1.11.tgz#3c7fcbf529d87226f3d2f52b966ff5271eb441dd"