iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ivy): unknown property and element checks not working correctly in IE (#34305) 

We have a couple of cases where we use something like `typeof Node === 'function'` to figure out whether we're in a worker context. This works in most browsers, but IE returns `object` instead of `function`. I've updated all the usages to account for it.

PR Close #34305
This commit is contained in:
crisbeto 2019-12-11 22:03:00 +01:00 committed by Kara Erickson
parent c45a70c3b8
commit 8eb0596463
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/core/src/render3/instructions/element.ts
View File

@ -271,7 +271,10 @@ function validateElement(
// as a custom element. Note that unknown elements with a dash in their name won't be instances // as a custom element. Note that unknown elements with a dash in their name won't be instances
// of HTMLUnknownElement in browsers that support web components. // of HTMLUnknownElement in browsers that support web components.
const isUnknown = const isUnknown =
(typeof HTMLUnknownElement === 'function' && element instanceof HTMLUnknownElement) || // Note that we can't check for `typeof HTMLUnknownElement === 'function'`,
// because while most browsers return 'function', IE returns 'object'.
(typeof HTMLUnknownElement !== 'undefined' && HTMLUnknownElement &&
element instanceof HTMLUnknownElement) ||
(typeof customElements !== 'undefined' && tagName.indexOf('-') > -1 && (typeof customElements !== 'undefined' && tagName.indexOf('-') > -1 &&
!customElements.get(tagName)); !customElements.get(tagName));

10
packages/core/src/render3/instructions/shared.ts
View File

@ -1011,8 +1011,14 @@ function validateProperty(
hostView: LView, element: RElement | RComment, propName: string, tNode: TNode): boolean { hostView: LView, element: RElement | RComment, propName: string, tNode: TNode): boolean {
// The property is considered valid if the element matches the schema, it exists on the element // The property is considered valid if the element matches the schema, it exists on the element
// or it is synthetic, and we are in a browser context (web worker nodes should be skipped). // or it is synthetic, and we are in a browser context (web worker nodes should be skipped).
return matchingSchemas(hostView, tNode.tagName) || propName in element || if (matchingSchemas(hostView, tNode.tagName) || propName in element ||
isAnimationProp(propName) || typeof Node !== 'function' || !(element instanceof Node); isAnimationProp(propName)) {
return true;
}
// Note: `typeof Node` returns 'function' in most browsers, but on IE it is 'object' so we
// need to account for both here, while being careful for `typeof null` also returning 'object'.
return typeof Node === 'undefined' || Node === null || !(element instanceof Node);
} }
export function matchingSchemas(hostView: LView, tagName: string | null): boolean { export function matchingSchemas(hostView: LView, tagName: string | null): boolean {