iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(language-service): avoid throwing for invalid class declarations (#13257) 

Fixes #13253
This commit is contained in:
Chuck Jazdzewski 2016-12-06 09:56:30 -08:00 committed by Alex Rickabaugh
parent 5614c4ff0f
commit 93556a5720
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/@angular/language-service/src/typescript_host.ts
View File

@ -325,7 +325,7 @@ export class TypeScriptServiceHost implements LanguageServiceHost {
case this.ts.SyntaxKind.StringLiteral: case this.ts.SyntaxKind.StringLiteral:
let [declaration, decorator] = this.getTemplateClassDeclFromNode(node); let [declaration, decorator] = this.getTemplateClassDeclFromNode(node);
let queryCache: SymbolQuery|undefined = undefined; let queryCache: SymbolQuery|undefined = undefined;
if (declaration) { if (declaration && declaration.name) {
const sourceFile = this.getSourceFile(fileName); const sourceFile = this.getSourceFile(fileName);
return this.getSourceFromDeclaration( return this.getSourceFromDeclaration(
fileName, version, this.stringOf(node), shrink(spanOf(node)), fileName, version, this.stringOf(node), shrink(spanOf(node)),

6
modules/@angular/language-service/test/diagnostics_spec.ts
View File

@ -115,6 +115,12 @@ describe('diagnostics', () => {
}); });
}); });
it('should not throw for an invalid class', () => {
const code = ` @Component({template: ''}) class`;
addCode(
code, fileName => { expect(() => ngService.getDiagnostics(fileName)).not.toThrow(); });
});
function addCode(code: string, cb: (fileName: string, content?: string) => void) { function addCode(code: string, cb: (fileName: string, content?: string) => void) {
const fileName = '/app/app.component.ts'; const fileName = '/app/app.component.ts';
const originalContent = mockHost.getFileContent(fileName); const originalContent = mockHost.getFileContent(fileName);