iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(ngcc): move "Compiling" log message before starting work on a task (#36626) 

Previously, the "Compiling <entryPoint>" log message was printed before
starting to analyze and transform files, but after creating the
`EntryPointBundle` (which includes creating the TS program).

Since creating the `EntryPointBundle` involves some work, it is more
accurate to move the log message before creating the bundle.

PR Close #36626
This commit is contained in:
George Kalpakas 2020-04-29 21:28:02 +03:00 committed by Andrew Kushnir
parent 62ba0acfb5
commit 9aa778e843
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/compiler-cli/ngcc/src/execution/create_compile_function.ts
View File

@ -57,12 +57,12 @@ export function getCreateCompileFn(
`${formatProperty} (formatPath: ${formatPath} | format: ${format})`); `${formatProperty} (formatPath: ${formatPath} | format: ${format})`);
} }
logger.info(`Compiling ${entryPoint.name} : ${formatProperty} as ${format}`);
const bundle = makeEntryPointBundle( const bundle = makeEntryPointBundle(
fileSystem, entryPoint, formatPath, isCore, format, processDts, pathMappings, true, fileSystem, entryPoint, formatPath, isCore, format, processDts, pathMappings, true,
enableI18nLegacyMessageIdFormat); enableI18nLegacyMessageIdFormat);
logger.info(`Compiling ${entryPoint.name} : ${formatProperty} as ${format}`);
const result = transformer.transform(bundle); const result = transformer.transform(bundle);
if (result.success) { if (result.success) {
if (result.diagnostics.length > 0) { if (result.diagnostics.length > 0) {