From 9bde1be5a4ffbf4c8bb315a093ae778a13edcd69 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Wed, 6 May 2020 18:39:42 +0200 Subject: [PATCH] test: disable ng_package tests in ivy test jobs (#36944) Since we no longer hardcode the `package.json` for entry-points, a bug has appeared for `ng_package` in Ivy. The `package.json` files are populated incorrectly with Ivy as the flat module bundle name is not propagated from `ng_module` to the `ng_package` rule. The rule then guesses the index file to `index.js` and does not respect the flat module bundle shim. PR Close #36944 --- packages/bazel/test/ng_package/BUILD.bazel | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/bazel/test/ng_package/BUILD.bazel b/packages/bazel/test/ng_package/BUILD.bazel index 0b2d2adb4a..71dd36a633 100644 --- a/packages/bazel/test/ng_package/BUILD.bazel +++ b/packages/bazel/test/ng_package/BUILD.bazel @@ -25,6 +25,10 @@ jasmine_node_test( "@npm//@types/shelljs", "@npm//shelljs", ], + # The "ng_package" rule currently does not properly handle flat module + # bundles which the common package tests rely on. We temporarily disable + # this test until we fix `ng_package` for Ivy. Tracked with: FW-2144. + tags = ["fixme-ivy-aot"], ) ts_library( @@ -45,6 +49,10 @@ jasmine_node_test( "//packages/common:npm_package", "@npm//shelljs", ], + # The "ng_package" rule currently does not properly handle flat module + # bundles which the common package tests rely on. We temporarily disable + # this test until we fix `ng_package` for Ivy. Tracked with: FW-2144. + tags = ["fixme-ivy-aot"], ) ts_library(