From 9be8abd0126b76a13d511eb393257e4c5c665d69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matias=20Niemel=C3=A4?= Date: Mon, 16 Jul 2018 11:41:02 -0700 Subject: [PATCH] build: disable IE web worker tests (#24908) Travis (saucelabs) has been super flaky when running IE web worker tests lately. This patch temporarily disables these tests on IE (not edge) until things get more stable. PR Close #24908 --- .../worker/renderer_v2_integration_spec.ts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/packages/platform-webworker/test/web_workers/worker/renderer_v2_integration_spec.ts b/packages/platform-webworker/test/web_workers/worker/renderer_v2_integration_spec.ts index 4b1320c72f..3a3b5e209f 100644 --- a/packages/platform-webworker/test/web_workers/worker/renderer_v2_integration_spec.ts +++ b/packages/platform-webworker/test/web_workers/worker/renderer_v2_integration_spec.ts @@ -81,6 +81,10 @@ let lastCreatedRenderer: Renderer2; } it('should update text nodes', () => { + // IE (v11 to be exact) has been problematic lately with saucelabs for this specific test + // TODO (matsko): revisit this once things become more stable in the saucelabs world + if (isOldIE()) return; + const fixture = TestBed.overrideTemplate(MyComp2, '
{{ctxProp}}
').createComponent(MyComp2); const renderEl = getRenderElement(fixture.nativeElement); @@ -93,6 +97,10 @@ let lastCreatedRenderer: Renderer2; it('should update any element property/attributes/class/style(s) independent of the compilation on the root element and other elements', () => { + // IE (v11 to be exact) has been problematic lately with saucelabs for this specific test + // TODO (matsko): revisit this once things become more stable in the saucelabs world + if (isOldIE()) return; + const fixture = TestBed.overrideTemplate(MyComp2, '') .createComponent(MyComp2); @@ -127,6 +135,10 @@ let lastCreatedRenderer: Renderer2; }); it('should update any template comment property/attributes', () => { + // IE (v11 to be exact) has been problematic lately with saucelabs for this specific test + // TODO (matsko): revisit this once things become more stable in the saucelabs world + if (isOldIE()) return; + const fixture = TestBed.overrideTemplate(MyComp2, '') .createComponent(MyComp2); @@ -137,6 +149,10 @@ let lastCreatedRenderer: Renderer2; }); it('should add and remove fragments', () => { + // IE (v11 to be exact) has been problematic lately with saucelabs for this specific test + // TODO (matsko): revisit this once things become more stable in the saucelabs world + if (isOldIE()) return; + const fixture = TestBed .overrideTemplate(MyComp2, 'hello') @@ -156,6 +172,10 @@ let lastCreatedRenderer: Renderer2; if (getDOM().supportsDOMEvents()) { it('should listen to events', () => { + // IE (v11 to be exact) has been problematic lately with saucelabs for this specific test + // TODO (matsko): revisit this once things become more stable in the saucelabs world + if (isOldIE()) return; + const fixture = TestBed.overrideTemplate(MyComp2, '') .createComponent(MyComp2); @@ -214,3 +234,8 @@ class RenderFactory extends WebWorkerRendererFactory2 { return lastCreatedRenderer; } } + +function isOldIE() { + // note that this only applies to older IEs (not edge) + return (window as any).document['documentMode'] ? true : false; +}