fix(benchpress): fix flake
memory was not allocated to be high enough, resulting in partial results to be clipped, and therefore failing the assertions Closes #6161
This commit is contained in:
parent
d116861c8e
commit
9d28147acb
|
@ -54,7 +54,7 @@ mod.PageMod({
|
|||
contentScriptFile: data.url('installed_script.js'),
|
||||
onAttach: worker => {
|
||||
worker.port.on('startProfiler',
|
||||
(timeStarted) => profiler.start(/* = profiler memory */ 1000000, 0.1,
|
||||
(timeStarted) => profiler.start(/* = profiler memory */ 3000000, 0.1,
|
||||
['leaf', 'js', 'stackwalk', 'gc'], timeStarted));
|
||||
worker.port.on('stopProfiler', () => profiler.stop());
|
||||
worker.port.on('getProfile',
|
||||
|
|
|
@ -24,6 +24,7 @@ describe('firefox extension', function() {
|
|||
browser.executeScript('window.startProfiler()')
|
||||
.then(function() { console.log('started measuring perf'); });
|
||||
|
||||
browser.executeAsyncScript('setTimeout(arguments[0], 1000);');
|
||||
browser.executeScript('window.forceGC()');
|
||||
|
||||
browser.executeAsyncScript('var cb = arguments[0]; window.getProfile(cb);')
|
||||
|
|
|
@ -30,8 +30,5 @@ fi
|
|||
|
||||
./node_modules/.bin/protractor protractor-js.conf.js $OPTIONS
|
||||
./node_modules/.bin/protractor protractor-js.conf.js $OPTIONS --benchmark --dryrun
|
||||
# TODO(tbosch): tests for benchpress on firefox are disabled
|
||||
# as they are very flake. Enable once https://github.com/angular/angular/issues/5611
|
||||
# is resolved.
|
||||
# ./node_modules/.bin/protractor dist/js/cjs/benchpress/test/firefox_extension/conf.js
|
||||
./node_modules/.bin/protractor dist/js/cjs/benchpress/test/firefox_extension/conf.js
|
||||
|
||||
|
|
Loading…
Reference in New Issue