From 9ed3bd6b4fea14b513aa16c98bc772cb85e46b3d Mon Sep 17 00:00:00 2001 From: Vikram Subramanian Date: Fri, 17 Aug 2018 15:07:39 -0700 Subject: [PATCH] refactor(bazel): allow and ignore extra args for _ts_expected_outs (#25558) This is needed to let ts_compile_actions take explicit list of srcs and deps to generate tsc actions from another rule. This is no-op for ngc for now. PR Close #25558 --- packages/bazel/src/ng_module.bzl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/bazel/src/ng_module.bzl b/packages/bazel/src/ng_module.bzl index 4d37bf8f05..ed8533bbc6 100644 --- a/packages/bazel/src/ng_module.bzl +++ b/packages/bazel/src/ng_module.bzl @@ -417,10 +417,10 @@ def _devmode_compile_action(ctx, inputs, outputs, tsconfig_file, node_opts): compile_action_outputs = outputs + outs.devmode_js + outs.declarations + outs.summaries + outs.metadata _compile_action(ctx, inputs, compile_action_outputs, None, tsconfig_file, node_opts) -def _ts_expected_outs(ctx, label): - # rules_typescript expects a function with two arguments, but our - # implementation doesn't use the label - _ignored = [label] +def _ts_expected_outs(ctx, label, srcs_files = []): + # rules_typescript expects a function with two or more arguments, but our + # implementation doesn't use the label(and **kwargs). + _ignored = [label, srcs_files] return _expected_outs(ctx) def ng_module_impl(ctx, ts_compile_actions):