From a1d7b6bb861738b847fa4d8961e06130c3ed5243 Mon Sep 17 00:00:00 2001 From: Misko Hevery Date: Tue, 22 Oct 2019 20:23:58 -0700 Subject: [PATCH] test(ivy): fined tune micro benchmark parameters (#33341) Decrease `MIN_SAMPLE_DURATION` to make it more likely that we cane fit into single time slice. Increase `MIN_SAMPLE_COUNT_NO_IMPROVEMENT` to make it more likely to find the best PR Close #33341 --- packages/core/test/render3/perf/micro_bench.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/test/render3/perf/micro_bench.ts b/packages/core/test/render3/perf/micro_bench.ts index f3c7940079..001add0785 100644 --- a/packages/core/test/render3/perf/micro_bench.ts +++ b/packages/core/test/render3/perf/micro_bench.ts @@ -8,10 +8,10 @@ const performance = require('perf_hooks').performance; // Higher number here makes it more likely that we are more sure of the result. -const MIN_SAMPLE_COUNT_NO_IMPROVEMENT = 100; +const MIN_SAMPLE_COUNT_NO_IMPROVEMENT = 500; // A smaller number here means that we are coming too close on timer resultion, but it also means // that it is less likely that we will be bothered by GC or preemptive multi tasking. -const MIN_SAMPLE_DURATION = 10; +const MIN_SAMPLE_DURATION = 3; const UNITS = ['ms', 'us', 'ns', 'ps']; export interface Benchmark {