iSharkFly-Docs
/
angular-docs-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build(docs-infra): remove linting from the preview server `dev` npm script (#36837) 

Previously, the `dev` npm script in `aio/aio-builds-setup/scripts-js/`
(the PR preview server implementation) would run both linting and unit
tests. This was slow and delayed the feedback loop on each change.

Since the `dev` script should be run during development and give
feedback as fast as possible, this commit removes the linting from the
`dev` script and only keeps the unit tests. Linting is still run in the
`test` npm script (which is more comprehensive). Also, in most cases the
developer's IDE will show linting errors in real time in the editor.

PR Close #36837
This commit is contained in:
George Kalpakas 2020-05-02 16:14:13 +03:00 committed by Alex Rickabaugh
parent d1a8afbbd0
commit a25c3c5c3b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
aio/aio-builds-setup/dockerbuild/scripts-js/package.json
View File

@ -14,13 +14,12 @@
"predev": "yarn build || true", "predev": "yarn build || true",
"dev": "run-p ~~build-watch ~~test-watch", "dev": "run-p ~~build-watch ~~test-watch",
"lint": "tslint --project tsconfig.json", "lint": "tslint --project tsconfig.json",
"pretest": "yarn build", "pretest": "run-s build lint",
"test": "yarn ~~test-only", "test": "yarn ~~test-only",
"pretest-watch": "yarn pretest", "pretest-watch": "yarn pretest",
"test-watch": "yarn ~~test-watch", "test-watch": "yarn ~~test-watch",
"~~build": "tsc", "~~build": "tsc",
"~~build-watch": "yarn ~~build --watch", "~~build-watch": "yarn ~~build --watch",
"pre~~test-only": "yarn lint",
"~~test-only": "node dist/test", "~~test-only": "node dist/test",
"~~test-watch": "nodemon --delay 1 --exec \"yarn ~~test-only\" --watch dist" "~~test-watch": "nodemon --delay 1 --exec \"yarn ~~test-only\" --watch dist"
}, },