From a323b9b1a37bcf0034716193cc40e13638522d3f Mon Sep 17 00:00:00 2001 From: Pawel Kozlowski Date: Mon, 9 Mar 2020 15:34:01 +0100 Subject: [PATCH] test(core): re-enable IE 10/11 test on SauceLabs (#35962) I was not able to reproduce IE 10/11 failrue of the disabled tests on SauceLabs any more. I did some cleanup of the test in question but I doubt it was the root cause of the problem. PR Close #35962 --- packages/core/test/BUILD.bazel | 9 --------- packages/core/test/linker/ng_module_integration_spec.ts | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/core/test/BUILD.bazel b/packages/core/test/BUILD.bazel index 3e65243eeb..d5fc991815 100644 --- a/packages/core/test/BUILD.bazel +++ b/packages/core/test/BUILD.bazel @@ -87,15 +87,6 @@ jasmine_node_test( karma_web_test_suite( name = "test_web", - tags = [ - # FIXME: fix on saucelabs - # IE 11.0.0 (Windows 8.1.0.0) ivy NgModule providers should throw when the aliased provider does not exist FAILED - # Error: Expected function to throw an exception with message 'R3InjectorError(SomeModule)[car -> SportsCar]: - # NullInjectorError: No provider for Car!', but it threw an exception with message 'R3InjectorError(SomeModule)[car -> Car]: - # NullInjectorError: No provider for Car!'. - # at - "fixme-saucelabs-ivy", - ], deps = [ ":test_lib", ], diff --git a/packages/core/test/linker/ng_module_integration_spec.ts b/packages/core/test/linker/ng_module_integration_spec.ts index 152f42e68c..08acb83c10 100644 --- a/packages/core/test/linker/ng_module_integration_spec.ts +++ b/packages/core/test/linker/ng_module_integration_spec.ts @@ -794,7 +794,7 @@ function declareTests(config?: {useJit: boolean}) { const injector = createInjector([{provide: 'car', useExisting: SportsCar}]); let errorMsg = `NullInjectorError: No provider for ${stringify(SportsCar)}!`; if (ivyEnabled) { - errorMsg = `R3InjectorError(SomeModule)[car -> SportsCar]: \n ` + errorMsg; + errorMsg = `R3InjectorError(SomeModule)[car -> ${stringify(SportsCar)}]: \n ` + errorMsg; } expect(() => injector.get('car')).toThrowError(errorMsg); });